Currently, Chrome bypasses the data reduction proxy on POSTs. It should bypass the data reduction proxy on all non-idempotent requests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbc93e59b496ff6ea423527d1a3579fa8a2d061c commit fbc93e59b496ff6ea423527d1a3579fa8a2d061c Author: ryansturm <ryansturm@chromium.org> Date: Tue May 24 01:18:09 2016 Change POST-exclusion to idempotent-inclusion The data saver proxy should only be used for idempotent methods, but right now it only checks if the method is POST, which leaves out other non-idempotent methods like PATCH. Instead of excluding POST and PATCH, this will explicitly check if the method is GET, OPTIONS, HEAD, PUT, DELETE, or TRACE. BUG= 614078 Review-Url: https://codereview.chromium.org/2001243002 Cr-Commit-Position: refs/heads/master@{#395502} [modify] https://crrev.com/fbc93e59b496ff6ea423527d1a3579fa8a2d061c/components/data_reduction_proxy.gypi [modify] https://crrev.com/fbc93e59b496ff6ea423527d1a3579fa8a2d061c/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc [modify] https://crrev.com/fbc93e59b496ff6ea423527d1a3579fa8a2d061c/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.h [modify] https://crrev.com/fbc93e59b496ff6ea423527d1a3579fa8a2d061c/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc [modify] https://crrev.com/fbc93e59b496ff6ea423527d1a3579fa8a2d061c/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc [modify] https://crrev.com/fbc93e59b496ff6ea423527d1a3579fa8a2d061c/components/data_reduction_proxy/core/common/BUILD.gn [add] https://crrev.com/fbc93e59b496ff6ea423527d1a3579fa8a2d061c/components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc [add] https://crrev.com/fbc93e59b496ff6ea423527d1a3579fa8a2d061c/components/data_reduction_proxy/core/common/data_reduction_proxy_util.h
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Tarun, can you merge this?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/554bbbaa0daf530ff667372bc1db72dbe90f6b38 commit 554bbbaa0daf530ff667372bc1db72dbe90f6b38 Author: Tarun Bansal <tbansal@google.com> Date: Wed May 25 18:09:27 2016 Change POST-exclusion to idempotent-inclusion The data saver proxy should only be used for idempotent methods, but right now it only checks if the method is POST, which leaves out other non-idempotent methods like PATCH. Instead of excluding POST and PATCH, this will explicitly check if the method is GET, OPTIONS, HEAD, PUT, DELETE, or TRACE. BUG= 614078 Review-Url: https://codereview.chromium.org/2001243002 Cr-Commit-Position: refs/heads/master@{#395502} (cherry picked from commit fbc93e59b496ff6ea423527d1a3579fa8a2d061c) Review URL: https://codereview.chromium.org/2013763003 . Cr-Commit-Position: refs/branch-heads/2743@{#56} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/554bbbaa0daf530ff667372bc1db72dbe90f6b38/components/data_reduction_proxy.gypi [modify] https://crrev.com/554bbbaa0daf530ff667372bc1db72dbe90f6b38/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc [modify] https://crrev.com/554bbbaa0daf530ff667372bc1db72dbe90f6b38/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.h [modify] https://crrev.com/554bbbaa0daf530ff667372bc1db72dbe90f6b38/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc [modify] https://crrev.com/554bbbaa0daf530ff667372bc1db72dbe90f6b38/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc [modify] https://crrev.com/554bbbaa0daf530ff667372bc1db72dbe90f6b38/components/data_reduction_proxy/core/common/BUILD.gn [add] https://crrev.com/554bbbaa0daf530ff667372bc1db72dbe90f6b38/components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc [add] https://crrev.com/554bbbaa0daf530ff667372bc1db72dbe90f6b38/components/data_reduction_proxy/core/common/data_reduction_proxy_util.h
Comment 1 by bugdroid1@chromium.org
, May 24 2016