Issue 614070 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	█ thanhph@chromium.org Last visit > 30 days ago
Closed:	Nov 2016
Cc:	rjkroege@chromium.org sadrul@chromium.org kylec...@chromium.org mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
Proj-Mustash-Mus-WS Proj-Mustash-Milestone-Tadpole VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Blocked on:
issue 603316

Support creation of toplevel mus::Windows on separate displays

Project Member Reported by sky@chromium.org, May 23 2016

Issue description

Widget::InitParams has a context property that is used to determine a root to create the new window. We need something similar for mus::Windows. I'm inclined to add a displayid property to WindowManger (eg WindowManager::kInitialDisplayId_Property). When the window manager creates the new window it'll use this property to determine which display to place the window on.

Comment 1 by staraz@chromium.org, Jul 26 2016

Owner: staraz@chromium.org
Status: Assigned (was: Available)

Comment 2 by sadrul@chromium.org, Jul 27 2016

Cc: sadrul@chromium.org

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dff8f03cb414500c273f158bff0635e977d206d

commit 0dff8f03cb414500c273f158bff0635e977d206d
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 11 18:39:16 2016

Fix window/display bounds with multiple windows in mus.

Previously mus assumed that all displays and root windows had origin of
(0, 0) and were the primary display. This doesn't work with multiple
displays so use the proper display origin in screen space. Also keep
track of the primary display id.

This will ensure that root ServerWindows and ScreenMus have the correct
bounds for each display. This does not handle resizing or removing
displays correctly.

BUG= 625876 , 614070 

Review-Url: https://codereview.chromium.org/2230963003
Cr-Commit-Position: refs/heads/master@{#411385}

[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen_impl.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen_impl.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen_impl_ozone.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen_impl_ozone.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/service.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/display.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/platform_display.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/platform_display.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/platform_display_init_params.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/platform_display_init_params.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/test_utils.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/test_utils.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dff8f03cb414500c273f158bff0635e977d206d

commit 0dff8f03cb414500c273f158bff0635e977d206d
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 11 18:39:16 2016

Fix window/display bounds with multiple windows in mus.

Previously mus assumed that all displays and root windows had origin of
(0, 0) and were the primary display. This doesn't work with multiple
displays so use the proper display origin in screen space. Also keep
track of the primary display id.

This will ensure that root ServerWindows and ScreenMus have the correct
bounds for each display. This does not handle resizing or removing
displays correctly.

BUG= 625876 , 614070 

Review-Url: https://codereview.chromium.org/2230963003
Cr-Commit-Position: refs/heads/master@{#411385}

[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen_impl.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen_impl.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen_impl_ozone.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/display/platform_screen_impl_ozone.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/service.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/display.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/platform_display.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/platform_display.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/platform_display_init_params.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/platform_display_init_params.h
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/test_utils.cc
[modify] https://crrev.com/0dff8f03cb414500c273f158bff0635e977d206d/services/ui/ws/test_utils.h

Comment 5 by dtapu...@chromium.org, Sep 2 2016

Components: MUS

Comment 6 by staraz@chromium.org, Sep 19 2016

Owner: thanhph@chromium.org

Comment 7 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS
Labels: Proj-Mustash

Comment 8 by thanhph@chromium.org, Oct 24 2016

Status: Fixed (was: Assigned)

Comment 9 by thanhph@chromium.org, Oct 24 2016

Status: Available (was: Fixed)

Comment 10 by rjkroege@chromium.org, Oct 24 2016

Cc: rjkroege@chromium.org kylec...@chromium.org
Components: -MUS
Labels: -mus -Proj-Mustash Proj-Mustash-Milestone-Tadpole Proj-Mustash-Mus-WS

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e73070ad937c592052cf5dac97e88b686dbc598

commit 1e73070ad937c592052cf5dac97e88b686dbc598
Author: thanhph <thanhph@chromium.org>
Date: Thu Nov 24 15:17:04 2016

Support creation of toplevel mus::Windows on separate displays

. Mus window should be shown in a correct display.
. Add unit test.

BUG= 614070 

Review-Url: https://codereview.chromium.org/2503623002
Cr-Commit-Position: refs/heads/master@{#434324}

[modify] https://crrev.com/1e73070ad937c592052cf5dac97e88b686dbc598/ash/mus/root_window_controller.cc
[modify] https://crrev.com/1e73070ad937c592052cf5dac97e88b686dbc598/ash/mus/root_window_controller_unittest.cc
[modify] https://crrev.com/1e73070ad937c592052cf5dac97e88b686dbc598/ash/mus/test/wm_test_base.cc
[modify] https://crrev.com/1e73070ad937c592052cf5dac97e88b686dbc598/ash/mus/test/wm_test_base.h

Comment 12 by thanhph@chromium.org, Nov 24 2016

Status: Fixed (was: Available)

Comment 13 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 14 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 15 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 16 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 17 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Comment 18 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

►

Issue 614070 link

Issue metadata

Support creation of toplevel mus::Windows on separate displays

Issue description

Comment 1 by staraz@chromium.org, Jul 26 2016

Comment 1 Deleted

Comment 2 by sadrul@chromium.org, Jul 27 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Aug 11 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Aug 11 2016

Comment 4 Deleted

Comment 5 by dtapu...@chromium.org, Sep 2 2016

Comment 5 Deleted

Comment 6 by staraz@chromium.org, Sep 19 2016

Comment 6 Deleted

Comment 7 by rjkroege@chromium.org, Oct 4 2016

Comment 7 Deleted

Comment 8 by thanhph@chromium.org, Oct 24 2016

Comment 8 Deleted

Comment 9 by thanhph@chromium.org, Oct 24 2016

Comment 9 Deleted

Comment 10 by rjkroege@chromium.org, Oct 24 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Nov 24 2016

Comment 11 Deleted

Comment 12 by thanhph@chromium.org, Nov 24 2016

Comment 12 Deleted

Comment 13 by dchan@google.com, Mar 4 2017

Comment 13 Deleted

Comment 14 by dchan@google.com, Apr 17 2017

Comment 14 Deleted

Comment 15 by dchan@google.com, May 30 2017

Comment 15 Deleted

Comment 16 by dchan@chromium.org, Aug 1 2017

Comment 16 Deleted

Comment 17 by dchan@chromium.org, Oct 14 2017

Comment 17 Deleted

Comment 18 by lafo...@chromium.org, Feb 26 2018

Comment 18 Deleted

Sign in to add a comment