Bookmark edit dialog is not idempotent for urls with credentials
Reported by
hadrien....@gmail.com,
May 23 2016
|
||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36 Steps to reproduce the problem: 1. Create a bookmark to "http://user:password@example.com/" 2. The bookmark works and points to example.com 3. Edit the bookmark, do not change anything in the edit dialog and press "save" 4. The bookmark is broken: it uses a non-http scheme What is the expected behavior? The bookmark should not be changed at all. What went wrong? The scheme is trimmed from the URL for display, when the dialog is saved again, the user credential is interpreted as the URL scheme. The problem is that "It is [not] safe to omit the scheme" because if the url contains a ":" and the part before the : is a legal scheme, then this part is considered as the URL scheme. ( https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/bookmarks/bookmark_utils.cc&l=128 ) Did this work before? N/A Chrome version: 50.0.2661.102 Channel: stable OS Version: Flash Version: Shockwave Flash 21.0 r0 IMHO the scheme should always be shown in the URL field of the edit bookmark dialog. Otherwise can someone tell my why it is hidden? I've never contributed to chromium but use it every day. Since this bug is minor and seems relatively easy to fix, I'd like to give it a try if you can provide a little bit of guidance.
,
Aug 21
Archiving old bugs that haven't been actively assigned in over a year. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Aug 21
Archiving old bugs that haven't been actively assigned in over a year. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Aug 21
Archiving old bugs that haven't been actively assigned in over a year. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by pkasting@chromium.org
, Aug 20 2016Labels: -OS-Linux OS-All
Status: Untriaged (was: Unconfirmed)