We need a drag and drop API for mus.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d6c8b29f6ccf357dfc9186f2ed9a4a22ec1b6cf commit 7d6c8b29f6ccf357dfc9186f2ed9a4a22ec1b6cf Author: erg <erg@chromium.org> Date: Sat Jul 23 00:04:33 2016 mus: The window server needs to be able to write to the clipboard. This lifetime management for ClipboardImpl from service.cc to the window server. BUG= 614037 Review-Url: https://codereview.chromium.org/2180593002 Cr-Commit-Position: refs/heads/master@{#407308} [modify] https://crrev.com/7d6c8b29f6ccf357dfc9186f2ed9a4a22ec1b6cf/services/ui/service.cc [modify] https://crrev.com/7d6c8b29f6ccf357dfc9186f2ed9a4a22ec1b6cf/services/ui/ws/BUILD.gn [modify] https://crrev.com/7d6c8b29f6ccf357dfc9186f2ed9a4a22ec1b6cf/services/ui/ws/window_server.cc [modify] https://crrev.com/7d6c8b29f6ccf357dfc9186f2ed9a4a22ec1b6cf/services/ui/ws/window_server.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d324214f9878ede9d754b7e4336864eae2dfafd commit 5d324214f9878ede9d754b7e4336864eae2dfafd Author: erg <erg@chromium.org> Date: Tue Jul 26 19:31:06 2016 Allow OSExchangeData::Provider to be overridden at run time. As previously written, OSExchangeData::CreateProvider() was written once on each platform. Change it to have an overrideable factory so that mus can use a mus specific provider. BUG= 614037 Review-Url: https://codereview.chromium.org/2179813003 Cr-Commit-Position: refs/heads/master@{#407879} [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/components/bookmarks/browser/bookmark_node_data_unittest.cc [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/BUILD.gn [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data.cc [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data.h [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_aura.cc [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_aura.h [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_aurax11.h [add] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_builder_mac.h [add] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_builder_mac.mm [add] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_factory.cc [add] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_factory.h [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_mac.h [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_mac.mm [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_win.cc [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_provider_win.h [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/dragdrop/os_exchange_data_unittest.cc [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/base/ui_base.gyp [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/views/cocoa/drag_drop_client_mac.mm [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc [modify] https://crrev.com/5d324214f9878ede9d754b7e4336864eae2dfafd/ui/views/widget/desktop_aura/desktop_drop_target_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3624c6c095108839db78c01dce92c731cf10b954 commit 3624c6c095108839db78c01dce92c731cf10b954 Author: mostynb <mostynb@opera.com> Date: Wed Jul 27 20:49:47 2016 (gcc) fix compilation of os_exchange_data_provider_aurax11.cc This fixes a gcc compilation error in os_exchange_data_provider_aurax11.cc: error: cannot convert 'ret' from type 'std::unique_ptr<ui::OSExchangeDataProviderAuraX11>' to type 'std::unique_ptr<ui::OSExchangeDataProviderAuraX11>&&' Tested with gcc 4.8.4. Followup to https://codereview.chromium.org/2179813003 BUG= 614037 Review-Url: https://codereview.chromium.org/2192533002 Cr-Commit-Position: refs/heads/master@{#408233} [modify] https://crrev.com/3624c6c095108839db78c01dce92c731cf10b954/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7466e8d81c770b6fdab97ba06a6918bf787f9e3a commit 7466e8d81c770b6fdab97ba06a6918bf787f9e3a Author: erg <erg@chromium.org> Date: Fri Aug 05 23:06:02 2016 mus/views: Create a mus OSExchangeData::Provider stub, and use it. This prevents a crash in the current views code when running under mus. The OS native OSExchangeData::Provider is used, and on X11, this crashes because the views using application does not have an X11 connection. BUG= 614037 Review-Url: https://codereview.chromium.org/2211253002 Cr-Commit-Position: refs/heads/master@{#410205} [modify] https://crrev.com/7466e8d81c770b6fdab97ba06a6918bf787f9e3a/ui/base/dragdrop/os_exchange_data_provider_factory.cc [modify] https://crrev.com/7466e8d81c770b6fdab97ba06a6918bf787f9e3a/ui/views/mus/BUILD.gn [add] https://crrev.com/7466e8d81c770b6fdab97ba06a6918bf787f9e3a/ui/views/mus/os_exchange_data_provider_mus.cc [add] https://crrev.com/7466e8d81c770b6fdab97ba06a6918bf787f9e3a/ui/views/mus/os_exchange_data_provider_mus.h [modify] https://crrev.com/7466e8d81c770b6fdab97ba06a6918bf787f9e3a/ui/views/mus/window_manager_connection.cc [modify] https://crrev.com/7466e8d81c770b6fdab97ba06a6918bf787f9e3a/ui/views/mus/window_manager_connection.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e428cfc81bc9288d67b5918fd4eab925c8e8665d commit e428cfc81bc9288d67b5918fd4eab925c8e8665d Author: erg <erg@chromium.org> Date: Tue Aug 16 19:18:56 2016 mus: Implement OSExchangeDataProviderMus. Fill in the skeleton so the current views code will create the map representation that we use to move data across the IPC boundary to the clipboard. BUG= 614037 Review-Url: https://codereview.chromium.org/2240323003 Cr-Commit-Position: refs/heads/master@{#412302} [modify] https://crrev.com/e428cfc81bc9288d67b5918fd4eab925c8e8665d/ui/views/mus/BUILD.gn [modify] https://crrev.com/e428cfc81bc9288d67b5918fd4eab925c8e8665d/ui/views/mus/DEPS [modify] https://crrev.com/e428cfc81bc9288d67b5918fd4eab925c8e8665d/ui/views/mus/os_exchange_data_provider_mus.cc [modify] https://crrev.com/e428cfc81bc9288d67b5918fd4eab925c8e8665d/ui/views/mus/os_exchange_data_provider_mus.h [add] https://crrev.com/e428cfc81bc9288d67b5918fd4eab925c8e8665d/ui/views/mus/os_exchange_data_provider_mus_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0873818c95cc607d8afe5a16b345fafe4109a735 commit 0873818c95cc607d8afe5a16b345fafe4109a735 Author: erg <erg@chromium.org> Date: Thu Sep 15 22:08:39 2016 mash: Implements basic drag and drop IPC. This implements a new mus IPC protocol to allow inter-process drag and drop in mus. It handles the entire lifecycle of a drag between two mus Windows, possibly in different processes. This patch does not implement changing the mouse cursor or showing a drag representation, which is queued work. This patch is mus side only; it does not implement the views sided of this protocol, which is next. (With it, you can drag text from the chrome omnibox to the quick launcher and vice versa. You can drag text from the quick launcher to the content area. Etc.) BUG= 614037 Review-Url: https://codereview.chromium.org/2266603002 Cr-Commit-Position: refs/heads/master@{#419005} [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/in_flight_change.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/in_flight_change.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/tests/test_window_tree.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/tests/test_window_tree.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/window.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/window.h [add] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/window_drop_target.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/window_tree_client.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/cpp/window_tree_client.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/public/interfaces/window_tree_constants.mojom [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/BUILD.gn [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/access_policy.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/default_access_policy.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/default_access_policy.h [add] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/drag_controller.cc [add] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/drag_controller.h [add] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/drag_controller_unittest.cc [add] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/drag_source.h [add] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/drag_target_connection.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/event_dispatcher.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/event_dispatcher.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/server_window.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/server_window.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/test_utils.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/test_utils.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_manager_access_policy.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_manager_access_policy.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_manager_state.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_server.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_server.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_tree.cc [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_tree.h [modify] https://crrev.com/0873818c95cc607d8afe5a16b345fafe4109a735/services/ui/ws/window_tree_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2 commit 98ef46cc289b9cb95cccfb7db520e73ac66b0dc2 Author: erg <erg@chromium.org> Date: Fri Sep 16 19:58:50 2016 mus: Remove window server access to clipboard and the drag clipboard. This reverts 7d6c8b29f6, which made window server have access to the clipboard, as at the time, I thought that drag and drop would read/write to/from a dedicated drag clipboard and that the window server would have to manipulate it. Due to timing issues, this didn't work out. Now that we aren't using a drag clipboard as the backing for mus drag and drop, also remove the drag clipboard from our mus clipboard implementation. BUG= 614037 Review-Url: https://codereview.chromium.org/2339353003 Cr-Commit-Position: refs/heads/master@{#419260} [modify] https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2/services/ui/clipboard/clipboard_impl.h [modify] https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2/services/ui/public/interfaces/clipboard.mojom [modify] https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2/services/ui/service.cc [modify] https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2/services/ui/ws/BUILD.gn [modify] https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2/services/ui/ws/window_server.cc [modify] https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2/services/ui/ws/window_server.h [modify] https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2/ui/views/mus/clipboard_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ef4d91b5c0d124c73244b323d2d2913daae17f3 commit 5ef4d91b5c0d124c73244b323d2d2913daae17f3 Author: erg <erg@chromium.org> Date: Wed Sep 21 00:49:02 2016 mus drag and drop: return the completed effect to the caller. While implementing the views drag implementation, I had thought that you didn't need to return this value, as nothing in views uses it. However, it does get used in WebContents, so add it in. BUG= 614037 Review-Url: https://codereview.chromium.org/2349973010 Cr-Commit-Position: refs/heads/master@{#419924} [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/public/cpp/window.cc [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/public/cpp/window.h [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/public/cpp/window_tree_client.cc [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/public/cpp/window_tree_client.h [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/drag_controller.cc [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/drag_controller.h [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/drag_controller_unittest.cc [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/drag_source.h [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/test_utils.cc [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/test_utils.h [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/window_tree.cc [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/window_tree.h [modify] https://crrev.com/5ef4d91b5c0d124c73244b323d2d2913daae17f3/services/ui/ws/window_tree_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f58400c1412b3528aff9716d632e9673a57d212f commit f58400c1412b3528aff9716d632e9673a57d212f Author: erg <erg@chromium.org> Date: Wed Sep 21 23:55:54 2016 mus drag and drop: Add API to let the client cancel the drag. BUG= 614037 Review-Url: https://codereview.chromium.org/2352233002 Cr-Commit-Position: refs/heads/master@{#420205} [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/public/cpp/tests/test_window_tree.cc [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/public/cpp/tests/test_window_tree.h [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/public/cpp/window.cc [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/public/cpp/window.h [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/public/cpp/window_tree_client.cc [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/public/cpp/window_tree_client.h [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/ws/event_dispatcher.cc [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/ws/event_dispatcher.h [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/ws/window_manager_state.h [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/ws/window_tree.cc [modify] https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f/services/ui/ws/window_tree.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de431fe87ced556b5fa4411da711ee33453de9a2 commit de431fe87ced556b5fa4411da711ee33453de9a2 Author: erg <erg@chromium.org> Date: Tue Sep 27 17:39:19 2016 mash: Use the new mus drag and drop API to get drag working in mash. BUG= 614037 Review-Url: https://codereview.chromium.org/2323553002 Cr-Commit-Position: refs/heads/master@{#421254} [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/public/cpp/tests/test_window_tree.cc [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/public/cpp/tests/test_window_tree.h [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/public/cpp/window.cc [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/public/cpp/window.h [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/public/cpp/window_tree_client.cc [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/public/cpp/window_tree_client.h [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/ws/window_manager_state.h [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/ws/window_tree.cc [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/services/ui/ws/window_tree.h [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/controls/menu/menu_controller_unittest.cc [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/BUILD.gn [add] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/drag_drop_client_mus.cc [add] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/drag_drop_client_mus.h [add] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/drop_target_mus.cc [add] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/drop_target_mus.h [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/native_widget_mus.h [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/os_exchange_data_provider_mus.cc [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/mus/os_exchange_data_provider_mus.h [modify] https://crrev.com/de431fe87ced556b5fa4411da711ee33453de9a2/ui/views/widget/drop_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e38cbe24d4543a1484c6d3d25626c810de5343c commit 3e38cbe24d4543a1484c6d3d25626c810de5343c Author: erg <erg@chromium.org> Date: Wed Sep 28 20:14:37 2016 mus: Keep track of the drag cursor during DnD operations. BUG= 614037 Review-Url: https://codereview.chromium.org/2376583003 Cr-Commit-Position: refs/heads/master@{#421621} [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/BUILD.gn [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/drag_controller.cc [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/drag_controller.h [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/drag_controller_unittest.cc [add] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/drag_cursor_updater.h [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/event_dispatcher.cc [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/event_dispatcher.h [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/event_dispatcher_delegate.h [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/event_dispatcher_unittest.cc [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/3e38cbe24d4543a1484c6d3d25626c810de5343c/services/ui/ws/window_manager_state.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fb80909a5e274f92122ba067bdf10cc4483417b commit 2fb80909a5e274f92122ba067bdf10cc4483417b Author: erg <erg@chromium.org> Date: Thu Sep 29 17:13:53 2016 mus ws: Consistently use mojom::Cursor instead of int32_t. Instead of casting back and forth between the two types at different layers of the window server, consistently use mojom::Cursor and only cast to int32_t at the final usage in DefaultPlatformDisplay. BUG= 614037 Review-Url: https://codereview.chromium.org/2378883002 Cr-Commit-Position: refs/heads/master@{#421856} [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/cursor_unittest.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/display.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/display.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/drag_controller.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/drag_controller.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/event_dispatcher.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/event_dispatcher.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/platform_display.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/platform_display.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/server_window.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/server_window.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/server_window_observer.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/test_utils.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/test_utils.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/window_server.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/window_server.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/window_tree.cc [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/window_tree.h [modify] https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b/services/ui/ws/window_tree_unittest.cc
Calling this complete and filled 654862 for the drag representation follow up.
Comment 1 by sky@chromium.org
, May 23 2016