Issue 614036 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	bashi@chromium.org
Closed:	May 2016
Cc:	ajha@chromium.org lfg@chromium.org
Components:	Blink>Bindings
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Mac
Pri:	1
Type:	Bug-Regression
hasbisect Via-Wizard M-53

CustomEvent.length incorrect

Reported by andyearn...@gmail.com, May 23 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2739.2 Safari/537.36

Steps to reproduce the problem:
1.  Open dev tools on any page, e.g. about:blank
2. Enter `CustomEvent.length`, observe the result is 0
3. Enter `new CustomEvent()`, observe the error message stating at least one argument is required

What is the expected behavior?
According to the HTML spec, `CustomEvent` has one required argument.   Therefore, `CustomEvent.length` should equal 1.

What went wrong?
The value of `CustomEvent.length` is 0 instead of 1.

Did this work before? Yes Not sure

Chrome version: 52.0.2739.2  Channel: dev
OS Version: OS X 10.11.4
Flash Version: Shockwave Flash 22.0 r0

I'm almost certain this used to work because I remember writing a polyfill for the constructor that tested `CustomEvent.length === 0` before applying the polyfill.

Comment 1 by ajha@chromium.org, May 24 2016

Cc: ajha@chromium.org
Components: Blink>Bindings
Labels: -Pri-2 M-53 hasbisect OS-Linux OS-Windows Pri-1
Owner: bashi@chromium.org
Status: Assigned (was: Unconfirmed)

Able to reproduce this on the latest stable(50.0.2661.102) and the latest canary(53.0.2747.0) on Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04.

Regressed in M-48.

Last good build: 48.0.2528.0
First bad build: 48.0.2529.0

Changelog:
https://chromium.googlesource.com/chromium/src/+log/e16190f09b79412a593f3dd4e37f775c2850b7b3..dee77f7135016f5884e95908297627c7170f8803

Suspected change: https://codereview.chromium.org/1383543004

bashi@: Could you please take a look at this.

Thank you!

Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01fcbfb8573898b017ef81c7d37dc871f8d19309

commit 01fcbfb8573898b017ef81c7d37dc871f8d19309
Author: bashi <bashi@chromium.org>
Date: Thu May 26 07:41:26 2016

Use correct signature for custom constructor of CustomEvent

This will make CustomEvent.length return the correct value (which is
"1").

BUG= 614036 

Review-Url: https://codereview.chromium.org/2015673003
Cr-Commit-Position: refs/heads/master@{#396143}

[modify] https://crrev.com/01fcbfb8573898b017ef81c7d37dc871f8d19309/third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt
[modify] https://crrev.com/01fcbfb8573898b017ef81c7d37dc871f8d19309/third_party/WebKit/LayoutTests/fast/js/constructor-length.html
[modify] https://crrev.com/01fcbfb8573898b017ef81c7d37dc871f8d19309/third_party/WebKit/LayoutTests/imported/wpt/dom/interfaces-expected.txt
[modify] https://crrev.com/01fcbfb8573898b017ef81c7d37dc871f8d19309/third_party/WebKit/Source/core/events/CustomEvent.idl

Comment 3 by bashi@chromium.org, May 26 2016

Status: Fixed (was: Assigned)

Thanks for the report! Fix has landed.

Comment 4 by andyearn...@gmail.com, May 26 2016

Thanks for the super-fast turnaround :-)

►

Issue 614036 link

Issue metadata

CustomEvent.length incorrect

Issue description

Comment 1 by ajha@chromium.org, May 24 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, May 26 2016

Comment 2 Deleted

Comment 3 by bashi@chromium.org, May 26 2016

Comment 3 Deleted

Comment 4 by andyearn...@gmail.com, May 26 2016

Comment 4 Deleted

Sign in to add a comment