New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614015 link

Starred by 1 user
Status: Fixed
Owner:
█ msten...@opera.com
NOT IN USE
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make recompilation of LayoutObject.h dependencies at least 38% faster

Reported by msten...@opera.com, May 23 2016 
Changing a central header file in core/layout/ (such as LayoutObject.h or LayoutBlockFlow.h) and rebuilding just gets slower and slower as the months go by.

Eliminating unnecessary includes and making some light changes suggests that we can improve the speed by at least 38%.

Comment 1 by japhet@chromium.org, May 23 2016

Labels: Hotlist-CodeHealth
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4a7d5bc488ebc1b37ca3836ba697776c520115a

commit b4a7d5bc488ebc1b37ca3836ba697776c520115a
Author: mstensho <mstensho@opera.com>
Date: Tue May 24 00:04:20 2016

Eliminate unnecessary includes of LayoutBlockFlow-derived headers.

BUG= 614015 

Review-Url: https://codereview.chromium.org/2008503003
Cr-Commit-Position: refs/heads/master@{#395472}

[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/animation/DocumentAnimations.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/forms/NumberInputType.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/shadow/ClearButtonElement.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutBR.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutIFrame.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutListBox.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/line/LineInfo.h
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/core/paint/ThemePainter.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
[modify] https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a/third_party/WebKit/Source/web/WebAXObject.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9289b46d142c34fb1507906048189503e2e6a306

commit 9289b46d142c34fb1507906048189503e2e6a306
Author: mstensho <mstensho@opera.com>
Date: Tue May 24 09:53:00 2016

Declare methods defined in LayoutObjectInlines.h as inline.

This way we'll detect a failure to include LayoutObjectInlines.h during
compilation, rather than during linking.

Test case: Remove inclusion of LayoutObjectInlines.h from LayoutBR.cpp.

See https://codereview.chromium.org/2008503003/ - I initially tried
to simply remove LayoutView.h from LayoutBR.cpp's include list, but
got "strange" linker errors in release builds, since the compiler
thought styleRef(bool) was an actual function, and not an inline.

BUG= 614015 

Review-Url: https://codereview.chromium.org/2007723002
Cr-Commit-Position: refs/heads/master@{#395558}

[modify] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/WebKit/Source/core/layout/LayoutObject.h
Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae057e0a986c713b8d3b619d1e0f4be61a3f963c

commit ae057e0a986c713b8d3b619d1e0f4be61a3f963c
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 01:49:58 2016

Move TextAutosizer::Cluster::Cluster() implementation to .cpp.

This way we won't have to include LayoutObject.h in the header.

Also need an explicit ~TextAutoSizer() in the .cpp file now, because
ComputedStyle is only forward-declared in the header file, and TextAutoSizer
has a ComputedStyle RefPtr Vector. The need for this was presumably introduced
by https://codereview.chromium.org/1999343002

BUG= 614015 

Review-Url: https://codereview.chromium.org/2004313005
Cr-Commit-Position: refs/heads/master@{#395773}

[modify] https://crrev.com/ae057e0a986c713b8d3b619d1e0f4be61a3f963c/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp
[modify] https://crrev.com/ae057e0a986c713b8d3b619d1e0f4be61a3f963c/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/ae057e0a986c713b8d3b619d1e0f4be61a3f963c/third_party/WebKit/Source/core/layout/TextAutosizer.h
Project Member

Comment 10 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7109fc10614eb1ad4debae27bcc723ea01862ea

commit f7109fc10614eb1ad4debae27bcc723ea01862ea
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 09:49:04 2016

WebGLRenderingContext.cpp doesn't need to include LayoutBox.h

BUG= 614015 
TBR=bajones@chromium.org,eae@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2010623002
Cr-Commit-Position: refs/heads/master@{#395846}

[modify] https://crrev.com/f7109fc10614eb1ad4debae27bcc723ea01862ea/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f976e4dfa86fb3b71d79678d04077e4b7bb24d7

commit 7f976e4dfa86fb3b71d79678d04077e4b7bb24d7
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 10:11:01 2016

StyleGeneratedImage.cpp doesn't need to include LayoutObject.h

BUG= 614015 
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2005353002
Cr-Commit-Position: refs/heads/master@{#395851}

[modify] https://crrev.com/7f976e4dfa86fb3b71d79678d04077e4b7bb24d7/third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp
Project Member

Comment 12 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6a9e059a4e715dd54cd0c0d886923a3dfdc26c

commit 5b6a9e059a4e715dd54cd0c0d886923a3dfdc26c
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 10:13:34 2016

HitRegion.cpp doesn't need to include LayoutBoxModelObject.h

BUG= 614015 
TBR=junov@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2010633002
Cr-Commit-Position: refs/heads/master@{#395852}

[modify] https://crrev.com/5b6a9e059a4e715dd54cd0c0d886923a3dfdc26c/third_party/WebKit/Source/modules/canvas2d/HitRegion.cpp
Project Member

Comment 13 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0348939c372f1b2363c18cb9ac1a7396159403f

commit f0348939c372f1b2363c18cb9ac1a7396159403f
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 10:17:36 2016

SVGTextContentElement.cpp doesn't need to include LayoutObject.h

BUG= 614015 
TBR=fs@opera.com,eae@chromium.org

Review-Url: https://codereview.chromium.org/2011603002
Cr-Commit-Position: refs/heads/master@{#395854}

[modify] https://crrev.com/f0348939c372f1b2363c18cb9ac1a7396159403f/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp
Project Member

Comment 14 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc57b581dc8fd4efef4a7ca42e0d28f924e0e629

commit dc57b581dc8fd4efef4a7ca42e0d28f924e0e629
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 10:18:09 2016

Remove unnecessary inclusions of LayoutObject-derived headers in core/editing/

BUG= 614015 
TBR=yosin@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2009013002
Cr-Commit-Position: refs/heads/master@{#395855}

[modify] https://crrev.com/dc57b581dc8fd4efef4a7ca42e0d28f924e0e629/third_party/WebKit/Source/core/editing/PositionIterator.h
[modify] https://crrev.com/dc57b581dc8fd4efef4a7ca42e0d28f924e0e629/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
[modify] https://crrev.com/dc57b581dc8fd4efef4a7ca42e0d28f924e0e629/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/dc57b581dc8fd4efef4a7ca42e0d28f924e0e629/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/dc57b581dc8fd4efef4a7ca42e0d28f924e0e629/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/dc57b581dc8fd4efef4a7ca42e0d28f924e0e629/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp
[modify] https://crrev.com/dc57b581dc8fd4efef4a7ca42e0d28f924e0e629/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h
Project Member

Comment 15 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20a08ea07fa32b72ddbf9429ad3e4d4721ec3723

commit 20a08ea07fa32b72ddbf9429ad3e4d4721ec3723
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 10:34:33 2016

SnapCoordinator.h doesn't need to include LayoutBox.h

BUG= 614015 
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2010513004
Cr-Commit-Position: refs/heads/master@{#395859}

[modify] https://crrev.com/20a08ea07fa32b72ddbf9429ad3e4d4721ec3723/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.h
Project Member

Comment 22 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0cdc556bcec6fcbff08636d7927b7836a9f4bad

commit e0cdc556bcec6fcbff08636d7927b7836a9f4bad
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 14:29:50 2016

Remove unnecessary includes from ComputedStyle.h and from its includes.

BUG= 614015 
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2008263002
Cr-Commit-Position: refs/heads/master@{#395889}

[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/style/StyleInheritedData.h
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/style/StyleMultiColData.h
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/style/StyleRareInheritedData.h
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp
[modify] https://crrev.com/e0cdc556bcec6fcbff08636d7927b7836a9f4bad/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h
Project Member

Comment 24 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e89e5ab31c45584ce17265f883a8912488268720

commit e89e5ab31c45584ce17265f883a8912488268720
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 18:14:26 2016

Move ContentChangeType enum to a separate file, so that WebGLRenderingContextBase.h doesn't need LayoutBoxModelObject.h

BUG= 614015 
TBR=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2013603003
Cr-Commit-Position: refs/heads/master@{#395934}

[add] https://crrev.com/e89e5ab31c45584ce17265f883a8912488268720/third_party/WebKit/Source/core/layout/ContentChangeType.h
[modify] https://crrev.com/e89e5ab31c45584ce17265f883a8912488268720/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/e89e5ab31c45584ce17265f883a8912488268720/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
Project Member

Comment 25 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2373d35f875ed1b64e9d6cbeff0160e5d823ce96

commit 2373d35f875ed1b64e9d6cbeff0160e5d823ce96
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 18:37:39 2016

Move CSSPropertyID templates instantiations to a separate file.

core/CSSPropertyNames.h is needed a lot of places, but the template part there
was only required at a few places.

BUG= 614015 

Review-Url: https://codereview.chromium.org/2007073003
Cr-Commit-Position: refs/heads/master@{#395941}

[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/build/scripts/make_css_property_names.py
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/build/scripts/templates/CSSOMKeywords.cpp.tmpl
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/animation/AnimationInputHelpers.h
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[add] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/css/CSSPropertyIDTemplates.h
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/css/CSSPropertyMetadata.h
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/css/cssom/CSSOMKeywords.h
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/css/cssom/CSSOMTypes.h
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h
[modify] https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96/third_party/WebKit/Source/core/frame/UseCounter.h
Project Member

Comment 26 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39cbd9dfb8617a77c8a9f3b77183925d0680f573

commit 39cbd9dfb8617a77c8a9f3b77183925d0680f573
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 18:44:39 2016

ComputedStyle.h doesn't need CSSPrimitiveValue.h if adjustForAbsoluteZoom(int, float) isn't inline.

BUG= 614015 

Review-Url: https://codereview.chromium.org/2013833002
Cr-Commit-Position: refs/heads/master@{#395943}

[modify] https://crrev.com/39cbd9dfb8617a77c8a9f3b77183925d0680f573/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/39cbd9dfb8617a77c8a9f3b77183925d0680f573/third_party/WebKit/Source/core/style/ComputedStyle.h
Project Member

Comment 27 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/997542543ad16f6bb06b2464116b4f01097d747b

commit 997542543ad16f6bb06b2464116b4f01097d747b
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 20:49:53 2016

Remove unnecessary inclusions of LayoutObject-derived headers in core/html/

BUG= 614015 
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2008843004
Cr-Commit-Position: refs/heads/master@{#395984}

[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
[modify] https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
Project Member

Comment 28 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fe107c7078bc01376197e82a592b6a0a959749e

commit 7fe107c7078bc01376197e82a592b6a0a959749e
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 21:34:34 2016

Remove assorted unnecessary includes in core/layout/

I was mainly looking at inclusions of LayoutObject-derived header files, but
removed some others as well, while I was at it.

BUG= 614015 
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2015583003
Cr-Commit-Position: refs/heads/master@{#395993}

[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/BidiRun.h
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/ClipRectsCache.h
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/FloatingObjects.h
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/ImageQualityController.h
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutFileUploadControl.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutIFrame.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutListBox.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutPart.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutTextCombine.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutTheme.h
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
[modify] https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
Project Member

Comment 30 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c66aa2dac45fbecf3590d661cf4133781951d871

commit c66aa2dac45fbecf3590d661cf4133781951d871
Author: mstensho <mstensho@opera.com>
Date: Wed May 25 23:28:36 2016

Remove assorted unnecessary includes in core/paint/

I was mainly looking at inclusions of LayoutObject-derived header files, but
removed some others as well, while I was at it.

BUG= 614015 
TBR=chrishtr@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2010823002
Cr-Commit-Position: refs/heads/master@{#396037}

[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/BlockPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/BoxPainter.h
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/InlinePainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.h
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/PartPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/SVGImagePainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/SVGInlineFlowBoxPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/ScopeRecorder.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/TableRowPainter.cpp
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/TableRowPainter.h
[modify] https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
Project Member

Comment 31 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a93be63844def02b8833f0e96ad5551dd1cdc415

commit a93be63844def02b8833f0e96ad5551dd1cdc415
Author: mstensho <mstensho@opera.com>
Date: Thu May 26 08:26:18 2016

Remove unnecessary includes from Document.h

BUG= 614015 
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2007343002
Cr-Commit-Position: refs/heads/master@{#396148}

[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/dom/ViewportDescription.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/editing/EditingCommandTest.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/frame/FrameHost.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/frame/HostsUsingFeatures.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/frame/TopControls.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/html/HTMLBodyElement.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/loader/FrameLoaderClient.h
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/page/PagePopupClient.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/modules/speech/testing/InternalsSpeechSynthesis.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/DevToolsEmulator.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/PageOverlay.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/WebFormControlElement.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/tests/TopControlsTest.cpp
[modify] https://crrev.com/a93be63844def02b8833f0e96ad5551dd1cdc415/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Comment 32 Deleted

Project Member

Comment 33 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4abc9f3ea334e130f69543c86a801d625163bbc5

commit 4abc9f3ea334e130f69543c86a801d625163bbc5
Author: mstensho <mstensho@opera.com>
Date: Thu May 26 11:44:06 2016

Remove unnecessary inclusions of LayoutObject-derived headers in web/

BUG= 614015 
TBR=aelias@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2016673002
Cr-Commit-Position: refs/heads/master@{#396162}

[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/FullscreenController.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/FullscreenController.h
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/PageOverlayTest.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/WebHitTestResult.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/WebLeakDetector.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/4abc9f3ea334e130f69543c86a801d625163bbc5/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

Comment 34 by msten...@opera.com, May 27 2016

Status: Fixed (was: Assigned)
Changing and recompiling LayoutObject.h should now be ~38% faster. Closing.

I tried to make some further and crazy changes, such as not including ComputedStyle.h and Document.h from LayoutObject.h, but it only seemed to make it about 3% faster. So probably not worth it, given all the mess it required.
►

Sign in to add a comment