Linux builder failing (isolated tests). https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29?numbuilds=100 https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/101069 Tests failed because of missing chrome_material_100_percent.pak.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727 commit 09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727 Author: kolos <kolos@chromium.org> Date: Mon May 23 12:54:47 2016 Revert of Remove enable_topchrome_md build flag (patchset #5 id:80001 of https://codereview.chromium.org/1991573002/ ) Reason for revert: Linux builder failing (isolated tests). https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29?numbuilds=100 https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/101069 Tests failed because of missing chrome_material_100_percent.pak. Original issue's description: > Remove enable_topchrome_md build flag > > Actually use of MD is still controlled by a runtime flag. > > Also get rid of Material Design resource build step (on !osx). These drop-in png replacements are no longer used (they've all been converted to vectorized images). > > BUG=none > > Committed: https://crrev.com/2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5 > Cr-Commit-Position: refs/heads/master@{#395146} TBR=thestig@chromium.org,varkha@chromium.org,scottmg@chromium.org,sky@chromium.org,blundell@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 613980 Review-Url: https://codereview.chromium.org/2001093002 Cr-Commit-Position: refs/heads/master@{#395308} [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/build/common.gypi [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/build/config/BUILD.gn [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/build/config/ui.gni [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/BUILD.gn [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/app/theme/BUILD.gn [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/browser_tests.isolate [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/chrome_dll_bundle.gypi [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/chrome_repack_chrome_material_100_percent.gypi [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/chrome_repack_chrome_material_200_percent.gypi [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/chrome_resources.gyp [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/installer/linux/common/installer.include [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/installer/mini_installer/chrome.release [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/interactive_ui_tests.isolate [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/test/BUILD.gn [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/tools/build/chromeos/FILES.cfg [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/tools/build/linux/FILES.cfg [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/chrome/tools/build/win/FILES.cfg [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/BUILD.gn [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/components_scaled_resources.grd [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_100_percent/omnibox/controlled_setting_mandatory.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_100_percent/omnibox/location_bar_http.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_100_percent/omnibox/omnibox_extension_app.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_100_percent/omnibox/omnibox_http.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_100_percent/omnibox/omnibox_search.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_200_percent/omnibox/controlled_setting_mandatory.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_200_percent/omnibox/location_bar_http.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_200_percent/omnibox/omnibox_extension_app.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_200_percent/omnibox/omnibox_http.png [add] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/components/resources/material_200_percent/omnibox/omnibox_search.png [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/tools/grit/grit_rule.gni [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/ui/base/material_design/material_design_controller.cc [modify] https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727/ui/base/material_design/material_design_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/476ef356a5b0d6fb075844a4099d1f38c811301f commit 476ef356a5b0d6fb075844a4099d1f38c811301f Author: estade <estade@chromium.org> Date: Mon May 23 19:53:53 2016 Retry of 2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5 Remove enable_topchrome_md build flag Actually use of MD is still controlled by a runtime flag. Also get rid of Material Design resource build step (on !osx). These drop-in png replacements are no longer used (they've all been converted to vectorized images). BUG= 613980 TBR=sky@chromium.org,scottmg@chromium.org,blundell@chromium.org Review-Url: https://codereview.chromium.org/2004143002 Cr-Commit-Position: refs/heads/master@{#395392} [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/build/common.gypi [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/build/config/BUILD.gn [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/build/config/ui.gni [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/BUILD.gn [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/app/theme/BUILD.gn [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/browser_tests.isolate [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/chrome_dll_bundle.gypi [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/chrome_repack_chrome_material_100_percent.gypi [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/chrome_repack_chrome_material_200_percent.gypi [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/chrome_resources.gyp [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/installer/linux/common/installer.include [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/installer/mini_installer/chrome.release [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/interactive_ui_tests.isolate [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/test/BUILD.gn [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/tools/build/chromeos/FILES.cfg [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/tools/build/linux/FILES.cfg [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/chrome/tools/build/win/FILES.cfg [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/components/resources/BUILD.gn [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/components/resources/components_scaled_resources.grd [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_100_percent/omnibox/controlled_setting_mandatory.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_100_percent/omnibox/location_bar_http.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_100_percent/omnibox/omnibox_extension_app.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_100_percent/omnibox/omnibox_http.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_100_percent/omnibox/omnibox_search.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_200_percent/omnibox/controlled_setting_mandatory.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_200_percent/omnibox/location_bar_http.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_200_percent/omnibox/omnibox_extension_app.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_200_percent/omnibox/omnibox_http.png [delete] https://crrev.com/b70d41a7095bcf5252c78043a21aa643a8475d64/components/resources/material_200_percent/omnibox/omnibox_search.png [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/tools/grit/grit_rule.gni [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/ui/base/material_design/material_design_controller.cc [modify] https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f/ui/base/material_design/material_design_controller_unittest.cc
Comment 1 by bugdroid1@chromium.org
, May 23 2016