chrome://tracing: The dialog has too long width |
||||||||||
Issue descriptionVersion: ToT OS: Ubuntu Linux x86-64 What steps will reproduce the problem? (1) Open chrome://tracing (2) Click "Record" button (3) Select "Manually select settings" and check all items on the left side (4) Close the dialog without recording (5) Re-click "Record" button What is the expected output? What do you see instead? The shown dialog has too long width Please use labels and text to provide additional information.
,
May 23 2016
hajimeoshi@: What exactly do you mean by "too long width"? Could you please attach a screenshot? I tried following the reproduction steps and, although the dialog is a little wider (to cater for the manual config checkboxes), it seems fine to me (see the attached screenshot).
,
May 24 2016
,
May 24 2016
hajimehoshi@: Thanks! I'll look into it.
,
May 24 2016
I know it sounds silly, but have you tried opening chrome://Tracing and clearning cookies/local storage? If you at some point did some experiment and by mistaked pushed some very long string in the category name, that is persisted in your cookies (or storage can't remember). Maybe you just added at some point some TRACE_EVENT(invalid_pointer) which ended up in some loooooooong string :)
,
May 25 2016
Oh, after clearing all cache and cookies (on my ToT chromium), this is not reproduced. Thanks! However, this is still reproduced on an incognito window. Is this expected?
,
May 25 2016
> this is still reproduced on an incognito window I meant an incognito window of a stable Chrome (M50) without clearing cookies or cache.
,
May 25 2016
Hmm cannot repro on an incognito window. Are you sure that you don't have some other incognito open somewhere else, which would keep your local storage alive (until you close all the incognito windows) ?
,
May 25 2016
I'm sure there were no other incognito windows. I checked that the local storage and the cookie were empty with the inspector.
,
May 25 2016
Hmm does it repro constantly? I tried and it doesn't here. Maybe you can take a dump of the html via devtools and attach here. I wonder if this is some regional/translation thing going horribly wrong.
,
May 25 2016
> Hmm does it repro constantly? I tried and it doesn't here. Yes! I can always reproduce this. > Maybe you can take a dump of the html via devtools and attach here. I wonder if this is some regional/translation thing going horribly wrong. I attached an HTML and a JavaScript file.
,
May 27 2016
OK. This is getting really interesting. I can repro this on Mac, but not on Linux (both Chrome stable 50.0.2661.102). The problem is that the pre-defined list of categories for the "Web developer" preset (which is supposed to be a constant) is modified when the categories are manually edited for some reason. Fixing the issue should just be a matter of copying a list somewhere (rather than passing a reference). I'll try to fix it next week. Just to clarify: To reproduce this, I had to click on "Edit categories" instead of "Manually select settings".
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0020fc2e0570475af620ac7819b89eaa4873d008 commit 0020fc2e0570475af620ac7819b89eaa4873d008 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Wed Jun 01 10:45:47 2016 Roll src/third_party/catapult/ e288c0d9a..14820dc4a (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e288c0d9a188..14820dc4a7cd $ git log e288c0d9a..14820dc4a --date=short --no-merges --format='%ad %ae %s' BUG= 613970 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2031473002 Cr-Commit-Position: refs/heads/master@{#397100} [modify] https://crrev.com/0020fc2e0570475af620ac7819b89eaa4873d008/DEPS
,
Jun 1 2016
This should now be fixed. Please re-open if that's not the case. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by primiano@chromium.org
, May 23 2016Owner: petrcermak@chromium.org