New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613934 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 614297
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Arrow buttons are seen chopped in sensors section of devtools

Project Member Reported by sc00335...@techmahindra.com, May 23 2016

Issue description

Version: 53.0.2746.0 dev 
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Laun chrome and open devtools in any page >> Hit esc for console >> Select "Sensors" from 3 dot menu
(2) Now select any location from Geolocation or Set Orientation and hover on values and observe for up/down arrows

Expected: Arrows should be clear
Actual: Instead Up/Down arrows are seen chopped in sensors section

This is Regression issue.Will provide bisect info soon.

Issue is not seen in 53.0.2746.0 canary windows.
 
Actual_arrowbuttons.ogv
1.3 MB Download
Actual_arrow buttons.png
179 KB View Download
Status: Untriaged (was: Unconfirmed)
Observed the same on Linux Ubuntu 14.04 using chrome version 53.0.2746.0.
But arrows looks fine on windows and Mac using chrome version 53.0.2746.0.


sindhu@ Please provide bisect information

Thanks,
Labels: -Needs-Bisect hasbisect
Owner: bsep@chromium.org
Status: Assigned (was: Untriaged)
Manual Good and Bad Builds:
Good: 52.0.2742.0 dev
Bad: 52.0.2743.0 dev.

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/ddc14e3fa1385f02b466336dc60d0e1eda450769..c24961f458d8016232ab0bff0248e9131c5c7046

Suspecting  https://codereview.chromium.org/1911973002 from changelog.

@bsep: Please confirm the issue and help in re-assigning if it is not related to your change.

Comment 3 by bsep@chromium.org, May 23 2016

I have to say it's pretty likely to be my change. Those buttons look super tiny, and since I changed the arrows to be based on the size of the button they got squished.

I could either increase the size of those buttons or give the arrows a minimum size. Hmm... we'll see.

Comment 4 by bsep@chromium.org, May 23 2016

I don't actually have a way to do Linux builds right now so I'm going to be shooting in the dark trying to fix this, plus I'm going on vacation imminently. If someone wants to jump in and help out on this feel free.

I don't know where the layout for that control is, but I would first try making the arrows bigger. Instead, if you want to make the arrow bigger but leave the buttons the same size look at NativeThemeBase::PathForArrow and see if you can set bounding_rect to a sensible minimum.

Comment 5 by bsep@chromium.org, May 24 2016

Mergedinto: 614297
Status: Duplicate (was: Assigned)
Someone found a similar problem on Windows so I'm marking this duplicate. If that one gets fixed and this is still a problem, feel free to reopen it.

Sign in to add a comment