New issue
Advanced search Search tips

Issue 613925 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.2% regression in smoothness.top_25_smooth at 394083:394107

Project Member Reported by kouhei@chromium.org, May 23 2016

Issue description

See the link to graphs below.
 

Comment 1 by kouhei@chromium.org, May 23 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=613925

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgjP_wrAoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac10
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 23 2016

Cc: wfh@chromium.org
Owner: wfh@chromium.org

=== Auto-CCing suspected CL author wfh@chromium.org ===

Hi wfh@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Enable GPU Raster on OSX (patchset #4 id:140001 of https://codereview.chromium.org/1881053003/ )
Author  : wfh
Commit description:
  
Reason for revert:
Causing stability issues on OS X, please put behind a fieldtrial.

BUG=610544,608566,610971,609612

Original issue's description:
> This change enables GPU Raster on OSX.
>
> I've compiled a bit of benchmark data to support turning this on -
> https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo7ilx9KDB_nJnwpc/edit?usp=sharing
> Still filling in more data, but I'm pretty happy with the results so far. In
> a number of cases we have a performance win, and in most cases we have a power win.
>
> Checking this in now will give us a long canary period before the next branch
> point to catch any issues.
>
> BUG= 542959 
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel
>
> Committed: https://crrev.com/8325892c2efdef8cff86ba16e7569f8b424daeda
> Cr-Commit-Position: refs/heads/master@{#391655}

TBR=vmiura@chromium.org,piman@chromium.org,ericrk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 542959 , 610544, 608566, 610971, 609612

Review-Url: https://codereview.chromium.org/1984183002
Cr-Commit-Position: refs/heads/master@{#394096}
Commit  : 7f558620b78cc53d2a50d11b9d5bf94a229d2874
Date    : Tue May 17 11:01:38 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@394082  14.9254  0.155111   5  good
chromium@394095  14.7746  0.489554   8  good
chromium@394096  16.007   0.20289    5  bad    <--
chromium@394097  15.8413  0.409519   8  bad
chromium@394098  15.913   0.0747696  5  bad
chromium@394101  16.0246  0.214026   5  bad
chromium@394107  16.0576  0.200973   5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 613925

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: mean_input_event_latency/Docs  (1 open document tab)
Relative Change: 7.59%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2125
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011895873668411312


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5770280400584704

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 3 by wfh@chromium.org, May 23 2016

Owner: ericrk@chromium.org

Comment 4 by ericrk@chromium.org, May 23 2016

Status: WontFix (was: Assigned)
This was a revert of a feature that we were trying to launch. There were still some issues with the feature, so we've re-enabled this as a finch experiment and will be using finch to launch. No need for any additional action at this time, graph should recover when the feature launches.

Sign in to add a comment