Issue metadata
Sign in to add a comment
|
14.7% regression in tab_switching.typical_25 at 395145:395165 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 23 2016
=== Auto-CCing suspected CL author erikchen@chromium.org === Hi erikchen@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. Author : erikchen Commit description: The new logic will hold onto GpuMemoryBuffer Resources until they are no longer in use by the Window Server. BUG= 608026 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1984873002 Cr-Commit-Position: refs/heads/master@{#395150} Commit : 87aa976eacd8ed0c530d32a7c85d6ba706dcabf6 Date : Fri May 20 20:16:53 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@395144 2214.6 43.0906 5 good chromium@395147 2224.4 41.8844 5 good chromium@395149 2041.8 343.427 5 good chromium@395150 2490.4 34.2608 5 bad <-- chromium@395155 2531.8 60.2968 5 bad chromium@395165 2522.0 36.8782 5 bad Bisect job ran on: mac_retina_perf_bisect Bug ID: 613892 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.typical_25 Test Metric: idle_wakeups_total/idle_wakeups_total Relative Change: 13.88% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1307 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011902083795748736 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5828876303859712 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 23 2016
I wanted to double-check that the Android regression is the same change, so I sent a bisect for that: https://chromeperf.appspot.com/group_report?bug_id=613892 Also, we are tracking energy_consumption_mwh for these same tests on Mac, and while idle wakeups increase, energy_consumption does not seem to: https://chromeperf.appspot.com/report?sid=d044c0e82b23d72d61e31e378963f62a2c123d2cf65b2bb2ee082baacdbadab0&rev=395165 Are the idle wakeups tests useful?
,
May 23 2016
I think that the concept of tracking idle wakeups is useful, but that this particular test is too noisy. There is a 10% improvement in mean between 147 and 149. There is a 10% regression between 147 and 150. On a separate note, my CL may cause real performance regressions on Mac but is required for correctness.
,
May 23 2016
=== Auto-CCing suspected CL author jaydasika@chromium.org === Hi jaydasika@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : cc : Add IsInIdtoIndexMap to property tres Author : jaydasika Commit description: And use that to update during animations. BUG= 609208 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1994333002 Cr-Commit-Position: refs/heads/master@{#395109} Commit : f2778b2fb94176efcbaab7502cc65279ee8e64e8 Date : Fri May 20 17:53:38 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@395108 2.87721 0.0880318 8 good chromium@395109 3.85697 0.409853 8 bad <-- chromium@395110 4.03401 0.0890157 5 bad chromium@395111 4.02367 0.0456403 5 bad chromium@395114 4.01428 0.0566999 5 bad chromium@395119 3.98348 0.0224802 5 bad chromium@395129 4.01339 0.0278014 5 bad chromium@395149 4.00407 0.0419564 5 bad Bisect job ran on: android_nexus5X_perf_bisect Bug ID: 613892 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases Test Metric: tasks_per_second_total_all/request-animation-frame.html Relative Change: 38.26% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/183 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011868144558878704 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5899960696963072 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 24 2016
Looks like a revert last evening resolved this issue. Closing.
,
May 24 2016
The revert was: commit 63e95dd15a2f88abac85ae5ce9bb2a4fa4c0c1c2 author jaydasika <jaydasika@chromium.org> Mon May 23 19:47:40 2016 committer Commit bot <commit-bot@chromium.org> Mon May 23 19:49:28 2016 Revert of cc : Add IsInIdtoIndexMap to property tres (patchset #4 id:60001 of https://codereview.chromium.org/1994333002/ ) Reason for revert: Breaking android perf test: crbug.com/614022 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kouhei@chromium.org
, May 23 2016