New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613887 link

Starred by 1 user
Status: Fixed
Owner:
ksakamoto@chromium.org
Closed: Dec 4
Cc:
addyo@chromium.org
█ y...@yoav.ws
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test http/tests/preload/meta-viewport-link-headers.html is flaky

Project Member Reported by tkent@chromium.org, May 23 2016 
The following layout test is flaky on all platforms

http/tests/preload/meta-viewport-link-headers.html

Probable cause:
Unknown.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=meta-viewport-link-headers.html
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03a903a26a6cb42545ad3a25386f4ec3759bd57c

commit 03a903a26a6cb42545ad3a25386f4ec3759bd57c
Author: tkent <tkent@chromium.org>
Date: Mon May 23 03:52:22 2016

Mark meta-viewport-link-headers.html flaky.

TBR=yoav@yoav.ws
NOTRY=true
BUG= 613887 

Review-Url: https://codereview.chromium.org/2006533002
Cr-Commit-Position: refs/heads/master@{#395284}

[modify] https://crrev.com/03a903a26a6cb42545ad3a25386f4ec3759bd57c/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by y...@yoav.ws, May 23 2016 

Looking at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=meta-viewport-link-headers.html is seems like flakiness was recently introduced. I'm not sure how to bisect flakiness though...

Is there documentation on the subject?

Comment 3 by tkent@chromium.org, May 23 2016 

Unfortunately there are no easy ways to bisect flaky tests.

If you find a 100%-reproducible step, you can use |git bisect|.

Comment 4 by addyo@chromium.org, Mar 29 2017

Cc: addyo@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0d418bc5d18e3efcfa4bf48aac2f5f1642a1ce7

commit d0d418bc5d18e3efcfa4bf48aac2f5f1642a1ce7
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Dec 04 02:38:29 2018

Deflake http/tests/preload/meta-viewport-link-headers.html

The test was flaky because internals.settings.setViewportMetaEnabled()
for the child window was called too early, before the initial settings
are applied to the new window.

Bug:  613887 
Change-Id: I8222e616ce1489671dc9ea43724ad3a1ad70f91d
Reviewed-on: https://chromium-review.googlesource.com/c/1356175
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613404}
[modify] https://crrev.com/d0d418bc5d18e3efcfa4bf48aac2f5f1642a1ce7/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/d0d418bc5d18e3efcfa4bf48aac2f5f1642a1ce7/third_party/blink/web_tests/http/tests/preload/meta-viewport-link-headers.html
[add] https://crrev.com/d0d418bc5d18e3efcfa4bf48aac2f5f1642a1ce7/third_party/blink/web_tests/http/tests/preload/resources/enable-viewport-and-refresh.html

Comment 6 by ksakamoto@chromium.org, Dec 4

Cc: y...@yoav.ws
Owner: ksakamoto@chromium.org
Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d061a2a324c950c11d3ddce94ab90ab233c1ebf

commit 5d061a2a324c950c11d3ddce94ab90ab233c1ebf
Author: Dominic Battre <battre@chromium.org>
Date: Mon Jan 14 14:07:43 2019

http/tests/preload/meta-viewport-link-headers.html is flaky

Test is flaky see output in bug.

TBR=ksakamoto@chromium.org

Bug:  613887 ,921583
Change-Id: I9e71b49e3a7678c4d3083dfd7f252daa0e485ac2
Reviewed-on: https://chromium-review.googlesource.com/c/1409195
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622443}
[modify] https://crrev.com/5d061a2a324c950c11d3ddce94ab90ab233c1ebf/third_party/blink/web_tests/TestExpectations
►

Sign in to add a comment