Add permission actions reporting to Safe Browsing CSD servers. SEE: go/sb-crowd-consent
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/540173f9b77d793d320d25468d5a775965344894 commit 540173f9b77d793d320d25468d5a775965344894 Author: stefanocs <stefanocs@google.com> Date: Wed May 25 02:03:16 2016 Add a flag for reporting permission actions to Safe Browsing servers BUG= 613883 Review-Url: https://codereview.chromium.org/2006523002 Cr-Commit-Position: refs/heads/master@{#395777} [modify] https://crrev.com/540173f9b77d793d320d25468d5a775965344894/chrome/app/generated_resources.grd [modify] https://crrev.com/540173f9b77d793d320d25468d5a775965344894/chrome/browser/about_flags.cc [modify] https://crrev.com/540173f9b77d793d320d25468d5a775965344894/chrome/common/chrome_switches.cc [modify] https://crrev.com/540173f9b77d793d320d25468d5a775965344894/chrome/common/chrome_switches.h [modify] https://crrev.com/540173f9b77d793d320d25468d5a775965344894/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc47295f0af8d16a52d9a5458c36985cc5d4385a commit fc47295f0af8d16a52d9a5458c36985cc5d4385a Author: stefanocs <stefanocs@google.com> Date: Mon May 30 04:38:12 2016 Add protocol buffer for reporting permission actions to Safe Browsing servers BUG= 613883 Review-Url: https://codereview.chromium.org/2001963003 Cr-Commit-Position: refs/heads/master@{#396675} [modify] https://crrev.com/fc47295f0af8d16a52d9a5458c36985cc5d4385a/chrome/chrome_common.gypi [modify] https://crrev.com/fc47295f0af8d16a52d9a5458c36985cc5d4385a/chrome/common/safe_browsing/BUILD.gn [add] https://crrev.com/fc47295f0af8d16a52d9a5458c36985cc5d4385a/chrome/common/safe_browsing/permission_report.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4169c6ebee28555870861cbc0dc2625c38f7f06f commit 4169c6ebee28555870861cbc0dc2625c38f7f06f Author: stefanocs <stefanocs@google.com> Date: Wed Jun 08 02:11:40 2016 Add permission reporter skeleton for permission action reporting to SafeBrowsing servers. BUG= 613883 Review-Url: https://codereview.chromium.org/2024753002 Cr-Commit-Position: refs/heads/master@{#398461} [add] https://crrev.com/4169c6ebee28555870861cbc0dc2625c38f7f06f/chrome/browser/safe_browsing/permission_reporter.cc [add] https://crrev.com/4169c6ebee28555870861cbc0dc2625c38f7f06f/chrome/browser/safe_browsing/permission_reporter.h [modify] https://crrev.com/4169c6ebee28555870861cbc0dc2625c38f7f06f/chrome/chrome_browser.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd5be520553a3886c5a44a4a02d53ce0fd322e64 commit bd5be520553a3886c5a44a4a02d53ce0fd322e64 Author: stefanocs <stefanocs@google.com> Date: Fri Jun 10 03:37:55 2016 Refactor CertificateReportSender CertificateReportSender renamed to ReportSender TransportSecurityState::ReportSender renamed to TransportSecurityState::ReportSenderInterface BUG= 613883 Review-Url: https://codereview.chromium.org/2026213002 Cr-Commit-Position: refs/heads/master@{#399081} [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/chrome/browser/profiles/profile_io_data.h [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/chrome/browser/ssl/certificate_reporting_test_utils.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/chrome/browser/ssl/chrome_expect_ct_reporter.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/chrome/browser/ssl/chrome_expect_ct_reporter.h [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/components/certificate_reporting/error_reporter.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/components/certificate_reporting/error_reporter.h [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/components/certificate_reporting/error_reporter_unittest.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/net/http/transport_security_state.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/net/http/transport_security_state.h [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/net/http/transport_security_state_unittest.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/net/net.gypi [delete] https://crrev.com/a9e1620934522f32e3a5f500551aadaaa3642a44/net/url_request/certificate_report_sender.h [rename] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/net/url_request/report_sender.cc [add] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/net/url_request/report_sender.h [rename] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/net/url_request/report_sender_unittest.cc [modify] https://crrev.com/bd5be520553a3886c5a44a4a02d53ce0fd322e64/net/url_request/url_request_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e56277cf28fc073104cbae644fcda0d6607652fc commit e56277cf28fc073104cbae644fcda0d6607652fc Author: stefanocs <stefanocs@google.com> Date: Sat Jun 18 01:25:21 2016 Change field_trials type to hashes in permission report proto BUG= 613883 Review-Url: https://codereview.chromium.org/2037693004 Cr-Commit-Position: refs/heads/master@{#400564} [modify] https://crrev.com/e56277cf28fc073104cbae644fcda0d6607652fc/chrome/common/safe_browsing/permission_report.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fea7386282ce4457ede733f5baae3a66b3aec2a commit 7fea7386282ce4457ede733f5baae3a66b3aec2a Author: stefanocs <stefanocs@google.com> Date: Tue Jun 21 07:51:55 2016 Add implementation of PermissionReporter BUG= 613883 Review-Url: https://codereview.chromium.org/2035753004 Cr-Commit-Position: refs/heads/master@{#400917} [modify] https://crrev.com/7fea7386282ce4457ede733f5baae3a66b3aec2a/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/7fea7386282ce4457ede733f5baae3a66b3aec2a/chrome/browser/safe_browsing/permission_reporter.h [add] https://crrev.com/7fea7386282ce4457ede733f5baae3a66b3aec2a/chrome/browser/safe_browsing/permission_reporter_unittest.cc [modify] https://crrev.com/7fea7386282ce4457ede733f5baae3a66b3aec2a/chrome/chrome_tests_unit.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9542b193976dacb41d703f00884c399777f474d3 commit 9542b193976dacb41d703f00884c399777f474d3 Author: stefanocs <stefanocs@google.com> Date: Wed Jun 29 01:41:11 2016 Add field trials and platform to permission report BUG= 613883 Review-Url: https://codereview.chromium.org/2073713002 Cr-Commit-Position: refs/heads/master@{#402628} [modify] https://crrev.com/9542b193976dacb41d703f00884c399777f474d3/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/9542b193976dacb41d703f00884c399777f474d3/chrome/browser/safe_browsing/permission_reporter_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41b6de326ed85f2672e8d38720c140dbafa0862e commit 41b6de326ed85f2672e8d38720c140dbafa0862e Author: stefanocs <stefanocs@google.com> Date: Wed Jul 13 06:00:10 2016 Add hooks to permission layer for permission action reporting - permissions_reporter_ added to SafeBrowsingPingManager - Permission user actions collected by PermissionUmaUtil Reports are only sent to opted-in users (Safe Browsing AND Chrome Tab Sync AND Chrome Pref Sync) Only origin, permission type, and permission action are collected. Data collected are from PROMPT source UI only. BUG= 613883 Review-Url: https://codereview.chromium.org/2047253002 Cr-Commit-Position: refs/heads/master@{#405051} [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/media/media_stream_devices_controller.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/permissions/permission_bubble_request_impl.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/permissions/permission_context_base.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/permissions/permission_infobar_delegate.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/permissions/permission_queue_controller.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/permissions/permission_uma_util.h [add] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/permissions/permission_uma_util_unittest.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/push_messaging/push_messaging_permission_context.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/browser/ui/website_settings/website_settings.cc [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/chrome/chrome_tests_unit.gypi [modify] https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e/components/browser_sync/browser/profile_sync_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b commit a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b Author: thestig <thestig@chromium.org> Date: Thu Jul 14 10:36:06 2016 Revert of Add hooks to permission layer for permission action reporting (patchset #27 id:520001 of https://codereview.chromium.org/2047253002/ ) Reason for revert: Modifying the global command line breaks other tests. Original issue's description: > Add hooks to permission layer for permission action reporting > - permissions_reporter_ added to SafeBrowsingPingManager > - Permission user actions collected by PermissionUmaUtil > > Reports are only sent to opted-in users (Safe Browsing AND Chrome Tab Sync AND Chrome Pref Sync) > > Only origin, permission type, and permission action are collected. > > Data collected are from PROMPT source UI only. > > BUG= 613883 > > Committed: https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e > Cr-Commit-Position: refs/heads/master@{#405051} TBR=kcarattini@chromium.org,raymes@chromium.org,nparker@chromium.org,pavely@chromium.org,sergeyu@chromium.org,johnme@chromium.org,stefanocs@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 613883 Review-Url: https://codereview.chromium.org/2145373002 Cr-Commit-Position: refs/heads/master@{#405465} [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/media/media_stream_devices_controller.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/permissions/permission_bubble_request_impl.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/permissions/permission_context_base.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/permissions/permission_infobar_delegate.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/permissions/permission_queue_controller.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/permissions/permission_uma_util.h [delete] https://crrev.com/5f9ae975c6d36883e44ff5e43127abea282b15d5/chrome/browser/permissions/permission_uma_util_unittest.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/push_messaging/push_messaging_permission_context.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/browser/ui/website_settings/website_settings.cc [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/chrome/chrome_tests_unit.gypi [modify] https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b/components/browser_sync/browser/profile_sync_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9274014049dc1cbfc0f8aaadcd86c321cb2fae72 commit 9274014049dc1cbfc0f8aaadcd86c321cb2fae72 Author: stefanocs <stefanocs@google.com> Date: Tue Jul 19 00:53:46 2016 Reland add hooks to permission layer for permission action reporting Readd r405051 with fix for the memory.fyi issue. Changes compared to r405051: - Use ScopedCommandLine instead of the global variable command line. - Change few lines of code in chrome/browser/permissions/permission_uma_util_unittest.cc and chrome/browser/permissions/permission_uma_util.h according to comments in cl 2047253002. BUG= 613883 Review-Url: https://codereview.chromium.org/2150903002 Cr-Commit-Position: refs/heads/master@{#406166} [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/media/media_stream_devices_controller.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/permissions/permission_bubble_request_impl.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/permissions/permission_context_base.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/permissions/permission_infobar_delegate.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/permissions/permission_queue_controller.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/permissions/permission_uma_util.h [add] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/permissions/permission_uma_util_unittest.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/push_messaging/push_messaging_permission_context.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/browser/ui/website_settings/website_settings.cc [modify] https://crrev.com/9274014049dc1cbfc0f8aaadcd86c321cb2fae72/chrome/chrome_tests_unit.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c0cfd954534699d67193f0d96281c3fb046c8f9 commit 3c0cfd954534699d67193f0d96281c3fb046c8f9 Author: stefanocs <stefanocs@google.com> Date: Tue Jul 19 09:57:44 2016 Add throttling to permission reporter Report sending is restricted to a maximum of 5 reports per minute per origin per permission. BUG= 613883 Review-Url: https://codereview.chromium.org/2089383005 Cr-Commit-Position: refs/heads/master@{#406236} [modify] https://crrev.com/3c0cfd954534699d67193f0d96281c3fb046c8f9/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/3c0cfd954534699d67193f0d96281c3fb046c8f9/chrome/browser/safe_browsing/permission_reporter.h [modify] https://crrev.com/3c0cfd954534699d67193f0d96281c3fb046c8f9/chrome/browser/safe_browsing/permission_reporter_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5fb0e4be3c528a8882ec4288edc20dda14d387f commit a5fb0e4be3c528a8882ec4288edc20dda14d387f Author: stefanocs <stefanocs@google.com> Date: Thu Jul 21 04:24:16 2016 Pass profile to PermissionUmaUtil::PermissionIgnored PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed for the profile parameter. BUG= 613883 Review-Url: https://codereview.chromium.org/2069343002 Cr-Commit-Position: refs/heads/master@{#406766} [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/geolocation/geolocation_infobar_delegate_android.h [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/media/midi_permission_infobar_delegate_android.cc [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/media/midi_permission_infobar_delegate_android.h [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/media/protected_media_identifier_infobar_delegate_android.cc [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/media/protected_media_identifier_infobar_delegate_android.h [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/notifications/notification_permission_infobar_delegate.cc [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/notifications/notification_permission_infobar_delegate.h [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/permissions/permission_context_base.cc [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/permissions/permission_infobar_delegate.cc [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/permissions/permission_infobar_delegate.h [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/permissions/permission_queue_controller.cc [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/permissions/permission_request_impl.cc [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/permissions/permission_request_impl.h [modify] https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f/chrome/browser/permissions/permission_uma_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd67b8eff229c8aecc98515cc2b5a15b12792af2 commit bd67b8eff229c8aecc98515cc2b5a15b12792af2 Author: stefanocs <stefanocs@google.com> Date: Thu Jul 21 05:07:01 2016 Add SourceUI field to permission report PAGE_ACTION also added as a new possible SourceUI value to both proto file enum and code enum. BUG= 613883 Review-Url: https://codereview.chromium.org/2075523002 Cr-Commit-Position: refs/heads/master@{#406769} [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/permissions/permission_uma_util.h [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/safe_browsing/permission_reporter.h [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/safe_browsing/permission_reporter_unittest.cc [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/browser/ui/website_settings/website_settings.cc [modify] https://crrev.com/bd67b8eff229c8aecc98515cc2b5a15b12792af2/chrome/common/safe_browsing/permission_report.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6 commit 34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6 Author: stefanocs <stefanocs@google.com> Date: Thu Jul 21 06:17:47 2016 Add user gesture field to permission report If |user_gesture| is true, PermissionReport::AFTER_GESTURE will be added in request trigger field to the permission report. Adding the value of user_gesture from permission layer will be done in another cl. BUG= 613883 Review-Url: https://codereview.chromium.org/2153763002 Cr-Commit-Position: refs/heads/master@{#406779} [modify] https://crrev.com/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6/chrome/browser/safe_browsing/permission_reporter.h [modify] https://crrev.com/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6/chrome/browser/safe_browsing/permission_reporter_unittest.cc [modify] https://crrev.com/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/34ec372fbc7ea5ebd7b5db1f3270471cf82cf8f6/chrome/browser/safe_browsing/ui_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4f51e6797a9794649c5b30104502f75f192b215 commit f4f51e6797a9794649c5b30104502f75f192b215 Author: stefanocs <stefanocs@google.com> Date: Wed Jul 27 04:24:29 2016 Update RequestTrigger to GestureType in permission report Updated to match the corresponding proto in server side to allow a non boolean value. Changes also made in the permission reporter that a PermissionRequestGestureType enum value will be passed instead of boolean. BUG= 613883 Review-Url: https://codereview.chromium.org/2178213003 Cr-Commit-Position: refs/heads/master@{#408039} [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/browser/safe_browsing/permission_reporter.h [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/browser/safe_browsing/permission_reporter_unittest.cc [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215/chrome/common/safe_browsing/permission_report.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8726709c5a13788275fbbea9770db0c67f4fb7e commit d8726709c5a13788275fbbea9770db0c67f4fb7e Author: stefanocs <stefanocs@google.com> Date: Thu Jul 28 03:44:19 2016 Add gesture type value from desktop prompt to permission report We are using the value of user_gesture obtained from PermissionContextBase::DecidePermission to obtain the PermissionRequestGestureType value. If user_gesture is true, we record PermissionRequestGestureType::GESTURE, otherwise PermissionRequestGestureType::NO_GESTURE. PermissionRequestGestureType::UNKNOWN is used when it is not applicable. To record PermissionIgnored, gesture type obtained from PermissionRequestImpl. For PermissionRevoked, an UNKNOWN gesture type will be passed in since gesture type only applicable in the prompt UIs where revocations are not possible. To record other permission actions, gesture type can be obtained from PermissionContextBase and its subclasses. For call from media_stream_devices_controller, gesture type is set to UNKNOWN since it will be refactored into PermissionContext soon. BUG= 613883 Review-Url: https://codereview.chromium.org/2153133002 Cr-Commit-Position: refs/heads/master@{#408329} [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/geolocation/geolocation_permission_context_android.cc [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/media/media_stream_devices_controller.cc [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/permissions/permission_context_base.cc [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/permissions/permission_context_base.h [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/permissions/permission_infobar_delegate.cc [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/permissions/permission_queue_controller.cc [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/permissions/permission_request_impl.cc [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/d8726709c5a13788275fbbea9770db0c67f4fb7e/chrome/browser/permissions/permission_uma_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a91f52aa8aba6693d89da93c2a5b26c1de8477c2 commit a91f52aa8aba6693d89da93c2a5b26c1de8477c2 Author: stefanocs <stefanocs@google.com> Date: Thu Jul 28 03:52:07 2016 Add gesture type value from infobar to permission report We are using the value of user_gesture obtained from PermissionContextBase::DecidePermission to obtain the PermissionRequestGestureType value. If user_gesture is true, we record PermissionRequestGestureType::GESTURE, otherwise PermissionRequestGestureType::NO_GESTURE. To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate + its subclasses. To record other permission actions, user_gesture is passed to PermissionQueueController. BUG= 613883 Review-Url: https://codereview.chromium.org/2154033003 Cr-Commit-Position: refs/heads/master@{#408333} [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/geolocation/geolocation_infobar_delegate_android.h [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/media/midi_permission_infobar_delegate_android.cc [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/media/midi_permission_infobar_delegate_android.h [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/media/protected_media_identifier_infobar_delegate_android.cc [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/media/protected_media_identifier_infobar_delegate_android.h [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/notifications/notification_permission_infobar_delegate.cc [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/notifications/notification_permission_infobar_delegate.h [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/permissions/permission_context_base.cc [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/permissions/permission_context_base_unittest.cc [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/permissions/permission_infobar_delegate.cc [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/permissions/permission_infobar_delegate.h [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/permissions/permission_queue_controller.cc [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/permissions/permission_queue_controller.h [modify] https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2/chrome/browser/permissions/permission_queue_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3dae8da916baaaa8cd155e73440bc8b6b6019e1 commit d3dae8da916baaaa8cd155e73440bc8b6b6019e1 Author: stefanocs <stefanocs@google.com> Date: Thu Jul 28 04:47:25 2016 Add revocation reporter to permission util A new class ScopedRevocationReporter is added to permission_util.h to replace PermissionUmaUtil::SetContentSettingAndRecordRevocation for reporting revocations. The revocation metrics are sent when the initial resolved content setting is allow and changed when ScopedRevocationReporter is destructed. BUG= 613883 , 469221 Review-Url: https://codereview.chromium.org/2165733003 Cr-Commit-Position: refs/heads/master@{#408338} [modify] https://crrev.com/d3dae8da916baaaa8cd155e73440bc8b6b6019e1/chrome/browser/android/preferences/website_preference_bridge.cc [modify] https://crrev.com/d3dae8da916baaaa8cd155e73440bc8b6b6019e1/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/d3dae8da916baaaa8cd155e73440bc8b6b6019e1/chrome/browser/permissions/permission_util.h [modify] https://crrev.com/d3dae8da916baaaa8cd155e73440bc8b6b6019e1/chrome/browser/permissions/permission_util_unittest.cc [modify] https://crrev.com/d3dae8da916baaaa8cd155e73440bc8b6b6019e1/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b3490ccac018eee6b75c9f64d30700fb1d40d69 commit 8b3490ccac018eee6b75c9f64d30700fb1d40d69 Author: stefanocs <stefanocs@google.com> Date: Thu Jul 28 05:32:52 2016 Add revocations from OIB and content setting Revocations from OIB are recorded from chrome/browser/ui/website_settings/website_settings.cc Revocations from content setting are recorded from chrome/browser/ui/webui/options/content_settings_handler.cc. Revocations are only recorded from content setting if the pattern is a valid host string with no wildcards. We also refactored GetContentSettingsMap to GetProfile and GetOTRContentSettingsMap to GetOTRProfile since we need to pass in the profile to ScopedRevocationReporter. BUG= 613883 , 469221 Review-Url: https://codereview.chromium.org/2180723002 Cr-Commit-Position: refs/heads/master@{#408341} [modify] https://crrev.com/8b3490ccac018eee6b75c9f64d30700fb1d40d69/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/8b3490ccac018eee6b75c9f64d30700fb1d40d69/chrome/browser/permissions/permission_util.h [modify] https://crrev.com/8b3490ccac018eee6b75c9f64d30700fb1d40d69/chrome/browser/permissions/permission_util_unittest.cc [modify] https://crrev.com/8b3490ccac018eee6b75c9f64d30700fb1d40d69/chrome/browser/ui/website_settings/website_settings.cc [modify] https://crrev.com/8b3490ccac018eee6b75c9f64d30700fb1d40d69/chrome/browser/ui/webui/options/content_settings_handler.cc [modify] https://crrev.com/8b3490ccac018eee6b75c9f64d30700fb1d40d69/chrome/browser/ui/webui/options/content_settings_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d95c8fb090d3c2c2e13649740d567c260109cba8 commit d95c8fb090d3c2c2e13649740d567c260109cba8 Author: stefanocs <stefanocs@google.com> Date: Thu Jul 28 06:21:33 2016 Add browsertest for permission action reporting MockReportSender class is refactored from chrome/browser/safe_browsing/permission_reporter_unittest.cc into chrome/browser/safe_browsing/mock_permission_report_sender.cc and renamed to MockPermissionReportSender so that it can be used in chrome/browser/safe_browsing/permission_reporter_browsertest.cc BUG= 613883 Review-Url: https://codereview.chromium.org/2164513002 Cr-Commit-Position: refs/heads/master@{#408346} [modify] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/browser/permissions/permission_request_manager.h [modify] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/browser/permissions/permission_uma_util.cc [add] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/browser/safe_browsing/mock_permission_report_sender.cc [add] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/browser/safe_browsing/mock_permission_report_sender.h [modify] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/browser/safe_browsing/permission_reporter.h [add] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/browser/safe_browsing/permission_reporter_browsertest.cc [modify] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/browser/safe_browsing/permission_reporter_unittest.cc [modify] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/chrome_browser.gypi [modify] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/chrome_tests.gypi [add] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/chrome/test/data/permissions/request.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75fced2336ef1b15095f9e111b411b3ef860960c commit 75fced2336ef1b15095f9e111b411b3ef860960c Author: kcarattini <kcarattini@chromium.org> Date: Tue Aug 16 05:04:03 2016 Permission Report: Add new fields. Add three new fields to Permission Reports: the number of dismissals and ignores prior to this report, and whether the decision on a prompt was persisted. BUG= 613883 Review-Url: https://codereview.chromium.org/2244993002 Cr-Commit-Position: refs/heads/master@{#412169} [modify] https://crrev.com/75fced2336ef1b15095f9e111b411b3ef860960c/chrome/common/safe_browsing/permission_report.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67c8ff87e04bdc649f1be570995d21e7f5ac7475 commit 67c8ff87e04bdc649f1be570995d21e7f5ac7475 Author: kcarattini <kcarattini@chromium.org> Date: Thu Aug 18 00:07:17 2016 Permission Action Reporting: Add num_prior_* fields. Adds the number of prior dismissals and ignores to the permission report. BUG= 613883 Review-Url: https://codereview.chromium.org/2250893002 Cr-Commit-Position: refs/heads/master@{#412700} [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/browsing_data/browsing_data_remover_unittest.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/permissions/permission_decision_auto_blocker.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/permissions/permission_decision_auto_blocker.h [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/safe_browsing/permission_reporter.h [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/safe_browsing/permission_reporter_browsertest.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/safe_browsing/permission_reporter_unittest.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/67c8ff87e04bdc649f1be570995d21e7f5ac7475/chrome/common/safe_browsing/permission_report.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/658733470ae3080b22dfed674be87e69b443dedc commit 658733470ae3080b22dfed674be87e69b443dedc Author: kcarattini <kcarattini@chromium.org> Date: Fri Aug 19 02:02:57 2016 Permission Action Reporting: Bundle report data. Bundles the data for a PermissionReport into a struct and adds the persiste decision. BUG= 613883 Review-Url: https://codereview.chromium.org/2254103003 Cr-Commit-Position: refs/heads/master@{#413023} [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/permissions/permission_uma_util.h [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/safe_browsing/permission_reporter.h [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/safe_browsing/permission_reporter_browsertest.cc [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/safe_browsing/permission_reporter_unittest.cc [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/safe_browsing/ping_manager.cc [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/safe_browsing/ping_manager.h [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/658733470ae3080b22dfed674be87e69b443dedc/chrome/browser/safe_browsing/ui_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/787d1843f6e3b028b008b7a701432fe07225a8a7 commit 787d1843f6e3b028b008b7a701432fe07225a8a7 Author: kcarattini <kcarattini@chromium.org> Date: Fri Aug 19 03:01:39 2016 Permission Action Reporting: Do not report for Custom Passphrase users. BUG= 613883 Review-Url: https://codereview.chromium.org/2220323002 Cr-Commit-Position: refs/heads/master@{#413038} [modify] https://crrev.com/787d1843f6e3b028b008b7a701432fe07225a8a7/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/787d1843f6e3b028b008b7a701432fe07225a8a7/chrome/browser/permissions/permission_uma_util_unittest.cc [modify] https://crrev.com/787d1843f6e3b028b008b7a701432fe07225a8a7/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49450fe932b6cf12caa89354045a6c9d5269e677 commit 49450fe932b6cf12caa89354045a6c9d5269e677 Author: kcarattini <kcarattini@chromium.org> Date: Wed Aug 24 06:56:07 2016 Permission Action Reporting: Make the browsertest work with SyncTest framework. BUG= 613883 Review-Url: https://codereview.chromium.org/2269503002 Cr-Commit-Position: refs/heads/master@{#413999} [modify] https://crrev.com/49450fe932b6cf12caa89354045a6c9d5269e677/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b5e0e8356e4d3b095cbae427d8eee7d10db401c commit 7b5e0e8356e4d3b095cbae427d8eee7d10db401c Author: kcarattini <kcarattini@chromium.org> Date: Wed Aug 24 08:04:12 2016 Permission Metrics: Switch the order of RecordIgnore and PermissionIgnored This needs to be in this order so that PermissionIgnored records the correct num_prior_* numbers for dismissals and ignores. BUG= 613883 , 638076 Review-Url: https://codereview.chromium.org/2267353002 Cr-Commit-Position: refs/heads/master@{#414014} [modify] https://crrev.com/7b5e0e8356e4d3b095cbae427d8eee7d10db401c/chrome/browser/permissions/permission_infobar_delegate.cc [modify] https://crrev.com/7b5e0e8356e4d3b095cbae427d8eee7d10db401c/chrome/browser/permissions/permission_request_impl.cc [modify] https://crrev.com/7b5e0e8356e4d3b095cbae427d8eee7d10db401c/chrome/browser/permissions/permission_uma_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7476914d264aac8ff5d809d342a6f114b8f7f8dc commit 7476914d264aac8ff5d809d342a6f114b8f7f8dc Author: kcarattini <kcarattini@chromium.org> Date: Thu Aug 25 02:12:20 2016 Permission Action Reporting: Fix flaky Browsertest This is my attempt to fix the flakiness of this browsertest by having the UI thread wait for the report to be sent on the IO thread. BUG= 613883 , 638316 Review-Url: https://codereview.chromium.org/2250163003 Cr-Commit-Position: refs/heads/master@{#414252} [modify] https://crrev.com/7476914d264aac8ff5d809d342a6f114b8f7f8dc/chrome/browser/safe_browsing/mock_permission_report_sender.cc [modify] https://crrev.com/7476914d264aac8ff5d809d342a6f114b8f7f8dc/chrome/browser/safe_browsing/mock_permission_report_sender.h [modify] https://crrev.com/7476914d264aac8ff5d809d342a6f114b8f7f8dc/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56bcb45af142373ddd2f7a3ee4df67ea2ee9e0dc commit 56bcb45af142373ddd2f7a3ee4df67ea2ee9e0dc Author: kcarattini <kcarattini@chromium.org> Date: Fri Aug 26 02:16:00 2016 Turn on Permission Action Reporting by default. BUG= 613883 Review-Url: https://codereview.chromium.org/2269863002 Cr-Commit-Position: refs/heads/master@{#414627} [modify] https://crrev.com/56bcb45af142373ddd2f7a3ee4df67ea2ee9e0dc/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/56bcb45af142373ddd2f7a3ee4df67ea2ee9e0dc/chrome/browser/permissions/permission_uma_util_unittest.cc [modify] https://crrev.com/56bcb45af142373ddd2f7a3ee4df67ea2ee9e0dc/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ade822e48b63a78dbe5b812702f74fe831bd6a5c commit ade822e48b63a78dbe5b812702f74fe831bd6a5c Author: kcarattini <kcarattini@chromium.org> Date: Fri Aug 26 02:44:54 2016 Permission Action Reporting: Fix upload url. BUG=641220, 613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2272793009 Cr-Commit-Position: refs/heads/master@{#414637} [modify] https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c/chrome/browser/safe_browsing/permission_reporter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccf55a26b606528638079473f5fd16fec1b85256 commit ccf55a26b606528638079473f5fd16fec1b85256 Author: haraken <haraken@chromium.org> Date: Fri Aug 26 04:39:33 2016 Revert of Permission Action Reporting: Fix upload url. (patchset #1 id:1 of https://codereview.chromium.org/2272793009/ ) Reason for revert: PermissionReporterTest.SendReport started failing on many bots after this CL: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/29240 Original issue's description: > Permission Action Reporting: Fix upload url. > > BUG=641220, 613883 > > TBR=nparker@chromium.org > NOPRESUBMIT=true > NOTRY=true > > Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c > Cr-Commit-Position: refs/heads/master@{#414637} TBR=nparker@chromium.org,kcarattini@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641220, 613883 Review-Url: https://codereview.chromium.org/2279153002 Cr-Commit-Position: refs/heads/master@{#414651} [modify] https://crrev.com/ccf55a26b606528638079473f5fd16fec1b85256/chrome/browser/safe_browsing/permission_reporter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdc8c79c3b29ee3299847cdb11e2c82d66138cff commit bdc8c79c3b29ee3299847cdb11e2c82d66138cff Author: kcarattini <kcarattini@chromium.org> Date: Fri Aug 26 04:53:16 2016 Permission Action Reporting: Fix upload url. BUG=641220, 613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Review-Url: https://codereview.chromium.org/2272793009 Cr-Original-Commit-Position: refs/heads/master@{#414637} Cr-Commit-Position: refs/heads/master@{#414652} [modify] https://crrev.com/bdc8c79c3b29ee3299847cdb11e2c82d66138cff/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/bdc8c79c3b29ee3299847cdb11e2c82d66138cff/chrome/browser/safe_browsing/permission_reporter_unittest.cc
The merge request is only for the change in #c33
Your change meets the bar and is auto-approved for M54 (branch: 2840)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6baa09694b2f1e5341f11ff932a75df1d00ac1b7 commit 6baa09694b2f1e5341f11ff932a75df1d00ac1b7 Author: Kendra Carattini <kcarattini@chromium.org> Date: Sat Aug 27 22:13:11 2016 Permission Action Reporting: Fix upload url. BUG=641220, 613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Review-Url: https://codereview.chromium.org/2272793009 Cr-Original-Commit-Position: refs/heads/master@{#414637} Cr-Commit-Position: refs/heads/master@{#414652} (cherry picked from commit bdc8c79c3b29ee3299847cdb11e2c82d66138cff) Review URL: https://codereview.chromium.org/2288533002 . Cr-Commit-Position: refs/branch-heads/2840@{#6} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/6baa09694b2f1e5341f11ff932a75df1d00ac1b7/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/6baa09694b2f1e5341f11ff932a75df1d00ac1b7/chrome/browser/safe_browsing/permission_reporter_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ac1a535c23c5401d4ae9b4bebea9c62a93d6bd8 commit 6ac1a535c23c5401d4ae9b4bebea9c62a93d6bd8 Author: Kendra Carattini <kcarattini@chromium.org> Date: Sat Aug 27 22:21:15 2016 Turn on Permission Action Reporting by default. BUG= 613883 Review-Url: https://codereview.chromium.org/2269863002 Cr-Commit-Position: refs/heads/master@{#414627} (cherry picked from commit 56bcb45af142373ddd2f7a3ee4df67ea2ee9e0dc) Review URL: https://codereview.chromium.org/2288543002 . Cr-Commit-Position: refs/branch-heads/2840@{#7} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/6ac1a535c23c5401d4ae9b4bebea9c62a93d6bd8/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/6ac1a535c23c5401d4ae9b4bebea9c62a93d6bd8/chrome/browser/permissions/permission_uma_util_unittest.cc [modify] https://crrev.com/6ac1a535c23c5401d4ae9b4bebea9c62a93d6bd8/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fcb04a7eabd49c59a9b25edd7303973d01523b1 commit 2fcb04a7eabd49c59a9b25edd7303973d01523b1 Author: kcarattini <kcarattini@chromium.org> Date: Fri Sep 02 09:37:23 2016 Permission Action Reporting: Test num_prior* metrics are recorded correctly. This test ensures that the change in cl/2267353002 is maintained in the correct order. BUG= 613883 , 638076 Review-Url: https://codereview.chromium.org/2276253002 Cr-Commit-Position: refs/heads/master@{#416223} [modify] https://crrev.com/2fcb04a7eabd49c59a9b25edd7303973d01523b1/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
Is there anything left to do for this bug?
No, marking as fixed. Thanks for the reminder.
Comment 1 by stefanocs@google.com
, May 23 2016