Issue 613882 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	dgozman@chromium.org
Closed:	Jul 2016
Cc:	█ kozyatinskiy@chromium.org pfeldman@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Feature
merge-merged-2795

Blocking:
issue 635948

DevTools: move console to v8_inspector

Project Member Reported by dgozman@chromium.org, May 23 2016

Issue description

This includes agent, console messages and storage.

Comment 1 by dgozman@chromium.org, May 23 2016

Cc: kozyatinskiy@chromium.org pfeldman@chromium.org

Comment 2 by dgozman@chromium.org, May 23 2016

Plan of action:
- Introduce SourceLocation, which encapsulates url/scriptId + lineNumber + columnNumber + stackTrace;
- Migrate clients of ScriptCallStack to SourceLocation, remove ScriptCallStack;
- Instead of creating and passing around ConsoleMessage, pass SourceLocation and only create message when adding to the storage;
- Move console message storage to v8_inspector, making ConsoleMessage a private entity of v8_inspector;
- Move console agent to v8_inspector.

Bonus: reuse SourceLocation in FetchInitiatorInfo.
Bonus*: reuse SourceLocation for async tasks, merging them with initiator info?

Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db28b907dc3c6a7b615ac85fc3bb71cd33554594

commit db28b907dc3c6a7b615ac85fc3bb71cd33554594
Author: dgozman <dgozman@chromium.org>
Date: Tue May 24 07:07:49 2016

Introduce SourceLocation to be used for console messages.

SourceLocation is meant to be used instead of ScriptCallStack and beyond,
representing a location which triggered something (e.g. a console message).

BUG= 613882 

Review-Url: https://codereview.chromium.org/1997293002
Cr-Commit-Position: refs/heads/master@{#395539}

[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/LayoutTests/http/tests/security/postMessage/target-origin-expected.txt
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.h
[add] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[add] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/bindings/core/v8/v8.gypi
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/core/frame/LocalDOMWindow.h
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h
[modify] https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e671a9b843c7885e28c36683f44da6b495b5f295

commit e671a9b843c7885e28c36683f44da6b495b5f295
Author: dgozman <dgozman@chromium.org>
Date: Tue May 24 19:40:36 2016

Switch some clients of ScriptCallStack to SourceLocation.

Improves CSP error reporting.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2001333003
Cr-Commit-Position: refs/heads/master@{#395676}

[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-multiple-expected.txt
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-multiple-reversed-expected.txt
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
[modify] https://crrev.com/e671a9b843c7885e28c36683f44da6b495b5f295/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0

commit 49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0
Author: dgozman <dgozman@chromium.org>
Date: Wed May 25 16:00:22 2016

Migrate websockets from url+lineNumber to SourceLocation.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2004243002
Cr-Commit-Position: refs/heads/master@{#395896}

[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/WebSocketChannel.cpp
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/WebSocketChannel.h
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
[modify] https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0/third_party/WebKit/Source/web/WebPepperSocketImpl.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed

commit dcf3826071f4aa88abe1bd2ebe3a71f510a238ed
Author: dgozman <dgozman@chromium.org>
Date: Thu May 26 05:06:45 2016

Use SourceLocation when reporting runtime exceptions.

This migrates all plumbing to use SourceLocation and puts
all the logic for gathering location information into SourceLocation.

Next logical step would be to use SourceLocation in ErrorEvent internally,
which should add stack traces in some places (e.g. when we postpone
dispatching error event) and remove more plumbing.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2010603002
Cr-Commit-Position: refs/heads/master@{#396122}

[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/testing/NullExecutionContext.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Project Member

Comment 7 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83aabb0c32bf01f588292dc992b135f7f2dd22ca

commit 83aabb0c32bf01f588292dc992b135f7f2dd22ca
Author: dgozman <dgozman@chromium.org>
Date: Fri May 27 01:36:56 2016

Store SourceLocation in ErrorEvent.

Improves error reporting for syntax error in imported script.

This is a follow-up to https://codereview.chromium.org/2010603002/.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2006893004
Cr-Commit-Position: refs/heads/master@{#396346}

[add] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/LayoutTests/inspector/console/console-worker-nested-imports-syntax-error-expected.txt
[add] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/LayoutTests/inspector/console/console-worker-nested-imports-syntax-error.html
[add] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/LayoutTests/inspector/console/resources/importScripts-1.js
[add] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/LayoutTests/inspector/console/resources/importScripts-2.js
[add] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/LayoutTests/inspector/console/resources/importScripts-3.js
[add] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/LayoutTests/inspector/console/resources/invalidScript.js
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/core/events/ErrorEvent.cpp
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/core/events/ErrorEvent.h
[modify] https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

Comment 8 by kozyatinskiy@chromium.org, May 27 2016

 Issue 606055  has been merged into this issue.

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dfba9844c8d7446353d61953d0361e2efdb1e4c

commit 6dfba9844c8d7446353d61953d0361e2efdb1e4c
Author: dgozman <dgozman@chromium.org>
Date: Wed Jun 01 17:03:29 2016

Remove ScriptCallStack.

It is superseded by SourceLocation now.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2016123002
Cr-Commit-Position: refs/heads/master@{#397163}

[delete] https://crrev.com/2b1a3a0cef7431736a887d488be7cb9aa4c40a13/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
[delete] https://crrev.com/2b1a3a0cef7431736a887d488be7cb9aa4c40a13/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.h
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/bindings/core/v8/v8.gypi
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/modules/websockets/WebSocketChannel.h
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c/third_party/WebKit/Source/web/WebPepperSocketImpl.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc3db9db9d183fdbe57418e5924c0486d6dd7de2

commit dc3db9db9d183fdbe57418e5924c0486d6dd7de2
Author: dgozman <dgozman@chromium.org>
Date: Sun Jun 05 20:10:27 2016

[DevTools] Remove unnecessary knowledge about console from core.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2037593004
Cr-Commit-Position: refs/heads/master@{#397947}

[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/fast/dom/Window/console-trace-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/fast/workers/worker-console-log-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods.html
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-clear-function-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-command-clear-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-filter-test-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-nested-group-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-tests-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-time-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-time.html
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-trace-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/console/console-trace-in-eval-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-pause-on-failed-assertion-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/tracing/console-timeline-expected.txt
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/tracing/console-timeline.html
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time.html
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp
[modify] https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bee43695b522e74827332cf43ca2d87ebe32a7d

commit 2bee43695b522e74827332cf43ca2d87ebe32a7d
Author: dgozman <dgozman@chromium.org>
Date: Thu Jun 30 00:09:15 2016

[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG= 613882 
TBR=pfeldman@chromium.org (for includes)

Review-Url: https://codereview.chromium.org/2035653006
Cr-Commit-Position: refs/heads/master@{#403006}

[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/LayoutTests/fast/dom/promise-rejection-events-console.html
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation-expected.txt
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/resources/console-clear-arguments-test.js
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/bindings/core/v8/ScriptController.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/core_generated.gypi
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/frame/FrameConsole.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/frame/FrameHost.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/frame/FrameHost.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/BUILD.gn
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h
[add] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/ConsoleTypes.h
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/InspectorConsoleInstrumentation.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/InspectorInstrumentationCustomInl.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/ScriptArguments.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/inspector/inspector.gyp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/modules/websockets/WebSocketChannel.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/blink_platform.gyp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/inspector_protocol/String16STL.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[add] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[add] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.h
[add] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[add] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/platform/v8_inspector/public/ConsoleAPITypes.h
[delete] https://crrev.com/678f0872c6250ab00efda5f6aba79b923585dc71/third_party/WebKit/Source/platform/v8_inspector/public/ConsoleTypes.h
[add] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/public/V8ConsoleTypes.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
[modify] https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d/third_party/WebKit/Source/web/WebPepperSocketImpl.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c19cc78b55454d4d14c1e8888d3972accb879c6e

commit c19cc78b55454d4d14c1e8888d3972accb879c6e
Author: dgozman <dgozman@chromium.org>
Date: Sun Jul 10 00:32:39 2016

[DevTools] Report unhandled exceptions and promise rejections through Runtime.

Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which report exceptions when Runtime is enabled.

Internally, we share the storage with console messages. That means exceptions can be evicted before Runtime.enable was called due to excessive number of console messages.

Rough edges:
- console.clear also clears the storage for exceptions;
- releaseObjectGroup("console") releases exception objects as well;
- integration on the frontend reuses ConsoleMessage and is somewhat ugly;
- we may want to separate console vs exceptions on backend side.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2116563003
Cr-Commit-Position: refs/heads/master@{#404576}

[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/LayoutTests/inspector-protocol/console/exception-from-worker-contains-stack.html
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/LayoutTests/inspector/console/console-revoke-error-expected.txt
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/LayoutTests/inspector/console/console-revoke-error-in-worker-expected.txt
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/testing/NullExecutionContext.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/core/workers/WorkletGlobalScope.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/public/V8ConsoleTypes.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e/third_party/WebKit/public/web/WebConsoleMessage.h

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63fe38c1e6d9eeefd9036f431456c8a359424fa3

commit 63fe38c1e6d9eeefd9036f431456c8a359424fa3
Author: dgozman <dgozman@chromium.org>
Date: Wed Jul 13 03:59:18 2016

[DevTools] Always send a copy of worker message through the page.

This introduces WorkerMessageSource and sends all the worker messages immediately to the page console.
Client may filter those out when attached to the worker target.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2141673002
Cr-Commit-Position: refs/heads/master@{#404993}

[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/LayoutTests/inspector-protocol/resources/worker-console-worker.js
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/frame/FrameConsole.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/public/V8ConsoleTypes.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63fe38c1e6d9eeefd9036f431456c8a359424fa3

commit 63fe38c1e6d9eeefd9036f431456c8a359424fa3
Author: dgozman <dgozman@chromium.org>
Date: Wed Jul 13 03:59:18 2016

[DevTools] Always send a copy of worker message through the page.

This introduces WorkerMessageSource and sends all the worker messages immediately to the page console.
Client may filter those out when attached to the worker target.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2141673002
Cr-Commit-Position: refs/heads/master@{#404993}

[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/LayoutTests/inspector-protocol/resources/worker-console-worker.js
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/frame/FrameConsole.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/public/V8ConsoleTypes.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a

commit 68b12f1c42ff0d66ee403dfd8b499b9d0f87865a
Author: dgozman <dgozman@chromium.org>
Date: Thu Jul 14 20:43:09 2016

[DevTools] Remove Console.messagesCleared event.

This event doesn't make sense. Frontend can clear console messages log
on navigation if it wants to.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2146163002
Cr-Commit-Position: refs/heads/master@{#405559}

[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/LayoutTests/inspector/console/console-eval-throw.html
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/devtools/front_end/sdk/module.json
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
[modify] https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb90bf24d217da0937226ac058bae3f2a0d8e799

commit fb90bf24d217da0937226ac058bae3f2a0d8e799
Author: dgozman <dgozman@chromium.org>
Date: Fri Jul 15 02:23:42 2016

[DevTools] Report console API calls through Runtime.

Follow the scheme of Runtime.exceptionThrown, but also send a copy of the message (with a string representation of the first argument) via Console.messageAdded. This makes the change backwards-compatible.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2139543002
Cr-Commit-Position: refs/heads/master@{#405679}

[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html
[add] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-api-repeated-in-console-expected.txt
[add] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-api-repeated-in-console.html
[rename] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-deprecated-methods-expected.txt
[rename] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-deprecated-methods.html
[rename] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column-expected.txt
[rename] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column.html
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks.html
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html
[rename] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-timestamp-expected.txt
[rename] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-timestamp.html
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector/console/console-trace-expected.txt
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector/console/console-trace-in-eval-expected.txt
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console-expected.txt
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
[modify] https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea82fa08563b077af8b1acba4d81559974acd149

commit ea82fa08563b077af8b1acba4d81559974acd149
Author: dgozman <dgozman@chromium.org>
Date: Fri Jul 15 16:07:40 2016

[DevTools] Move Timestamp to Runtime, measure it in milliseconds.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2146063006
Cr-Commit-Position: refs/heads/master@{#405762}

[modify] https://crrev.com/ea82fa08563b077af8b1acba4d81559974acd149/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/ea82fa08563b077af8b1acba4d81559974acd149/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/ea82fa08563b077af8b1acba4d81559974acd149/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/ea82fa08563b077af8b1acba4d81559974acd149/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7151bfa310cc76415c6743ccb3aa80e5392205d2

commit 7151bfa310cc76415c6743ccb3aa80e5392205d2
Author: dgozman <dgozman@chromium.org>
Date: Tue Jul 19 04:15:37 2016

[DevTools] Move browser logging from Console domain to Log domain.

Deprecated Console domain.
All the messages except for console API and exceptions are reported through Log domain.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2151273003
Cr-Commit-Position: refs/heads/master@{#406211}

[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/access-inspected-object.html
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[rename] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack-expected.txt
[rename] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html
[rename] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector-protocol/worker/resources/worker-with-throw.js
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector/agents-enable-disable-expected.txt
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector/console/console-clear.html
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector/console/console-eval-scoped.html
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector/console/console-eval-throw.html
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector/console/console-last-result.html
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame-expected.txt
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/core_generated.gypi
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/frame/FrameConsole.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/frame/FrameHost.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/frame/FrameHost.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/BUILD.gn
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[add] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
[add] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/ConsoleTypes.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
[add] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp
[add] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/InspectorLogAgent.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[delete] https://crrev.com/492ef1276bde542b494a57681d3ce0ea3a73ea80/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/inspector/inspector.gyp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/devtools/scripts/CodeGeneratorFrontend.py
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/public/V8ConsoleTypes.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

Comment 19 by dgozman@chromium.org, Jul 19 2016

Status: Fixed (was: Assigned)

Comment 20 by dgozman@chromium.org, Aug 9 2016

Blocking: 635948

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d4a7bcdbde61bb3d550dcf4e23f03c0c84da435

commit 3d4a7bcdbde61bb3d550dcf4e23f03c0c84da435
Author: dgozman <dgozman@chromium.org>
Date: Tue Aug 16 02:40:56 2016

[DevTools] Send correct message level in deprecated Console domain.

BUG= 613882 

Review-Url: https://codereview.chromium.org/2245283002
Cr-Commit-Position: refs/heads/master@{#412146}

[modify] https://crrev.com/3d4a7bcdbde61bb3d550dcf4e23f03c0c84da435/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

►

Issue 613882 link

Issue metadata

DevTools: move console to v8_inspector

Issue description

Comment 1 by dgozman@chromium.org, May 23 2016

Comment 1 Deleted

Comment 2 by dgozman@chromium.org, May 23 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, May 24 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, May 24 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, May 25 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, May 26 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, May 27 2016

Comment 7 Deleted

Comment 8 by kozyatinskiy@chromium.org, May 27 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Jun 1 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jun 5 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Jun 30 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jul 10 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jul 13 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jul 13 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jul 14 2016

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Jul 15 2016

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Jul 15 2016

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Jul 19 2016

Comment 18 Deleted

Comment 19 by dgozman@chromium.org, Jul 19 2016

Comment 19 Deleted

Comment 20 by dgozman@chromium.org, Aug 9 2016

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Aug 16 2016

Comment 21 Deleted

Sign in to add a comment