New issue
Advanced search Search tips

Issue 613880 link

Starred by 0 users
Status: Fixed
Owner:
patricia...@chromium.org
Closed: Jun 2016
Cc:
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 587239


Sign in to add a comment

Make Mac certificate viewer browser tests work for MacViews (not just Cocoa)

Project Member Reported by patricia...@chromium.org, May 23 2016 
Version: 53.0.2745.0
OS: Mac OSX

The SSLCertificateViewerCocoaTest.* tests in the browser_tests target (see chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm) should be refactored so they can be reused to test the certificate viewer for MacViews as seen in  https://crbug.com/587239 / and https://crrev.com/1779383002/.

See comment from tapted@ in the CL linked above:

I think all these other headers are in both builds, so the only thing preventing us running this test in both cocoa and views builds is the stuff that manipulates
SSLCertificateViewerCocoa directly.

to run the same tests, you might need to go through WebContentsModalDialogManager::TestApi by reaching into WebContentsModalDialogManager::child_dialogs_ via the test API and grab the gfx::NativeWindow.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63b0c3d1ec281400262336497fa9803841b8469c

commit 63b0c3d1ec281400262336497fa9803841b8469c
Author: patricialor <patricialor@chromium.org>
Date: Mon Jun 20 05:21:42 2016

Mac: Use a generic interface for testing the certificate viewer.

Refactor the Mac certificate viewer browser tests to work on a generic interface
in preparation for http://crrev.com/1779383002, which refactors the certificate
viewer to remove some Cocoa dependencies for the MacViews browser.

Additionally, remove unneeded code used to resize/reposition the certificate
viewer after switching tabs by ignoring mouse events while the certificate
viewer is hidden instead.

BUG= 613880 

Review-Url: https://codereview.chromium.org/2039823002
Cr-Commit-Position: refs/heads/master@{#400627}

[modify] https://crrev.com/63b0c3d1ec281400262336497fa9803841b8469c/chrome/browser/ui/cocoa/certificate_viewer_mac.h
[modify] https://crrev.com/63b0c3d1ec281400262336497fa9803841b8469c/chrome/browser/ui/cocoa/certificate_viewer_mac.mm
[modify] https://crrev.com/63b0c3d1ec281400262336497fa9803841b8469c/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm
[modify] https://crrev.com/63b0c3d1ec281400262336497fa9803841b8469c/chrome/chrome_tests.gypi
[modify] https://crrev.com/63b0c3d1ec281400262336497fa9803841b8469c/chrome/test/BUILD.gn

Comment 2 by patricia...@chromium.org, Jun 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment