Configuring both IWL7000 and IWLWIFI causes suurious build errors |
||||||
Issue descriptionIf both IWL7000 and IWLWIFI are configured, spurious build errors with missing iwl symbols may be seen. This often, but not always, happens with the first build in a clean tree. ERROR: "iwl_cmd_groups_verify_sorted" [drivers/net/wireless/iwl7000/iwlwifi/xvt/iwlxvt.ko] undefined! ERROR: "iwl_dnt_start" [drivers/net/wireless/iwl7000/iwlwifi/xvt/iwlxvt.ko] undefined! ERROR: "iwl_trans_send_cmd" [drivers/net/wireless/iwl7000/iwlwifi/xvt/iwlxvt.ko] undefined! ERROR: "iwl_tm_gnl_send_msg" [drivers/net/wireless/iwl7000/iwlwifi/xvt/iwlxvt.ko] undefined! ERROR: "iwl_dnt_init" [drivers/net/wireless/iwl7000/iwlwifi/xvt/iwlxvt.ko] undefined! ERROR: "iwl_phy_db_get_section_data" [drivers/net/wireless/iwl7000/iwlwifi/xvt/iwlxvt.ko] undefined! ERROR: "iwl_dnt_free" [drivers/net/wireless/iwl7000/iwlwifi/xvt/iwlxvt.ko] undefined! ERROR: "iwl_dnt_dispatch_collect_ucode_message" [drivers/net/wireless/iwl7000/iwlwifi/xvt/iwlxvt.ko] undefined! The root cause is that both configurations define the same functions (example: iwl_notification_wait_init or iwl_opmode_register), but IWL7000 provides additional functions. Which symbols are picked up by genksyms is random. If symbols from IWLWIFI are picked up, the additional symbols from IWL7000 are missing when the xvt module are built.
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/961255e8f0794784a37753ebc012aaf411b0669e commit 961255e8f0794784a37753ebc012aaf411b0669e Author: Johannes Berg <johannes.berg@intel.com> Date: Thu Oct 22 20:36:08 2015 CHROMIUM: iwlwifi: depend on not selecting IWL7000 Since iwl7000 and iwlwifi have similar hardware support and conflicting modules, disable iwlwifi when iwl7000 is selected. It's done this way around since iwl7000 is the code Intel supports. BUG= chromium:544751 , chromium:613844 TEST=enable IWL7000 and check that IWLWIFI cannot be selected Change-Id: Ib7c050a0c4ab5ff114ebd3b20e5a0f4b0d1991c2 Signed-off-by: Johannes Berg <johannes.berg@intel.com> Reviewed-on: https://chromium-review.googlesource.com/307771 Commit-Ready: Anatol Pomazau <anatol@google.com> Tested-by: Anatol Pomazau <anatol@google.com> Reviewed-by: Sameer Nanda <snanda@chromium.org> Reviewed-by: Anatol Pomazau <anatol@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 0a057e769d49a2f55b2828829f5dda62eb440d2d) Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/347430 [modify] https://crrev.com/961255e8f0794784a37753ebc012aaf411b0669e/drivers/net/wireless/intel/iwlwifi/Kconfig
,
May 30 2016
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/99a792dfe8dceaa995aa894f03d9bc3fb436e532 commit 99a792dfe8dceaa995aa894f03d9bc3fb436e532 Author: Johannes Berg <johannes.berg@intel.com> Date: Thu Nov 16 02:24:44 2017 CHROMIUM: iwlwifi: depend on not selecting IWL7000 Since iwl7000 and iwlwifi have similar hardware support and conflicting modules, disable iwlwifi when iwl7000 is selected. It's done this way around since iwl7000 is the code Intel supports. BUG= chromium:544751 , chromium:613844 TEST=enable IWL7000 and check that IWLWIFI cannot be selected Change-Id: Ib7c050a0c4ab5ff114ebd3b20e5a0f4b0d1991c2 Signed-off-by: Johannes Berg <johannes.berg@intel.com> Reviewed-on: https://chromium-review.googlesource.com/307771 Commit-Ready: Anatol Pomazau <anatol@google.com> Tested-by: Anatol Pomazau <anatol@google.com> Reviewed-by: Sameer Nanda <snanda@chromium.org> Reviewed-by: Anatol Pomazau <anatol@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 0a057e769d49a2f55b2828829f5dda62eb440d2d) Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/347430 Reviewed-on: https://chromium-review.googlesource.com/764860 Trybot-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/99a792dfe8dceaa995aa894f03d9bc3fb436e532/drivers/net/wireless/intel/iwlwifi/Kconfig
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ca763133dc841ea4ac1739c1262af8b195ee731c commit ca763133dc841ea4ac1739c1262af8b195ee731c Author: Johannes Berg <johannes.berg@intel.com> Date: Fri Jan 26 01:34:10 2018 CHROMIUM: iwlwifi: depend on not selecting IWL7000 Since iwl7000 and iwlwifi have similar hardware support and conflicting modules, disable iwlwifi when iwl7000 is selected. It's done this way around since iwl7000 is the code Intel supports. BUG= chromium:544751 , chromium:613844 TEST=enable IWL7000 and check that IWLWIFI cannot be selected Change-Id: Ib7c050a0c4ab5ff114ebd3b20e5a0f4b0d1991c2 Signed-off-by: Johannes Berg <johannes.berg@intel.com> Reviewed-on: https://chromium-review.googlesource.com/307771 Commit-Ready: Anatol Pomazau <anatol@google.com> Tested-by: Anatol Pomazau <anatol@google.com> Reviewed-by: Sameer Nanda <snanda@chromium.org> Reviewed-by: Anatol Pomazau <anatol@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 0a057e769d49a2f55b2828829f5dda62eb440d2d) Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/347430 Reviewed-on: https://chromium-review.googlesource.com/764860 Trybot-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> (cherry picked from commit 99a792dfe8dceaa995aa894f03d9bc3fb436e532) Reviewed-on: https://chromium-review.googlesource.com/887751 Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> Commit-Queue: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/ca763133dc841ea4ac1739c1262af8b195ee731c/drivers/net/wireless/intel/iwlwifi/Kconfig
,
Jan 17
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7e65453a1f72ef49abb928a2f54ba4b653bcab6f commit 7e65453a1f72ef49abb928a2f54ba4b653bcab6f Author: Johannes Berg <johannes.berg@intel.com> Date: Thu Jan 17 13:16:15 2019 CHROMIUM: iwlwifi: depend on not selecting IWL7000 Since iwl7000 and iwlwifi have similar hardware support and conflicting modules, disable iwlwifi when iwl7000 is selected. It's done this way around since iwl7000 is the code Intel supports. BUG=b:119120513, chromium:544751 , chromium:613844 TEST=enable IWL7000 and check that IWLWIFI cannot be selected Check by building dragonegg with iwl7000 enabled. Change-Id: Ib7c050a0c4ab5ff114ebd3b20e5a0f4b0d1991c2 Signed-off-by: Johannes Berg <johannes.berg@intel.com> Reviewed-on: https://chromium-review.googlesource.com/307771 Commit-Ready: Anatol Pomazau <anatol@google.com> Tested-by: Anatol Pomazau <anatol@google.com> Reviewed-by: Sameer Nanda <snanda@chromium.org> Reviewed-by: Anatol Pomazau <anatol@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 0a057e769d49a2f55b2828829f5dda62eb440d2d) Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1409458 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/7e65453a1f72ef49abb928a2f54ba4b653bcab6f/drivers/net/wireless/intel/iwlwifi/Kconfig |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by groeck@chromium.org
, May 22 2016