Separate out members needed in RunOnWorkerThread() and OnTaskCompleted() in tasks. |
||
Issue descriptionAs worker thread and origin threads run in parallel, following things should be obeyed. 1. Members passed to RunOnWorkerThread(), must be thread safe. 2. Members which are needed for OnTaskCompleted() can be non thread safe and should be in separate private structure.
,
May 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c2861c68d1a70d00b07adb28ee27d87b71110d5 commit 7c2861c68d1a70d00b07adb28ee27d87b71110d5 Author: prashant.n <prashant.n@samsung.com> Date: Sat May 28 08:53:23 2016 cc: Ensure members needed on task completion get called on valid thread. Few members needed for task completion are not thread safe. e.g. Tile. They should not be called on worker thread. To ensure these are called on valid thread, always access them with thread_checker. BUG= 613812 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2003353003 Cr-Commit-Position: refs/heads/master@{#396637} [modify] https://crrev.com/7c2861c68d1a70d00b07adb28ee27d87b71110d5/cc/tiles/tile_manager.cc
,
May 30 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by vmp...@chromium.org
, May 24 2016