Interesting. I am on Chrome Canary 52.0.2730.0 (older than yours) and this hasn't deleted. On Windows 7.

OK. Updated to 53.0.2745.0 and the shortcut was deleted (within about 10s).

https://codereview.chromium.org/1926403002 landed in 52.0.2735.0 - it's probably that. But... I have no clue how or what o_O

https://codereview.chromium.org/1861233003 is 52.0.2736.0 . I guess it could be that too, but that "should" be a no-op.

The actual flag flip in https://codereview.chromium.org/1934213002 didn't land until 52.0.2742.0

Possibly r393415 (Remove BrowserDistribution::SHORTCUT_APP_LAUNCHER). That is in our bisect range (r392504..r393996).

ok. So I *think* it's this:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/shell_integration_win.cc&l=139

I suspect that DCHECK is failing... but I haven't found the point at which the shortcut is removed

oops - meant to paste https://codereview.chromium.org/1926403002/diff/140001/chrome/browser/shell_integration_win.cc#oldcode139

I'm building Chromium at r393415 now to try and repro. In the meantime, assigning to tapted@.

Bleh. This should block beta. We're late in the cycle, but I think we're still doing m51 betas until ~June.

https://codereview.chromium.org/2005163002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2c690ab31976ed7bd715709606f736085d6b43e

commit c2c690ab31976ed7bd715709606f736085d6b43e
Author: tapted <tapted@chromium.org>
Date: Wed May 25 02:49:03 2016

Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG= 613789 

Review-Url: https://codereview.chromium.org/2005163002
Cr-Commit-Position: refs/heads/master@{#395785}

[modify] https://crrev.com/c2c690ab31976ed7bd715709606f736085d6b43e/chrome/browser/shell_integration_win.cc

Planning to verify in today's canary.

Need a merge to M42 if its fixed.

Yup - the CL just missed the 53.0.2748.0 canary sadly. I'll keep an eye out for the next one to verify, since (re)-Establishing the environment to test can be tricky: You need to first have an app launcher shortcut "installed", and we've removed the ability to do that, so it must have been installed from an earlier version of Chrome (e.g. m51).

If it's been previously installed, this bug won't clobber the shortcut in the _Start Menu_. That still has a correct app_id, and can be re-pinned. Press Windows key, and start typing 'App Launcher Canary' - right click result and select 'Pin to Taskbar'.

In 53.0.2748.0, re-running Chrome Canary will cause this to get deleted again. If this is fixed in 53.0.2749.?, then re-running Chrome should keep it.

Deleted: Screen Shot 2016-05-26 at 9.49.16 AM.png 28.8 KB

	Screen Shot 2016-05-26 at 9.49.16 AM.png 28.8 KB View Download

Please find the below observations:
(i) Installed Current Stable# 51.0.2704.63 and installed App Launcher.

(ii) Over installed latest Chrome Canary equivalent build# 53.0.2749.0 and updated successfully. App Launcher is still seen in Task bar. On clicking App Launcher from the Task bar, user is re-directed to chrome://apps.

@tapted -- Please let me know if anything else is required.
Thank You.

Thanks! That all sounds good. And yup I just tried out the 53.0.2749.0 Canary myself and used the re-pin from Start Menu trick. Restarted, and the pin stayed around, so this seems all fixed.

Requesting merge.

Your change meets the bar and is auto-approved for M52 (branch: 2743)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6245e3c98aca06ea1ecc285ea3d764d9fc677122

commit 6245e3c98aca06ea1ecc285ea3d764d9fc677122
Author: Trent Apted <tapted@chromium.org>
Date: Thu May 26 12:53:58 2016

[merge-m52] Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG= 613789 

Review-Url: https://codereview.chromium.org/2005163002
Cr-Commit-Position: refs/heads/master@{#395785}
(cherry picked from commit c2c690ab31976ed7bd715709606f736085d6b43e)

Review URL: https://codereview.chromium.org/2012843004 .

Cr-Commit-Position: refs/branch-heads/2743@{#76}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/6245e3c98aca06ea1ecc285ea3d764d9fc677122/chrome/browser/shell_integration_win.cc

Tested the same on win8.1 chrome version 52.0.2743.19 - chrome app launcher is available on task bar on overinstalling dev on stable 51.0.2704.63 version

Adding TE-Verified labels.