The distance between the lock and the left edge of the omnibox needs to be decreased by 1pt. The distance between the lock and the start of the text should remain the same.

Also, on non-Retina it looks like the lock icon needs to move up 1pt.

If possible, please don't move it up 1pt. Vertically it looks really fine on non-retina. Thank you :-)

I'm attaching a movie with http and ev cert screenshots overlapped. You can see that the lock icons are slightly different between the two. They should be the same.

I've also attached a screenshot showing how the ev cert text is 1pt higher than the URL text that follows it on Retina.

Deleted: LockSizeAndColor.mov 959 KB

LockSizeAndColor.mov 959 KB Download

Deleted: Screen Shot 2016-05-26 at 9.14.38 AM.png 30.4 KB

	Screen Shot 2016-05-26 at 9.14.38 AM.png 30.4 KB View Download

Not just the icon, the colors are also slightly different.

So in a number of places where we set colors we are using calibrated colors. Instead we want to use sRGB colors (e.g. colorWithSRGBRed:green:blue:alpha:). I suspect that might be what's happening. It might not be easy to fix for vector images - I think the code that converts a Skia image to NSImage uses a generic or calibrated colorspace. We would need a hook to tell it to use the sRGB space.

Anyways, those are some thoughts. I think you should focus on getting the position and sizing correct, and explore the color issue but not let color hold up the other changes. We can always fix that in a different cl.

shrike@: Is the Keyword Search EV also 1pt higher than the typed text after the colon on Retina? (Sorry, I have no Retina to test it :-( ) Thanks.

I don't see that at all on non-Retina, for EV cert or search. See my screenshot. Can you attach a screenshot?

Deleted: Screen Shot 2016-05-26 at 12.02.15 PM.png 16.2 KB

	Screen Shot 2016-05-26 at 12.02.15 PM.png 16.2 KB View Download

Thanks for checking. On Non-Retina, both, the EV Cert and the Keyword Search, are looking fine aligned. Screenshots are attached.

Deleted: Non-Retina_EV_Cert.png 29.0 KB

	Non-Retina_EV_Cert.png 29.0 KB View Download

Deleted: Non-Retina_Keyword_Search.png 27.3 KB

	Non-Retina_Keyword_Search.png 27.3 KB View Download

spqchan@ - it looks like you should use LOCATION_BAR_HTTPS_VALID everywhere and remove all instances of LOCATION_BAR_HTTPS_VALID_IN_CHIP.

Awesome, is this being address on Windows too? I can see that location_bar_view.cc is using LOCATION_BAR_HTTPS_VALID_IN_CHIP.

I don't know. estade@ claims we're the only ones using it, even though it's plainly there in codesearch. Maybe he or someone else is working on a cl to remove it.

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd

commit 7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd
Author: spqchan <spqchan@chromium.org>
Date: Fri Jun 03 17:11:33 2016

[Material][Mac] Adjustments to the Omnibox decorations

BUG= 613788 , 611113 

Review-Url: https://codereview.chromium.org/2002103003
Cr-Commit-Position: refs/heads/master@{#397734}

[modify] https://crrev.com/7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ec6ca0d527ce67090b6c7c7de05e2572022d51

commit a2ec6ca0d527ce67090b6c7c7de05e2572022d51
Author: spqchan <spqchan@chromium.org>
Date: Wed Jun 08 18:31:51 2016

[Material][Mac] Adjustments to the Omnibox decorations

BUG= 613788 , 611113 

Review-Url: https://codereview.chromium.org/2002103003
Cr-Commit-Position: refs/heads/master@{#397734}
(cherry picked from commit 7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd)

Review URL: https://codereview.chromium.org/2050623004 .

Cr-Commit-Position: refs/branch-heads/2743@{#282}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/a2ec6ca0d527ce67090b6c7c7de05e2572022d51/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/a2ec6ca0d527ce67090b6c7c7de05e2572022d51/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ec6ca0d527ce67090b6c7c7de05e2572022d51

commit a2ec6ca0d527ce67090b6c7c7de05e2572022d51
Author: spqchan <spqchan@chromium.org>
Date: Wed Jun 08 18:31:51 2016

[Material][Mac] Adjustments to the Omnibox decorations

BUG= 613788 , 611113 

Review-Url: https://codereview.chromium.org/2002103003
Cr-Commit-Position: refs/heads/master@{#397734}
(cherry picked from commit 7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd)

Review URL: https://codereview.chromium.org/2050623004 .

Cr-Commit-Position: refs/branch-heads/2743@{#282}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/a2ec6ca0d527ce67090b6c7c7de05e2572022d51/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/a2ec6ca0d527ce67090b6c7c7de05e2572022d51/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

spqchan@ : Could you please let us know if any specific steps and urls to verify from TE end.Please find the attached screen shot of MacBook Air 10.11.5 using 52.0.2743.41.

Deleted: June 15_Mac.png 30.9 KB

	June 15_Mac.png 30.9 KB View Download