New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613787 link

Starred by 3 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
█ spqc...@chromium.org
nyerramilli@chromium.org
█ ashej...@chromium.org
█ shrike@chromium.org
sgabr...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Mac][MaterialDesign] PopUpBlocker: The new divider is overlapping the animation

Project Member Reported by meh...@chromium.org, May 21 2016 
Version: Chromium Build 395248
OS: Mac OS 10.11.5

What steps will reproduce the problem?
(1) open popuptest.com/popuptest1.html 
(2) take a look at the PopUpBlocker animation in the Omnibox

What is the expected output? What do you see instead?
You'll see that the divider is overlapping the animation. 

A screencast is attached.

Thanks
Mehmet
PopUpBlocker.mov
212 KB Download

Comment 1 by shrike@chromium.org, May 23 2016

Owner: sgabr...@chromium.org
sgabriel@, would you chime in on the animation? Should the text slide out of the divider or should it remain as is where it slides out under the divider?

Comment 2 by sgabr...@chromium.org, May 23 2016 

Slide out of the divider.

Comment 3 by shrike@chromium.org, May 23 2016

Cc: -spqc...@chromium.org sgabr...@chromium.org
Labels: M-53
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
Thank you.

spqchan@ - would you change the animation so that the text slides out from the divider instead of under it?

Comment 4 by spqc...@chromium.org, May 28 2016

Cc: spqc...@chromium.org nyerramilli@chromium.org ashej...@chromium.org
 Issue 615006  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f01f1e64e676b379f42fcaa2fc25f3c6295dfe

commit 65f01f1e64e676b379f42fcaa2fc25f3c6295dfe
Author: spqchan <spqchan@chromium.org>
Date: Wed Jun 01 17:36:55 2016

[Material][Mac]Fixed the popup blocker animation

BUG= 613787 

Review-Url: https://codereview.chromium.org/2026063002
Cr-Commit-Position: refs/heads/master@{#397172}

[modify] https://crrev.com/65f01f1e64e676b379f42fcaa2fc25f3c6295dfe/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm

Comment 6 by spqc...@chromium.org, Jun 1 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment