New issue
Advanced search Search tips

Issue 613755 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 467601



Sign in to add a comment

NQE should allow observers to register to changes in EffectiveConnectionType

Project Member Reported by tbansal@chromium.org, May 20 2016

Issue description

NQE should allow observers to register to changes in EffectiveConnectionType.

NQE should compute EffectiveConnectionType on every connection change, and every time there is some network traffic (provided it was last computed more than T seconds ago). If the newly computed value is different than the previous value, it should notify the thread safe observers.

Additionally, there should be some hysteresis built in the notifications so that observers are not notified too frequently.
 
Summary: NQE should allow observers to register to changes in EffectiveConnectionType (was: NQE should allow thread safe observers to register to changes in EffectiveConnectionType)
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c6ca1c7bccc7e61bc98adc9eda8a4ebd58b6423

commit 7c6ca1c7bccc7e61bc98adc9eda8a4ebd58b6423
Author: tbansal <tbansal@chromium.org>
Date: Tue May 31 23:42:33 2016

Expose NQE::OnEffectiveConnectionTypeChanged API

NQE maintains a list of thread-unsafe observers. It also
computes the effective connection type at regular intervals,
provided the device is actively receiving traffic from the
Internet. If there is a change in the effective connection
type, all the observers are notified.

BUG= 613755 

Review-Url: https://codereview.chromium.org/2007713002
Cr-Commit-Position: refs/heads/master@{#396976}

[modify] https://crrev.com/7c6ca1c7bccc7e61bc98adc9eda8a4ebd58b6423/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/7c6ca1c7bccc7e61bc98adc9eda8a4ebd58b6423/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/7c6ca1c7bccc7e61bc98adc9eda8a4ebd58b6423/net/nqe/network_quality_estimator_unittest.cc

Status: Fixed (was: Started)
Components: Internals>Network>NetworkQuality

Sign in to add a comment