New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613747 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Help moblab user to reboot when new release is available

Project Member Reported by ntang@google.com, May 20 2016

Issue description

When new release is available, moblab devices need to be restarted for new chrome os to take effect. 
 

Comment 1 by sbasi@chromium.org, May 21 2016

My suggestion: The UI has a notification at the top alerting the user there is a new update and they should reboot the moblab.

This way if they are running the SSD test (3 weeks) they can get the update after the test is finished.

Comment 2 by ntang@google.com, May 21 2016

Is there an api/command to know if there is an update downloaded on the system? 

Comment 3 by sbasi@chromium.org, May 23 2016

Cc: de...@chromium.org
+Deymo

update_engine_client should help here.

From the --help output:
  --is_reboot_needed  (Exit status 0 if reboot is needed, 2 if reboot is not needed or 1 if an error occurred.)  type: bool  default: false

Comment 4 by de...@chromium.org, May 24 2016

You can also make it block until the reboot is needed.

while ! update_engine_client --block_until_reboot_is_needed; do
  sleep 1; # Something went wrong talking to update_engine
done
reboot

Comment 5 by ntang@google.com, May 24 2016

sounds like a good idea to go.
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google

Comment 7 by krk@chromium.org, Dec 7 2016

Labels: M-56
Prioritizing it for M-56

Comment 8 by krk@chromium.org, Dec 7 2016

Labels: -Pri-3 OS-Chrome Pri-2
Owner: ntang@chromium.org
Status: Assigned (was: Untriaged)

Comment 9 by krk@chromium.org, Dec 12 2016

Labels: Q117
Owner: ----
Status: Available (was: Assigned)
Components: Infra>Client>ChromeOS
Cc: pprabhu@chromium.org
Owner: mattmallett@chromium.org
Status: Started (was: Available)
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 26 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ed5ed01485afa6f55dc8c0a5793dc73620cbb7f5

commit ed5ed01485afa6f55dc8c0a5793dc73620cbb7f5
Author: Matt Mallett <mattmallett@chromium.org>
Date: Fri Jan 26 22:46:44 2018

[moblab] Add update button

BUG= chromium:613747 
TEST=Tested features on a local moblab

Change-Id: Id512a96e57c5449ace561b8a551b2570ab637468
Reviewed-on: https://chromium-review.googlesource.com/887794
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit b0f8dc76b36d2b04e08024e98add237597e59d35)
Reviewed-on: https://chromium-review.googlesource.com/890098
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/ed5ed01485afa6f55dc8c0a5793dc73620cbb7f5/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java
[modify] https://crrev.com/ed5ed01485afa6f55dc8c0a5793dc73620cbb7f5/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/ed5ed01485afa6f55dc8c0a5793dc73620cbb7f5/frontend/client/src/autotest/moblab/rpc/VersionInfo.java
[modify] https://crrev.com/ed5ed01485afa6f55dc8c0a5793dc73620cbb7f5/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/ed5ed01485afa6f55dc8c0a5793dc73620cbb7f5/frontend/client/src/autotest/moblab/rpc/MoblabRpcHelper.java

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 26 2018

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 26 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/400221f4efe03d00a19337f8ec2b3a3de712d1fa

commit 400221f4efe03d00a19337f8ec2b3a3de712d1fa
Author: Matt Mallett <mattmallett@chromium.org>
Date: Fri Jan 26 22:46:47 2018

[moblab] give apache permission to call update_engine_client

BUG= chromium:613747 
TEST=local moblab device

Change-Id: Iec72cfa80b9c4efcbcc01691925c404aaa96d237
Reviewed-on: https://chromium-review.googlesource.com/887732
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit d3a3c24b3f014272c5e661bd6b7871040ebdd22e)
Reviewed-on: https://chromium-review.googlesource.com/889687
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[add] https://crrev.com/400221f4efe03d00a19337f8ec2b3a3de712d1fa/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r79.ebuild
[modify] https://crrev.com/400221f4efe03d00a19337f8ec2b3a3de712d1fa/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5.ebuild

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 26 2018

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c223505b3ed3e90c57c5bd4fb98799c9e8fa0078

commit c223505b3ed3e90c57c5bd4fb98799c9e8fa0078
Author: Matt Mallett <mattmallett@chromium.org>
Date: Wed Jan 31 21:23:51 2018

[moblab] Use the is_reboot_needed value correctly

Use the return code from --is_reboot_needed correctly
to cause the moblab device to update when a new
version is downloaded and ready to install

BUG= chromium:613747 
TEST=updated local moblab device from 10176.62.0 to 10176.65.0 via UI

Change-Id: I2204b3fcf2a2602b72350d380d3112a47a48a2ad
Reviewed-on: https://chromium-review.googlesource.com/895905
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/c223505b3ed3e90c57c5bd4fb98799c9e8fa0078/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/c223505b3ed3e90c57c5bd4fb98799c9e8fa0078/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/c223505b3ed3e90c57c5bd4fb98799c9e8fa0078/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/39266c967c34d0ad1530314c1f03bfe2cfa2ecb4

commit 39266c967c34d0ad1530314c1f03bfe2cfa2ecb4
Author: Matt Mallett <mattmallett@chromium.org>
Date: Thu Feb 01 00:28:12 2018

[moblab] Use the is_reboot_needed value correctly

Use the return code from --is_reboot_needed correctly
to cause the moblab device to update when a new
version is downloaded and ready to install

BUG= chromium:613747 
TEST=updated local moblab device from 10176.62.0 to 10176.65.0 via UI

Change-Id: I2204b3fcf2a2602b72350d380d3112a47a48a2ad
Reviewed-on: https://chromium-review.googlesource.com/895905
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit c223505b3ed3e90c57c5bd4fb98799c9e8fa0078)
Reviewed-on: https://chromium-review.googlesource.com/896486
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/39266c967c34d0ad1530314c1f03bfe2cfa2ecb4/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/39266c967c34d0ad1530314c1f03bfe2cfa2ecb4/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/39266c967c34d0ad1530314c1f03bfe2cfa2ecb4/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ae24cf391684582721deb92620035310d9ab4092

commit ae24cf391684582721deb92620035310d9ab4092
Author: Matt Mallett <mattmallett@chromium.org>
Date: Thu Feb 01 00:28:14 2018

[moblab] Use the is_reboot_needed value correctly

Use the return code from --is_reboot_needed correctly
to cause the moblab device to update when a new
version is downloaded and ready to install

BUG= chromium:613747 
TEST=updated local moblab device from 10176.62.0 to 10176.65.0 via UI

Change-Id: I2204b3fcf2a2602b72350d380d3112a47a48a2ad
Reviewed-on: https://chromium-review.googlesource.com/895905
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit c223505b3ed3e90c57c5bd4fb98799c9e8fa0078)
Reviewed-on: https://chromium-review.googlesource.com/896378
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/ae24cf391684582721deb92620035310d9ab4092/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/ae24cf391684582721deb92620035310d9ab4092/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/ae24cf391684582721deb92620035310d9ab4092/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b879766de2fe6fcc9beb9dc76587a20fe2c9499d

commit b879766de2fe6fcc9beb9dc76587a20fe2c9499d
Author: Matt Mallett <mattmallett@chromium.org>
Date: Fri Feb 02 20:08:13 2018

[moblab] correctly display update progress on UI

Wait for the update engine to finish checking for an update before
returning from the RPC. Also improve messaging on the UI to make
update progress easy to follow.

BUG= chromium:613747 
TEST=local moblab tested by updating from R64-10176.62.0 to
R64010176.65.0

Change-Id: I16910cc1365dc65980e269da7bbcabc28e28af43
Reviewed-on: https://chromium-review.googlesource.com/898254
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/b879766de2fe6fcc9beb9dc76587a20fe2c9499d/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/b879766de2fe6fcc9beb9dc76587a20fe2c9499d/frontend/client/src/autotest/moblab/rpc/VersionInfo.java
[modify] https://crrev.com/b879766de2fe6fcc9beb9dc76587a20fe2c9499d/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/b879766de2fe6fcc9beb9dc76587a20fe2c9499d/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/427f50a81ba9587b947a7e3c54063207d2bbcb8c

commit 427f50a81ba9587b947a7e3c54063207d2bbcb8c
Author: Matt Mallett <mattmallett@chromium.org>
Date: Sat Feb 03 00:13:16 2018

[moblab] correctly display update progress on UI

Wait for the update engine to finish checking for an update before
returning from the RPC. Also improve messaging on the UI to make
update progress easy to follow.

BUG= chromium:613747 
TEST=local moblab tested by updating from R64-10176.62.0 to
R64010176.65.0

Change-Id: I16910cc1365dc65980e269da7bbcabc28e28af43
Reviewed-on: https://chromium-review.googlesource.com/898254
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit b879766de2fe6fcc9beb9dc76587a20fe2c9499d)
Reviewed-on: https://chromium-review.googlesource.com/900026
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/427f50a81ba9587b947a7e3c54063207d2bbcb8c/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/427f50a81ba9587b947a7e3c54063207d2bbcb8c/frontend/client/src/autotest/moblab/rpc/VersionInfo.java
[modify] https://crrev.com/427f50a81ba9587b947a7e3c54063207d2bbcb8c/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/427f50a81ba9587b947a7e3c54063207d2bbcb8c/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4955fa7407d1c9466af66e794545054ea2a4961d

commit 4955fa7407d1c9466af66e794545054ea2a4961d
Author: Matt Mallett <mattmallett@chromium.org>
Date: Sat Feb 03 00:13:19 2018

[moblab] correctly display update progress on UI

Wait for the update engine to finish checking for an update before
returning from the RPC. Also improve messaging on the UI to make
update progress easy to follow.

BUG= chromium:613747 
TEST=local moblab tested by updating from R64-10176.62.0 to
R64010176.65.0

Change-Id: I16910cc1365dc65980e269da7bbcabc28e28af43
Reviewed-on: https://chromium-review.googlesource.com/898254
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit b879766de2fe6fcc9beb9dc76587a20fe2c9499d)
Reviewed-on: https://chromium-review.googlesource.com/900025
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/4955fa7407d1c9466af66e794545054ea2a4961d/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/4955fa7407d1c9466af66e794545054ea2a4961d/frontend/client/src/autotest/moblab/rpc/VersionInfo.java
[modify] https://crrev.com/4955fa7407d1c9466af66e794545054ea2a4961d/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/4955fa7407d1c9466af66e794545054ea2a4961d/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java

Status: Fixed (was: Started)

Sign in to add a comment