New issue
Advanced search Search tips

Issue 613743 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Ability to annotate builder summary page

Project Member Reported by snanda@chromium.org, May 20 2016

Issue description

(I am not sure what the right component to file this feature request against is so I have speculatively added two components in the hopes that the folks who pay attention to those components can help route it appropriately)

Here's an example of the build summary page that I am talking about:
https://uberchromegw.corp.google.com/i/chromeos/builders/clapper-release

When builds fail, a set of folks (sheriffs, devs, infra folks) look at the build logs to understand why a build failed.  The sheriffs, gardeners, deputies are on a rotation duty.

Given the above, multiple folks may look at a given build failure.  Currently there doesn't seem to be an easy way to communicate to others why a particular build failed.  The feature request here is to add ability to annotate comments to build logs.

One possibility here may be to add an editable column to the builder summary page linked above.  This column can then be updated for each red build with comments such as "build failed due to out of space issue (crbug.com/...)" etc.  This way with a quick look we can figure out (a) if a build failure has been investigated, and (b) what the cause of the failure was to find patterns etc.
 
This would be very useful for the sheriff.  I now find myself wanting to do it all the time.  The alternative is to open a bug that points back to this, but it's much harder to find.

Comment 2 by estaab@chromium.org, May 23 2016

Components: Infra>Platform>Milo
Status: Available (was: Untriaged)
I like this idea. It's unlikely we'll be able to add this to buildbot unless added by someone outside of infra since it's in maintenance mode but we'll keep it in mind for luci, our next gen system (milo is the UI component).

Comment 3 by autumn@chromium.org, May 23 2016

Owner: akes...@chromium.org
Options: use build annotator OR ask Chrome Infra to change the waterfall. Aviv will comment further. 
Owner: dgarr...@chromium.org
Don, is this idea somehow incorporated in the UI roadmap, and should it be?
I'll add it as an optional feature, but probably not in the initial version.

Would Sheriff O Matic help with this at all?
Owner: leecy@chromium.org

Comment 7 by leecy@chromium.org, Sep 25 2017

I think this is sheriff-o-matic.

Comment 8 by leecy@chromium.org, Sep 25 2017

Owner: davidri...@chromium.org
Status: Fixed (was: Available)
In my opinion this should be done with sheriff-o-matic under the comment section of each alert.  If it's a more complicated failure that requires further action than an annotation, then open a bug and link the alert to the bug.

It's even more effective if the sheriffs group related failures together and label them but I've not had much luck with getting sheriffs to reliably adopt that workflow.  There's also some less than ideal behaviour when alerts are auto-resolved and the group becomes stale.

My long term goal is to replace the sheriff log by the SoM history.  Potentially the annotations that the deputies use as well, but that's further out.

I'm closing this issue but if this comment doesn't address the desired wishes, feel free to re-open and provide my details.

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 11 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment