New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613733 link

Starred by 1 user
Status: Verified
Owner:
dgarr...@chromium.org
Closed: May 2016
Cc:
akes...@chromium.org
█ josa...@chromium.org
█ bhthompson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Make $board-release build configurations reliably compatible with GCE

Project Member Reported by bhthompson@chromium.org, May 20 2016 
With the migration to GCE we now effectively have two types of release builders, leads and followers, where the lead build configuration gets VMTests. For the purpose of expanding the ability to run trybot jobs for release builds it would be convenient if the $board-release nomenclature was reliably functional on GCE. 

We could do something like have a $board-release-leader which would target the baremetal VMTest supporting configuration and $board-release which would target GCE. I think we could configure chromeos_config.py to generate both of these for all targets such that we could leverage either, but only have the appropriate builds marked important to get them on the official waterfall the way we want it. 

Thoughts?

Comment 1 by dgarr...@chromium.org, May 21 2016 

For a lot of goofy reasons, vmtests and hwtests can be defined differently for tryjobs from the main build config.

See hwtests_override vs vmtests_override.

I haven't, but can enable vmtests for tryjobs on all x86 release builders, both leader and follower.

Comment 2 by dgarr...@chromium.org, May 21 2016 

Eventually, I'd like to get vmtests to work on GCE instances, but I wasn't planning to start asking about that until after other issues with the new release builders settle down.

Comment 3 by bhthompson@chromium.org, May 23 2016 

SGTM, this is pretty low priority, having VMTests on GCE at some point makes this bug obsolete if you want to go that route, seems cleaner.
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2c93ff3d1c7b47599d9c5d51f2b7311d3c04ca11

commit 2c93ff3d1c7b47599d9c5d51f2b7311d3c04ca11
Author: Don Garrett <dgarrett@google.com>
Date: Mon May 23 23:31:03 2016

chromeos_config: Preserve release VMTests for tryjobs.

BUG= chromium:613733 
TEST=run_tests

Change-Id: I47595d61b15f90219ba3330325e7b615eeb81d21
Reviewed-on: https://chromium-review.googlesource.com/346801
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/2c93ff3d1c7b47599d9c5d51f2b7311d3c04ca11/cbuildbot/config_dump.json
[modify] https://crrev.com/2c93ff3d1c7b47599d9c5d51f2b7311d3c04ca11/cbuildbot/chromeos_config.py

Comment 5 by dgarr...@chromium.org, May 24 2016

Status: Fixed (was: Untriaged)

Comment 6 by patricia@chromium.org, Jul 1 2016

Labels: VerifyIn-53

Comment 7 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 8 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)
►

Sign in to add a comment