touch_updater: bad log output for Synaptics
Reported by
charliemooney@chromium.org,
May 20 2016
|
|||||||
Issue description2016-05-20T14:44:53.633116-07:00 NOTICE chromeos-synaptics-touch-firmware-update[1746]: error: No valid firmware for hid-06CB_1830 found. 2016-05-20T14:44:53.642036-07:00 NOTICE chromeos-synaptics-touch-firmware-update[1757]: Current product id : 1830 2016-05-20T14:44:53.648194-07:00 NOTICE chromeos-synaptics-touch-firmware-update[1760]: Updater product id : error: No valid firmware for hid-06CB 2016-05-20T14:44:53.652697-07:00 NOTICE chromeos-synaptics-touch-firmware-update[1765]: error: Touch firmware updater: Product ID mismatch! 2016-05-20T14:44:53.656411-07:00 NOTICE chromeos-touch-update[1768]: firmware update failed. This is pretty confusing. A couple of the error messages are clobbering eachother, so this could be made a lot easier to read
,
Jun 15 2016
,
Jun 17 2016
Shoot, turns out this caused a regression in the touch_updater scripts for Synaptics due to a bash vs sh mistake. One of the conditionals was evaluating to False accidentally, even when it should've been true. Reverting now. I'll submit a fixed patch later once everything's back into working order again.
,
Jun 20 2016
Patch is reverted in ToT
,
Jun 20 2016
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_updater/+/59f9479d0d46e408cb9a6c1be1046b1a76d02d13 commit 59f9479d0d46e408cb9a6c1be1046b1a76d02d13 Author: Charlie Mooney <charliemooney@chromium.org> Date: Tue Jun 21 17:01:22 2016 Make Synaptics update fail sooner if FW isnt found This is a second attempt at fixing the logs output on Synaptics touch FW updater. When a FW wasn't found on disk there was a lot of extra logs output that makes it hard to read. This CL makes the script fail out sooner, if no FW is found which makes the logs easier to read. This is essentially the same approach as the first fix (that got reverted) except that the if conditional has been reformatted to work with sh better. Previously a bash vs sh issue cause the conditional to be evaluated incorrectly. BUG= chromium:613719 TEST=This was the fix I found when debugging when the last version failed. The conditional seems to work correctly now Change-Id: Id1c687b559cba9081b3b0a0fdf102ad1352aedb1 Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/354135 Reviewed-by: Dennis Kempin <denniskempin@google.com> [modify] https://crrev.com/59f9479d0d46e408cb9a6c1be1046b1a76d02d13/scripts/chromeos-synaptics-touch-firmware-update.sh
,
Jun 21 2016
Okay, it should actually work this time (knock on wood)
,
Jul 1 2016
,
Aug 12 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 15 2016