New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613708 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

MD Settings: Drawer should hide after tapping menu item, in narrow mode

Project Member Reported by michae...@chromium.org, May 20 2016

Issue description

1. Shrink window to be in narrow mode
2. Tap the top-left menu icon
3. Choose a page or section (e.g. Advanced)

The drawer should close after 3, but it stays open.
 
Cc: tbuck...@chromium.org
Owner: bettes@chromium.org
Inbox's drawer never actually overlaps the page (instead the drawer basically pushes the page aside), so they don't have to handle this. They keep the drawer open until the user closes it via the menu button.

I don't think that's the right behavior for us, because there's not much need to keep our drawer open (it just isn't as useful as Inbox's). On the other hand, maybe we shouldn't support narrow mode at all? We could just force the window to have a certain minimum width and always show the drawer.
Status: Assigned (was: Untriaged)
We should close the sidenav when the user selects a section.

However, given the new sidenav structure, should we also close the sidenav when the user toggles "Advanced" or should we let them select a section?
Labels: Hotlist-MD-Settings-Navigation

Comment 4 by bettes@chromium.org, May 27 2016

Cc: -tbuck...@chromium.org bettes@chromium.org
Owner: tbuck...@chromium.org
I dont think this is an issue anymore. The new behavior for the sidenav is "hide-by-default." 

With that behavior, I think it's implied that the sidenav should close after a selection is made in the sidenav. 

Assigned back to Tom. 
Owner: bettes@chromium.org
We're all agreed that tapping an section in the sidenav should close the shelf.

The open question is what should happen when I tap "Advanced" in the sidenav. Options:
1) Expand/collapse the advanced sections in the sidenav/content area. Close the sidenav and scroll the content area to the "Advanced" header.
2) Expand/collapse the advanced sections in the sidenav/content area. Scroll the content area to the "Advanced" header. Keep the sidenav open.

Let's say I want to get to the Bluetooth section. With #2 I can tap the hamburger icon, then "Advanced" to exapand those sections, and finally "Bluetooth" to quickly jump to Bluetooth settings. With #1, I would tap the hamburger icon and "Advanced", then need to tap the hamburger icon and "Bluetooth".
To be clear, my preference is for #2 so that I have the option of quickly selecting an Advanced section from the sidenav.
Cc: tbuck...@chromium.org dpa...@chromium.org
Labels: -Pri-2 Pri-1
Owner: dschuyler@chromium.org
agree with tom, closing the menu when you open a sub-menu is frustrating. over to dave to implement or triage
Status: Started (was: Assigned)
Tom, Dan and I talked about this further in a meeting yesterday
(2016-06-21). There is a decision to be made about whether the 
content area should scroll while the drawer is open. Another 
point brought up is whether the expand/collapse in the side
nav should be independent of the advanced page in the content
area.
Cc: michae...@chromium.org
Owner: tbuck...@chromium.org
Owner: dschuyler@chromium.org
To clarify, the current proposal for clicking "Advanced" in the sidenav is:
* toggle the Advanced sections in both the sidenav and the content area
* keep the sidenav open
* either scroll to Advanced or don't scroll (up to you, we'll see how it feels once it's in Canary)

We should keep the expand/collapse in the sidenav tied to the content area for now.
-1 vote for scrolling the page when toggling Advanced in the side nav, it's surprising for things to move while the page is greyed out. I don't mind pushing it to Canary to get more opinions though.

More generally, IMO toggling Advanced in the side nav doesn't mean you want to see Advanced or scroll the page.

Example: After loading Settings, I look at the Appearance section and don't see how to set minimum font size. I open the menu... hey, maybe it's an advanced setting? I open Advanced, and decide none of those page titles sound right, so I click elsewhere to close the side nav.

Oops, now I'm looking at "Privacy and security"!

Either way, though, toggling advanced in the side nav *especially* should not close the sub-page you're in (but does).
Cc: dbeam@chromium.org
 Issue 622825  has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3cecfd7ecca13a3ed763c43b1a3680c9ca1c813

commit b3cecfd7ecca13a3ed763c43b1a3680c9ca1c813
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jun 23 20:46:45 2016

[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when the advanced page
is opened/closed in the side nav menu.

BUG= 613708 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2081393002
Cr-Commit-Position: refs/heads/master@{#401711}

[modify] https://crrev.com/b3cecfd7ecca13a3ed763c43b1a3680c9ca1c813/chrome/browser/resources/settings/settings_ui/settings_ui.js

This bug just needs a call made on "There is a 
decision to be made about whether the content 
area should scroll while the drawer is open."

If the content area should scroll when toggling
Advanced then this bug is finished (fixed). If
it should not scroll when toggling Advanced then
that needs to be done.

Please try out the scrolling of the content area,
which should be in any up to date build.

Sent email asking Tom/Alan to weigh in here.
After trying it out, I agree with Michael that we should not scroll when tapping "Advanced" in the sidenav.
This should be fixed once this lands:
https://codereview.chromium.org/2127723003/
FWIW, I agree that scrolling to advanced via sidenav isn't preferred. 
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bda0d49e07e6cb9457db06b05a09d5d14c806f6e

commit bda0d49e07e6cb9457db06b05a09d5d14c806f6e
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Jul 20 20:59:05 2016

[MD settings] do not scroll when toggling advanced menu

This CL removes the code that will scroll to the advanced content area
when toggling the advanced menu in the side nav.

BUG= 613708 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2127723003
Cr-Commit-Position: refs/heads/master@{#406667}

[modify] https://crrev.com/bda0d49e07e6cb9457db06b05a09d5d14c806f6e/chrome/browser/resources/settings/settings_main/settings_main.js

Status: Fixed (was: Started)

Sign in to add a comment