New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613700 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chrome crashes when user clicks the site info icon in menu because of Offline Pages

Project Member Reported by ian...@chromium.org, May 20 2016

Issue description

Observed in M52 trunk:

I    5.454s Main  [FATAL:jni_android.cc(162)] Failed to find method onResult (Lorg/chromium/chrome/browser/offlinepages/@Nullable;)V
I    5.454s Main  
I    5.454s Main  Stack Trace:
I    5.454s Main    RELADDR   FUNCTION                                               FILE:LINE
I    5.455s Main    0007ee3b  ~LogMessage                                            /usr/local/google/code/clankium/src/base/logging.cc:524
I    5.455s Main    00064d13  Get<base::android::MethodID::Type::TYPE_INSTANCE>      /usr/local/google/code/clankium/src/base/android/jni_android.cc:162
I    5.455s Main    00064d67  LazyGet<base::android::MethodID::Type::TYPE_INSTANCE>  /usr/local/google/code/clankium/src/base/android/jni_android.cc:183
I    5.455s Main  
I    5.455s Main  Java stderr from crashing pid (may identify underlying Java exception):
I    5.455s Main    at android.app.ActivityThread.main(ActivityThread.java:5422)
I    5.455s Main    at java.lang.reflect.Method.invoke(Native Method)
I    5.455s Main    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
I    5.455s Main    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
I    5.455s Main  java.lang.NoSuchMethodError: no non-static method "Lorg/chromium/chrome/browser/offlinepages/OfflinePageBridge$SingleOfflinePageItemCallback;.onResult(Lorg/chromium/chrome/browser/offlinepages/@Nullable;)V"
I    5.455s Main    at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
I    5.455s Main    at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:39)
I    5.455s Main    at android.os.Handler.dispatchMessage(Handler.java:102)
I    5.455s Main    at android.os.Looper.loop(Looper.java:148)
I    5.455s Main    at android.app.ActivityThread.main(ActivityThread.java:5422)
I    5.456s Main    at java.lang.reflect.Method.invoke(Native Method)
I    5.456s Main    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
I    5.456s Main    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)



FUNCTION                                                                                                                                                                               FILE:LINE
I    5.457s Main    00042374  tgkill+12                                                                                                                                                                              /system/lib/libc.so
I    5.457s Main    0003ff81  pthread_kill+32                                                                                                                                                                        /system/lib/libc.so
I    5.457s Main    0001c73f  raise+10                                                                                                                                                                               /system/lib/libc.so
I    5.457s Main    000198f1  __libc_android_abort+34                                                                                                                                                                /system/lib/libc.so
I    5.457s Main    000174b0  abort+4                                                                                                                                                                                /system/lib/libc.so
I    5.457s Main    v------>  DebugBreak                                                                                                                                                                             /usr/local/google/code/clankium/src/base/debug/debugger_posix.cc:219
I    5.457s Main    0006ea35  BreakDebugger                                                                                                                                                                          /usr/local/google/code/clankium/src/base/debug/debugger_posix.cc:249
I    5.457s Main    0007f041  ~LogMessage                                                                                                                                                                            /usr/local/google/code/clankium/src/base/logging.cc:740
I    5.457s Main    00064d11  Get<base::android::MethodID::Type::TYPE_INSTANCE>                                                                                                                                      /usr/local/google/code/clankium/src/base/android/jni_android.cc:162
I    5.458s Main    00064d65  LazyGet<base::android::MethodID::Type::TYPE_INSTANCE>                                                                                                                                  /usr/local/google/code/clankium/src/base/android/jni_android.cc:183
I    5.458s Main    v------>  Java_SingleOfflinePageItemCallback_onResult                                                                                                                                            /usr/local/google/code/clankium/src/out/Debug/gen/chrome/browser/jni_headers/chrome/jni/OfflinePageBridge_jni.h:378
I    5.458s Main    0035cb21  SingleOfflinePageItemCallback                                                                                                                                                          /usr/local/google/code/clankium/src/chrome/browser/android/offline_pages/offline_page_bridge.cc:131
I    5.458s Main    v------>  Run                                                                                                                                                                                    /usr/local/google/code/clankium/src/base/callback.h:397
I    5.458s Main    00918f85  GetPageByOfflineURLWhenLoadDone                                                                                                                                                        /usr/local/google/code/clankium/src/components/offline_pages/offline_page_model.cc:438
I    5.458s Main    0035e07b  Run                                                                                                                                                                                    /usr/local/google/code/clankium/src/base/bind_internal.h:362
I    5.458s Main    v------>  Run                                                                                                                                                                                    /usr/local/google/code/clankium/src/base/callback.h:397
I    5.458s Main    009199ad  OnLoadDone                                                                                                                                                                             /usr/local/google/code/clankium/src/components/offline_pages/offline_page_model.cc:628
I    5.458s Main    00869de9  Run                                                                                                                                                                                    /usr/local/google/code/clankium/src/base/bind_internal.h:362
I    5.458s Main    v------>  Run                                                                                                                                                                                    /usr/local/google/code/clankium/src/base/callback.h:397
I    5.458s Main    v------>  MakeItSo<const offline_pages::OfflinePageMetadataStore::LoadStatus &, const std::__1::vector<offline_pages::OfflinePageItem, std::__1::allocator<offline_pages::OfflinePageItem> > &>  /usr/local/google/code/clankium/src/base/bind_internal.h:311
I    5.458s Main    0091725d  Run                                                                                                                                                                                    /usr/local/google/code/clankium/src/base/bind_internal.h:362
I    5.459s Main    v------>  Run                                                                                                                                                                                    /usr/local/google/code/clankium/src/base/callback.h:397
I    5.459s Main    0006f195  RunTask                                                                                                                                                                                /usr/local/google/code/clankium/src/base/debug/task_annotator.cc:51
I    5.459s Main    00084c09  RunTask                                                                                                                                                                                /usr/local/google/code/clankium/src/base/message_loop/message_loop.cc:478
I    5.459s Main    00084da3  DeferOrRunPendingTask                                                                                                                                                                  /usr/local/google/code/clankium/src/base/message_loop/message_loop.cc:487
I    5.459s Main    00084ef9  DoWork                                                                                                                                                                                 /usr/local/google/code/clankium/src/base/message_loop/message_loop.cc:604
I    5.459s Main    v------>  DoRunLoopOnce                                                                                                                                                                          /usr/local/google/code/clankium/src/base/message_loop/message_pump_android.cc:37
I    5.459s Main    00085f83  Java_org_chromium_base_SystemMessageHandler_nativeDoRunLoopOnce                                                                                                                        /usr/local/google/code/clankium/src/out/Debug/gen/base/base_jni_headers/base/jni/SystemMessageHandler_jni.h:41
I    5.459s Main    0001b405  offset 0x2b000                                                                                                                                                                         /data/data/com.google.android.apps.chrome/incremental-install-files/optimized-dexes/base.base_java.dex.dex
I    5.459s Main  
I    5.459s Main  -----------------------------------------------------
I    5.459s Main  
I    5.460s Main  [FATAL:jni_android.cc(162)] Failed to find method onResult (Lorg/chromium/chrome/browser/offlinepages/@Nullable;)V
I    5.460s Main  
I    5.460s Main  Stack Trace:
I    5.460s Main    RELADDR   FUNCTION            


 
Cc: chili@chromium.org
Components: UI>Browser>Offline
Labels: -Pri-3 Pri-1
100% reliable repro; click on the offline bolt icon while viewing an offline page.
Project Member

Comment 3 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c61217944d70f81ef03b7921ed02624038ca69e8

commit c61217944d70f81ef03b7921ed02624038ca69e8
Author: fgorski <fgorski@chromium.org>
Date: Fri May 20 23:38:14 2016

[Offline pages] Fixing website settings crash

* Removing annotation that prevents jni from finding the method.

BUG= 613700 

Review-Url: https://codereview.chromium.org/2003673003
Cr-Commit-Position: refs/heads/master@{#395204}

[modify] https://crrev.com/c61217944d70f81ef03b7921ed02624038ca69e8/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 613066 has been merged into this issue.
Labels: -ReleaseBlock-Stable Merge-Approved-52 ReleaseBlock-Dev
We need this for M52 branch, merge approved for branch 2743.
Project Member

Comment 6 by bugdroid1@chromium.org, May 23 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2efec90ab3e72c7f448d5a8897c30dca97911df4

commit 2efec90ab3e72c7f448d5a8897c30dca97911df4
Author: Filip Gorski <fgorski@chromium.org>
Date: Mon May 23 16:27:44 2016

[Offline pages] Fixing website settings crash

* Removing annotation that prevents jni from finding the method.

BUG= 613700 

Review-Url: https://codereview.chromium.org/2003673003
Cr-Commit-Position: refs/heads/master@{#395204}
(cherry picked from commit c61217944d70f81ef03b7921ed02624038ca69e8)

Review URL: https://codereview.chromium.org/2006753002 .

Cr-Commit-Position: refs/branch-heads/2743@{#5}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/2efec90ab3e72c7f448d5a8897c30dca97911df4/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified Fixed in 54.0.2827.0
Cc: yfried...@chromium.org
Status: Assigned (was: Verified)
Seeing a seeming up-tick of this error (possibly caused through some new flow) in 64: https://listnr.corp.google.com/product/282/crash/35748741?status=1,3&dateRange=30
This is a new crash. Could you please open a new bug and assign to me? Thanks.
Status: Fixed (was: Assigned)
Sure, filed https://bugs.chromium.org/p/chromium/issues/detail?id=807411

Sign in to add a comment