Issue 613699 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	philipchen@chromium.org
Closed:	Jun 2016
Cc:	█ sha...@chromium.org █ shchen@chromium.org adurbin@chromium.org
Components:	OS>Firmware>EC
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

ec: Put RTC / RTC wake code behind a config option

Project Member Reported by sha...@chromium.org, May 20 2016

Issue description

We don't use RTC host commands or RTC wake on most systems. We can put this functionality behind a CONFIG such as CONFIG_RTC or CONFIG_RTC_WAKE.

.. and don't forget to put the interrupt handling __gpio_rtc_interrupt() behind the new CONFIG as well.

Comment 1 by sha...@chromium.org, Jun 16 2016

Owner: philipchen@chromium.org

Comment 2 by sha...@chromium.org, Jun 22 2016

Let's put this all behind CONFIG_RTC.

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/0cab97574be2a2d1be35af3985425f898df6a731

commit 0cab97574be2a2d1be35af3985425f898df6a731
Author: philipchen <philipchen@google.com>
Date: Sat Jun 25 22:32:11 2016

Cleanup: gate RTC console/host command behind new config options

Put RTC code supporting console/host command behind
new flags 'CONFIG_CMD_RTC'/'CONFIG_HOSTCMD_RTC'

BUG= chromium:613699 
TEST=make buildall
BRANCH=master

Change-Id: Ida52265d124978f48bd6ca522be3badee9f99588
Reviewed-on: https://chromium-review.googlesource.com/356206
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>

[modify] https://crrev.com/0cab97574be2a2d1be35af3985425f898df6a731/chip/npcx/system.c
[modify] https://crrev.com/0cab97574be2a2d1be35af3985425f898df6a731/board/kevin/board.h
[modify] https://crrev.com/0cab97574be2a2d1be35af3985425f898df6a731/chip/lm4/system.c
[modify] https://crrev.com/0cab97574be2a2d1be35af3985425f898df6a731/chip/npcx/gpio.c
[modify] https://crrev.com/0cab97574be2a2d1be35af3985425f898df6a731/include/config.h