New issue
Advanced search Search tips

Issue 613683 link

Starred by 1 user
Status: Fixed
Owner:
glevin@chromium.org
Closed: May 2016
Cc:
js...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 475351



Sign in to add a comment

Native digits are not used in several browser warnings and cookie counts

Project Member Reported by glevin@chromium.org, May 20 2016 
Version: 52.0.2724.0

I'm using this issue to report 3 minor instances with simple fixes where numbers need to be properly localized.

What steps will reproduce the problem?
(1) Set language to one with non-Arabic numerals (e.g., Bengali, Marathi, Persian)
(2a) Right-click on bookmark folder w/15+ bookmarks, select "Open all bookmarks"; a dialog will appear with "Are you sure you want to open X tabs?"
(2b) Right-click on webpage / lock icon in omnibox; see "Cookies  X from this site, X from other sites"
(2c) Require a critical restart on Win browser, get dialog with "Google Chrome will restart in X seconds." (not exactly sure how to cause this)

What is the expected output?  What do you see instead?
In each case, X should use localized numerals.  Instead, numbers are always in Arabic (see screenshots).
i18n_bookmarks.png
7.0 KB View Download
i18n_cookies.png
16.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6ffe53e5189609c8d93784c31ce347d63eed693

commit e6ffe53e5189609c8d93784c31ce347d63eed693
Author: glevin <glevin@chromium.org>
Date: Fri May 27 21:08:12 2016

i18n of several browser messages

BUG= 613683 
TEST=Switch to language with non-Arabic numerals (e.g., Persian), view
the various messages described in 613683, check that numbers
are rendered with non-Arabic numerals.

Review-Url: https://codereview.chromium.org/2002673003
Cr-Commit-Position: refs/heads/master@{#396558}

[modify] https://crrev.com/e6ffe53e5189609c8d93784c31ce347d63eed693/chrome/app/chromium_strings.grd
[modify] https://crrev.com/e6ffe53e5189609c8d93784c31ce347d63eed693/chrome/app/generated_resources.grd
[modify] https://crrev.com/e6ffe53e5189609c8d93784c31ce347d63eed693/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/e6ffe53e5189609c8d93784c31ce347d63eed693/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
[modify] https://crrev.com/e6ffe53e5189609c8d93784c31ce347d63eed693/chrome/browser/ui/views/critical_notification_bubble_view.cc
[modify] https://crrev.com/e6ffe53e5189609c8d93784c31ce347d63eed693/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/e6ffe53e5189609c8d93784c31ce347d63eed693/chrome/browser/ui/website_settings/website_settings.cc
[modify] https://crrev.com/e6ffe53e5189609c8d93784c31ce347d63eed693/chrome/browser/ui/website_settings/website_settings_ui.h

Comment 2 by glevin@chromium.org, May 31 2016

Status: Fixed (was: Started)
Note that the "Open all bookmarks" warning is being handled in  Issue 613331  (https://codereview.chromium.org/2002783002), and has not been fixed here.
►

Sign in to add a comment