New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613680 link

Starred by 1 user
Status: Fixed
Owner:
█ jessi...@chromium.org
Email to this user bounced
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix logic for using an arg to set metrics reported os for blimp

Reported by jessi...@chromium.org, May 20 2016 
Metrics uploads from blimp engine are including OS = Linux in the System Proto instead of the desired "Blimp".

This is because the defines isn't getting set in BUILD.gn until after metrics_log.cc is built.

This change will ensure the blimp engine is uploading logs with the desired system information so they can be separate from other linux logs.
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d599415d4e9fbb458090f9cd544a17dcd0a90a6c

commit d599415d4e9fbb458090f9cd544a17dcd0a90a6c
Author: jessicag <jessicag@chromium.org>
Date: Fri May 20 21:27:31 2016

Fix for setting the os listed in metrics reporting for Blimp.

Metrics uploads from blimp engine are including OS = Linux in the System Proto instead of the desired "Blimp".

This is because the defines isn't getting set in BUILD.gn until after metrics_log.cc is built.

This change will ensure the blimp engine is uploading logs with the desired system information so they can be separate from other linux metrics logs.

BUG= 613680 

Review-Url: https://codereview.chromium.org/2005513002
Cr-Commit-Position: refs/heads/master@{#395170}

[modify] https://crrev.com/d599415d4e9fbb458090f9cd544a17dcd0a90a6c/components/metrics/BUILD.gn
[modify] https://crrev.com/d599415d4e9fbb458090f9cd544a17dcd0a90a6c/components/metrics/metrics_log.cc

Comment 2 by jessi...@chromium.org, May 20 2016

Status: Fixed (was: Assigned)

Comment 3 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment