New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613668 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 612874



Sign in to add a comment

[ChromeOS] scrollbar is broken

Project Member Reported by osh...@chromium.org, May 20 2016

Issue description

Observed in ToT (#395099)

bisecting
 
Screenshot 2016-05-20 at 11.51.26 AM.png
9.0 KB View Download

Comment 1 by osh...@chromium.org, May 20 2016

Cc: -bsep@chromium.org
Labels: -Needs-Bisect
Owner: bsep@chromium.org
Status: Assigned (was: Started)
bsep@, looks like your CL https://codereview.chromium.org/1911973002 is culprit. Can you look into it?

Comment 2 by bsep@chromium.org, May 20 2016

Blocking: 612874
Cc: durga.behera@chromium.org ymalik@chromium.org pucchakayala@chromium.org songsuk@chromium.org ajha@chromium.org bsep@chromium.org kavvaru@chromium.org
 Issue 614620  has been merged into this issue.
Labels: M-53

Comment 6 by bsep@chromium.org, May 25 2016

Status: Fixed (was: Assigned)

Comment 7 by osh...@chromium.org, May 27 2016

Labels: -M-53 Merge-Request-52 M-52
Status: Started (was: Fixed)
this needs to be merged to 52.

Comment 8 by tin...@google.com, May 27 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 9 by sheriffbot@chromium.org, May 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 3 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: gkihumba@chromium.org
Labels: -Pri-3 Pri-1
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 6 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee145b086b49d2cf71b915f5dc6e6e806edd613b

commit ee145b086b49d2cf71b915f5dc6e6e806edd613b
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Jun 06 20:15:53 2016

Fix scrollbar buttons on ChromeOS.

Scrollbar buttons aren't supposed to draw on ChromeOS, so they need to
return a size of 0.

BUG= 613668 

Review-Url: https://codereview.chromium.org/2006643004
Cr-Commit-Position: refs/heads/master@{#396012}
(cherry picked from commit 57decb6dda19498ceec3b3cbdb9d6c6fd0fed001)

Review URL: https://codereview.chromium.org/2042023002 .

Cr-Commit-Position: refs/branch-heads/2743@{#247}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/ee145b086b49d2cf71b915f5dc6e6e806edd613b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp
[modify] https://crrev.com/ee145b086b49d2cf71b915f5dc6e6e806edd613b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.h
[modify] https://crrev.com/ee145b086b49d2cf71b915f5dc6e6e806edd613b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAuraTest.cpp

Comment 14 by bsep@chromium.org, Jun 6 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Chrome OS 53.0.2764.0/8452.0.0 

Sign in to add a comment