New issue
Advanced search Search tips

Issue 613666 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Autofill: AutofillType not set properly when dealing with password types.

Project Member Reported by ma...@chromium.org, May 20 2016

Issue description

See FormStructureTest.ParseQueryResponseAuthorDefinedTypes

The inferred AutofillType is UNKNOWN_TYPE when the server_type (or the autocomplete attribute?) is password-related. Not having a proper AutofillType could lead to problems in other logic (https://codereview.chromium.org/2003563003 fixes an issue where autofill would be affected when an autocomplete type such as "new-password" was specified).

Please have a look and see if there is a user impact.

Easily reproducible with such a form and enabling chrome://flags#show-autofill-type-predictions:

<form name="np" id="np1" action="https://example.com" method="post">
  Name: <input type="text" name="firstname" /><br />
  Phone: <input type="text" name="phone" /><br />
  Password: <input type="password" name="password" autocomplete="password"/><br />
  <input type="reset" value="Reset" />
  <input type="submit" value="Submit" />
  </form>
 

Comment 1 by ma...@chromium.org, May 20 2016

^^ In the above example, it should have read autocomplete="new-password" instead of "password". Thanks.
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 9 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Assigned)
Status: Assigned (was: Untriaged)
dvadym@, please close the bug if irrelevant.

Sign in to add a comment