mus::ws::DisplayManager can already provide the bounds? Maybe use that for now?

Longer term: I'd really like to see us refactor ash/display into mash, sysui and mus specific parts.

I think we should push the necessary information to Display. Then DesktopBackgroundController::GetMaxDisplaySizeInNative won't need to use DisplayManager.

Oshima, wdyt of adding bounds_in_pixels or bounds_in_native to Display? Both chromeos and windows have a need for it.

sgtm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d780247a697f62d0e27a6eb5dfb309807f40881

commit 4d780247a697f62d0e27a6eb5dfb309807f40881
Author: msw <msw@chromium.org>
Date: Fri Jun 03 17:19:37 2016

Hook up Chrome's wallpaper picker for mash.

Add wallpaper.mojom for ash_sysui<->chrome interaction.
Implement WallpaperController in ash_sysui UserWallpaperDelegateMus.
Implement minimal new ChromeWallpaperHelper in chrome.
(lets chrome set mash wallpaper, mash trigger chrome wallpaper picker)

Add SetWallpaper helper for WallpaperManager to work in mash too.
Remove sysui_application.cc debug wallpaper initialization.
Bail early on WindowStateManager::[Minimize|Restore]InactiveWindows.
Workaround DesktopBackgroundController shell usage.

TODO: Fix picker regression from codereview.chromium.org/2009853002
TODO: Fix wallpaper_manager.cc's other Shell::GetInstance uses.
TODO: Fix DesktopBackgroundController display size checks in Mash.
TODO: Implement window hide/restore for wallpaper picker.
TODO: Implement missing UserWallpaperDelegateMus functionality.

BUG= 557405 , 613657 , 613707 
TEST=Chrome OS wallpaper works with or without --mash flag; right click mash desktop -> "Set wallpaper..." works.
R=jamescook@chromium.org,sky@chromium.org,dcheng@chromium.org

Review-Url: https://codereview.chromium.org/1984433002
Cr-Commit-Position: refs/heads/master@{#397739}

[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/desktop_background/desktop_background_controller.cc
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/BUILD.gn
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/DEPS
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/manifest.json
[add] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/public/interfaces/BUILD.gn
[add] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/public/interfaces/OWNERS
[add] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/shelf_delegate_mus.cc
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/shelf_delegate_mus.h
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/sysui_application.cc
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/sysui_application.h
[add] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/user_wallpaper_delegate_mus.cc
[add] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/ash/sysui/user_wallpaper_delegate_mus.h
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/app/mojo/chrome_manifest.json
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/chromeos/chrome_interface_factory.cc
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/chromeos/chrome_interface_factory.h
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/ui/ash/DEPS
[add] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/ui/ash/chrome_wallpaper_manager.cc
[add] https://crrev.com/4d780247a697f62d0e27a6eb5dfb309807f40881/chrome/browser/ui/ash/chrome_wallpaper_manager.h

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Migrating Proj-Mustash-Mus to components Internals>Services>WindowService and Internals>Services>Ash

Mike, DesktopBackgroundController no longer exists. Is this bug still relevant? If so, could you update accordingly. If not, please close.

It has been renamed WallpaperController, the TODO is still there:
https://cs.chromium.org/chromium/src/ash/wallpaper/wallpaper_controller.cc?rcl=68fd8637928617b3d5a35c0c65ad7b6a8c71720e&l=518
The Shell should exist there in Mash now, we can probably just cleanup the conditionals.
(the exception to that might be some unit tests, if so we can revise the comments)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f7bb1dc11771a4d2ce63f26264377da0bd93a1e

commit 4f7bb1dc11771a4d2ce63f26264377da0bd93a1e
Author: Mike Wasserman <msw@chromium.org>
Date: Tue Aug 21 19:39:06 2018

Cleanup obsolete WallpaperController Mash conditionals.

Bug:  613657 ,  622480 
Change-Id: Ief1471c2f5830a99f9e650d7447b821c155e4a49
Reviewed-on: https://chromium-review.googlesource.com/1183900
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584882}
[modify] https://crrev.com/4f7bb1dc11771a4d2ce63f26264377da0bd93a1e/ash/wallpaper/wallpaper_controller.cc