Really files like:
proxy_script_decider.cc
proxy_script_fetcher.c
Should be using the terminology "PAC file" rather than "Proxy Script".
Both in the file name, and in the class names.
They all deal directly with PAC script files.
A "proxy script" by contrast is not a clear concept.
Should it be "PAC" or "PAC script", rather than "PAC file"? "File" has a bit of a "file://" implication, and there may not be a matching "physical" (magnetic / electric?) file anywhere on disk. Doesn't really matter, I suppose. I agree that proxy_script is confusing, having been confused by it, and other proxy-related names in the code, in the past.
I am in the habit of calling it a "PAC script", so certainly no strong objection on using that terminology.
However, I believe it is more commonly referred to as a PAC file. For instance if one considers Wikipedia as being authoritative on the subject [1], or other random web searches.
Honestly either "PAC script" or "PAC file" for the nomenclature is an improvement. I am keen on clarifying our terminology in this area (see also https://bugs.chromium.org/p/chromium/issues/detail?id=613632)
From a layering perspective I could make the argument that the fact that a PAC file is a "script" is an implementation detail for the resolver, and not one that we need to surface at these higher layers.
But obviously I am also fond of "PAC script" since that is how I personally tend to refer to these, and I find the emphasis on "script" tends to be a good reminder for other when discussing this (a reminder that these things are dynamic in nature, and not just a static configuration).
Meh.
[1] https://en.wikipedia.org/wiki/Proxy_auto-config
You make a good point.
My concern here is really that I tend to read "PAC" as "Proxy Auto Config"...Which means something that automatically configures a proxy. Adding "script" makes it clearer to me that we mean the [semi-]standard PAC script thing, as opposed to generic automatic proxy configuration (Yes, PAC is technically enough to know that, but as something not familiar with proxy configuration coming at the code...).
Comment 1 by mmenke@chromium.org
, Jun 2 2016