New issue
Advanced search Search tips

Issue 613642 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

CQ should give better error message when LGTMs are missing

Project Member Reported by ojan@chromium.org, May 20 2016

Issue description

See the failed commit on https://codereview.chromium.org/1992003002. I had to go look at the log to see that I was missing OWNERS LGTM. Can we special case that and show it in the reitveld comment directly? It's so common that this will save people a lot of time.

Also, I think this is a regression. Didn't it used to do this.
 

Comment 1 by estaab@chromium.org, May 20 2016

Cc: estaab@chromium.org
Status: Available (was: Untriaged)
Earlier CQ used to run presubmit on the CQ host. This was unsafe, which is why we moved all presubmits to the Buildbot. Retrieving this information, however, would require talking to Buildbot master directly (to get the logs). Not sure if this is a good idea, but it's certainly doable.
From UX PoV, I agree.
Now, given current CQ design, CQ has no idea about OWNERS files. CQ sees this is a failure of a presubmit builder, and has no visibility in the actual failure reason.

There is a hacky solution polling for buildbot/LogDog logs of presubmit builder, and then parsing them for OWNERS check failure. But, as one of the owners of CQ code, I would vote against this approach on cost-benefit basis.

Another solution is splitting owners check into another builder whose name would be owners_lgtm_presubmit, and hence suggest easy fix.

Or we can change interface of CQ <-> buildbucket <-> recipe run so that CQ gets aware of the cause of failure, though CQ code would still be hacky.
I wonder if it could fall into Tricorder sort of things?
Labels: -Type-Bug Type-Feature
Quite possibly actually just so as to make them visible. Or a Gerrit plugin once we move it all to Gerrit.
Components: -Infra>CQ Infra>Platform>CQdaemon

Comment 7 by efoo@chromium.org, Aug 31 2017

Components: Infra>Platform>CQ

Comment 8 by efoo@chromium.org, Aug 31 2017

Components: -Infra>Platform>CQdaemon
Components: -Infra>Platform>CQ Infra>Codereview>Gerrit
There is no Gerrit OWNERS plugin which can provide the requested information about missing approvals directly in Gerrit UI. I'm not sure, however, if this plugin works with PolyGerrit UI.

Sign in to add a comment