New issue
Advanced search Search tips

Issue 613641 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocked on:
issue 617782
issue 620145
issue 621991
issue 622093
issue 622532



Sign in to add a comment

Make all try builders on swarming pass for good CLs

Project Member Reported by no...@chromium.org, May 20 2016

Issue description

Currently infra try builders are replicated to Swarming:
https://chromium.googlesource.com/infra/infra/+/infra/config/cr-buildbucket.cfg#24
and scheduled by CQ as experimental builders.

Make them pass and then replace buildbot builders with swarming ones.
 

Comment 1 by no...@chromium.org, May 20 2016

Labels: luci
Project Member

Comment 2 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/d9934015cab19dc4f1e31906b6caaadf4d392942

commit d9934015cab19dc4f1e31906b6caaadf4d392942
Author: nodir <nodir@chromium.org>
Date: Fri May 27 18:53:21 2016

bot_update: remove activation check for non-masters

Activation check was useful when transitioning buildbot masters to
bot_update. It is not needed in buidlbotless world. Disable the check
if --master is not passed, which is the case in buildbotless world

R=hinoka@chromium.org, iannucci@chromium.org
BUG= 613641 

Review-Url: https://codereview.chromium.org/2000403004

[modify] https://crrev.com/d9934015cab19dc4f1e31906b6caaadf4d392942/scripts/slave/bot_update.py

Comment 3 by no...@chromium.org, May 27 2016

Status: Fixed (was: Assigned)

Comment 4 by no...@chromium.org, May 27 2016

Status: Started (was: Fixed)

Comment 5 by no...@chromium.org, May 27 2016

bot_update still fails for infra.git builders
Project Member

Comment 6 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/7ae58956f6a27ffb184cd61ac079fdf3b49eb187

commit 7ae58956f6a27ffb184cd61ac079fdf3b49eb187
Author: nodir@chromium.org <nodir@chromium.org>
Date: Fri May 27 22:12:22 2016

bot_update: remove activation check for non-masters

Cherry-pick https://codereview.chromium.org/2000403004/ to depot_tools's
bot_update.py

R=hinoka@chromium.org
BUG= 613641 

Review-Url: https://codereview.chromium.org/2022453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300670 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/7ae58956f6a27ffb184cd61ac079fdf3b49eb187/recipe_modules/bot_update/resources/bot_update.py

Project Member

Comment 7 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/4670ab0c31fa439d90b8734d2704b03e18b3a9c6

commit 4670ab0c31fa439d90b8734d2704b03e18b3a9c6
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri May 27 22:25:38 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/7ae58956f6a27ffb184cd61ac079fdf3b49eb187 bot_update: remove activation check for non-masters (nodir@chromium.org)

R=nodir@chromium.org,hinoka@chromium.org
BUG= 613641 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2017233003

[modify] https://crrev.com/4670ab0c31fa439d90b8734d2704b03e18b3a9c6/infra/config/recipes.cfg

Comment 8 by no...@chromium.org, May 27 2016

Status: Fixed (was: Started)

Comment 9 by no...@chromium.org, Jun 14 2016

Blockedon: 617782 620145
Cc: martiniss@chromium.org
Owner: ----
Status: Available (was: Fixed)
Reviving this bug because it is not fixed.

To verify it is fixed we need a script that fetches all builds starting from certain date from buildbucket
https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.search?bucket=master.tryserver.infra&max_builds=100&_h=1&
groups them by "buildset" tag, and matches those that run on Swarming (have " (Swarming)" suffix) with those that run on Buildbot (do not have the suffix) ane verify that they have same results.

The script can also print percentage of build pairs that have different results. We will work till this percentage is 0.

Comment 10 by no...@chromium.org, Jun 15 2016

Cc: hinoka@chromium.org
hinoka was curious about this too
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 17 2016

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 17 2016

Comment 13 by no...@chromium.org, Jun 21 2016

Blockedon: 621991

Comment 14 by no...@chromium.org, Jun 21 2016

Owner: no...@chromium.org
Status: Started (was: Available)

Comment 15 by no...@chromium.org, Jun 21 2016

Blockedon: 622093

Comment 16 by no...@chromium.org, Jun 23 2016

Blockedon: 622532

Comment 17 by no...@chromium.org, Jun 23 2016

Components: -Infra>Platform>Buildbucket Infra>Platform>Buildbucket>Swarmbucket
Status: Assigned (was: Started)
Status: Started (was: Assigned)
Labels: -M-53 M-54
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 19 2016

Comment 23 by no...@chromium.org, Jul 20 2016

Status: Fixed (was: Started)
Components: Infra>Platform>Buildbucket

Sign in to add a comment