New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613640 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 613621



Sign in to add a comment

Rename ProxyService::PacRequest --> ProxyService::Request

Project Member Reported by eroman@chromium.org, May 20 2016

Issue description

There is a TODO for that:

https://code.google.com/p/chromium/codesearch#chromium/src/net/proxy/proxy_service.h&q=proxy_service.h&sq=package:chromium&type=cs&l=108

The problem with the name PacRequest is it assumes that the asynchronous proxy resolution method is PAC.

While in practice this is true, it is a layering issue.

From the perspective of this interface the abstraction is proxy resolution, and Pac is just  implementation detail.
 

Comment 1 by eroman@chromium.org, May 20 2016

Same thing with the method:
  void CancelPacRequest(PacRequest* pac_request);

Should be:
  void CancelRequest(Request* request);

Although really the method shouldn't exist at all per  issue 478934 .
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c

commit 00e124d42c25bc08dbc7b5ec76efeec5ce105c6c
Author: Lily Houghton <lilyhoughton@chromium.org>
Date: Fri Jan 12 21:40:39 2018

Rename net::Proxy::PacRequest to net::Proxy::Request

TBR=raymes@chromium.org
TBR=dimich@chromium.org
TBR=yhirano@chromium.org
TBR=boliu@chromium.org

Bug:  613640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0841e8cd01a1eb970327a8a6247efac20ba734eb
Reviewed-on: https://chromium-review.googlesource.com/847460
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529071}
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/content/browser/renderer_host/pepper/pepper_network_proxy_host.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/content/browser/renderer_host/pepper/pepper_network_proxy_host.h
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/content/browser/resolve_proxy_msg_helper.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/content/browser/resolve_proxy_msg_helper.h
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/content/network/network_context_unittest.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/google_apis/gcm/engine/connection_factory_impl.h
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/net/http/http_stream_factory_impl_job_controller.h
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/net/proxy/proxy_service.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/net/proxy/proxy_service.h
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/net/url_request/url_request_ftp_job.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/net/url_request/url_request_ftp_job.h
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/services/network/public/cpp/proxy_resolving_client_socket.cc
[modify] https://crrev.com/00e124d42c25bc08dbc7b5ec76efeec5ce105c6c/services/network/public/cpp/proxy_resolving_client_socket.h

Owner: lilyhoughton@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment