New issue
Advanced search Search tips

Issue 613638 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 577170



Sign in to add a comment

Enable bluetooth chooser for Chrome Apps on Mac

Project Member Reported by juncai@chromium.org, May 20 2016

Issue description

As  bug 577170  described, a chooser dialog needs to be implemented on Chrome Apps so that WebBluetooth API can be used there. Since the chooser UI implementation is different for Mac and non-Mac, this issue tracks the chooser UI implementation on Mac.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7

commit 17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7
Author: juncai <juncai@chromium.org>
Date: Thu Jun 02 06:45:50 2016

Implement bluetooth chooser for Chrome Apps on Mac

This is the part 3 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

This CL implements the chooser UI for Bluetooth from Apps on Mac.
There will be different CLs for non-Mac since the chooser UI is
different.

BUG= 613638 ,  577170 

Review-Url: https://codereview.chromium.org/2005443002
Cr-Commit-Position: refs/heads/master@{#397320}

[add] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/extensions/chrome_extension_chooser_dialog.h
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/extensions/chrome_extensions_browser_client.h
[add] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.cc
[add] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h
[add] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h
[add] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm
[add] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
[add] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
[add] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/chrome_browser_extensions.gypi
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/extensions/browser/extensions_browser_client.cc
[modify] https://crrev.com/17fc8532d48139d6bb4386cc6aa6a4beb4bab5e7/extensions/browser/extensions_browser_client.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10f34889bd88754fcb98828e147730503e9b705b

commit 10f34889bd88754fcb98828e147730503e9b705b
Author: tapted <tapted@chromium.org>
Date: Sat Jun 04 10:19:13 2016

MacViewsBrowser: Provide a stub for ChromeExtensionChooserDialog::ShowDialog()

Fixes a MacViewsBrowser link error after r397320, starting at
http://go/macviewsbuilder/builds/11045, like

Undefined symbols for architecture x86_64:
  "ChromeExtensionChooserDialog::ShowDialog(ChooserController*) const", referenced from:
      ChromeExtensionBluetoothChooser::ChromeExtensionBluetoothChooser

MacViewsBrowser needs a ShowDialog() symbol, which will provide the
toolkit-views implementation when it's ready.

BUG= 425229 ,  613638 
TBR=juncai@chromium.org

Review-Url: https://codereview.chromium.org/2036033003
Cr-Commit-Position: refs/heads/master@{#397911}

[modify] https://crrev.com/10f34889bd88754fcb98828e147730503e9b705b/chrome/browser/extensions/chrome_extension_chooser_dialog.h
[modify] https://crrev.com/10f34889bd88754fcb98828e147730503e9b705b/chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.cc
[modify] https://crrev.com/10f34889bd88754fcb98828e147730503e9b705b/chrome/browser/ui/views/browser_dialogs_views.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f

commit 0ef0cd4b19a045d8eb0960d4bac0da519c138f8f
Author: juncai <juncai@chromium.org>
Date: Fri Jun 10 19:09:51 2016

Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG= 613638 ,  577170 

Review-Url: https://codereview.chromium.org/2034163002
Cr-Commit-Position: refs/heads/master@{#399247}

[modify] https://crrev.com/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f/chrome/browser/extensions/chrome_extension_chooser_dialog.h
[modify] https://crrev.com/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2

commit e2fa57eacaf6a1a8f0fd8449603e29e647b183c2
Author: juncai <juncai@chromium.org>
Date: Tue Jun 14 18:53:41 2016

Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

This CL modified code to make ChromeExtensionChooserDialog::ShowDialog
work for MacViews.

BUG= 613638 ,  577170 

Review-Url: https://codereview.chromium.org/2065803002
Cr-Commit-Position: refs/heads/master@{#399760}

[rename] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/chooser_content_view_cocoa.h
[rename] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/chrome_browser_ui.gypi

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f

commit 0ef0cd4b19a045d8eb0960d4bac0da519c138f8f
Author: juncai <juncai@chromium.org>
Date: Fri Jun 10 19:09:51 2016

Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG= 613638 ,  577170 

Review-Url: https://codereview.chromium.org/2034163002
Cr-Commit-Position: refs/heads/master@{#399247}

[modify] https://crrev.com/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f/chrome/browser/extensions/chrome_extension_chooser_dialog.h
[modify] https://crrev.com/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2

commit e2fa57eacaf6a1a8f0fd8449603e29e647b183c2
Author: juncai <juncai@chromium.org>
Date: Tue Jun 14 18:53:41 2016

Make ChromeExtensionChooserDialog::ShowDialog work for MacViews

This CL modified code to make ChromeExtensionChooserDialog::ShowDialog
work for MacViews.

BUG= 613638 ,  577170 

Review-Url: https://codereview.chromium.org/2065803002
Cr-Commit-Position: refs/heads/master@{#399760}

[rename] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/chooser_content_view_cocoa.h
[rename] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/e2fa57eacaf6a1a8f0fd8449603e29e647b183c2/chrome/chrome_browser_ui.gypi

Sign in to add a comment