New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613637 link

Starred by 1 user
Status: Fixed
Owner:
█ lilyhoughton@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 613621



Sign in to add a comment

Rename ProxyService --> ProxyResolutionService

Project Member Reported by eroman@chromium.org, May 20 2016 
See motivation in  issue 613632 .

ProxyService is all about proxy resolution, not other interactions like communicating with a proxy server. Its name should reflect this to make its role and layer clearer.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c2f97d546a70213aaca24509d716e3cb780bc2b

commit 8c2f97d546a70213aaca24509d716e3cb780bc2b
Author: Lily Houghton <lilyhoughton@chromium.org>
Date: Mon Jan 22 05:06:59 2018

Rename ProxyService class to ProxyResolutionService

TBR=bolio@chromium.org,mmenke@chromium.org,gene@chromium.org,halliwell@chromium.org,stevenjb@chromium.org,bengr@chromium.org,alexmos@chromium.org,mkwst@chromium.org,sky@chromium.org,reillyg@chromium.org,dimich@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,garykac@chromium.org

Bug:  613637 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie296831e1bcb402274e416d85fab43f5f2db5e49
Reviewed-on: https://chromium-review.googlesource.com/857421
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530810}
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/android_webview/browser/net/aw_url_request_context_getter_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chrome/browser/io_thread.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chrome/browser/io_thread.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chrome/browser/net/predictor.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chrome/browser/net/predictor.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chrome/browser/net/predictor_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chrome/service/net/service_url_request_context_getter.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chromecast/browser/url_request_context_factory.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chromeos/dbus/services/proxy_resolution_service_provider.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chromeos/dbus/services/proxy_resolution_service_provider.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/chromeos/network/proxy/proxy_config_service_impl_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/cronet/android/cronet_library_loader.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/cronet/cronet_global_state.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/cronet/cronet_url_request_context.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/proxy_config/ios/proxy_service_factory.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/components/proxy_config/ios/proxy_service_factory.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/browser/renderer_host/pepper/pepper_network_proxy_host.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/browser/renderer_host/pepper/pepper_network_proxy_host.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/browser/resolve_proxy_msg_helper.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/browser/resolve_proxy_msg_helper.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/browser/resolve_proxy_msg_helper_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/network/network_context_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/network/proxy_service_mojo.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/network/proxy_service_mojo.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/network/url_request_context_builder_mojo.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/public/network/url_request_context_builder_mojo.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/shell/browser/layout_test/layout_test_url_request_context_getter.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/shell/browser/shell_url_request_context_getter.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/content/test/proxy_service_mojo_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/device/test/usb_test_gadget_impl.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/google_apis/gcm/engine/connection_factory_impl.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/google_apis/gcm/tools/mcs_probe.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/ios/components/io_thread/ios_io_thread.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/ios/web/shell/shell_url_request_context_getter.mm
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/ios/web_view/internal/web_view_url_request_context_getter.mm
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/base/proxy_delegate.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/cert_net/cert_net_fetcher_impl_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_network_layer.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_network_layer_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_network_session.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_network_session.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_network_transaction_ssl_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_response_body_drainer_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_stream_factory_impl_job.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_stream_factory_impl_job_controller.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_stream_factory_impl_request_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/log/net_log_event_type_list.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/log/net_log_util.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/pac_file_decider.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/pac_file_fetcher_impl_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_config_service.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_config_service_linux.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_info.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_list.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_resolver_v8_tracing.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_server.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_service.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_service.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/quic/chromium/quic_end_to_end_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/spdy/chromium/spdy_test_util_common.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/spdy/chromium/spdy_test_util_common.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/tools/net_watcher/net_watcher.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_fetcher_impl_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_context.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_context.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_context_builder.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_context_storage.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_context_storage.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_ftp_job.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_ftp_job.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_http_job_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_test_util.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/websockets/websocket_test_util.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/net/websockets/websocket_test_util.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/remoting/base/url_request_context_getter.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/services/network/public/cpp/proxy_resolving_client_socket.cc
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/services/network/public/cpp/proxy_resolving_client_socket.h
[modify] https://crrev.com/8c2f97d546a70213aaca24509d716e3cb780bc2b/services/network/public/cpp/proxy_resolving_client_socket_unittest.cc

Comment 2 by lilyhoughton@chromium.org, Jan 22 2018

Owner: lilyhoughton@chromium.org
Status: Fixed (was: Untriaged)

Comment 3 by eroman@chromium.org, Jan 22 2018 

Sorry I missed this in the code review:

We also should rename

   proxy_service.h
   proxy_service.cc
   proxy_service_unittest.cc

To proxy_resolution_service*.
(even if it is a bit redundant with the directory name).
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cb5f0bfcf845d310a3e50858b3ae99d9a146ebf

commit 2cb5f0bfcf845d310a3e50858b3ae99d9a146ebf
Author: Lily Houghton <lilyhoughton@chromium.org>
Date: Tue Mar 06 20:12:19 2018

Rename proxy service event types

This is a follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/857421 that renames
the PROXY_SERVICE_* event types.

Bug:  613637 
Change-Id: Iabe3c5706952b45c9a3c253feed290d5a872f13b
Reviewed-on: https://chromium-review.googlesource.com/944001
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541181}
[modify] https://crrev.com/2cb5f0bfcf845d310a3e50858b3ae99d9a146ebf/net/log/net_log_event_type_list.h
[modify] https://crrev.com/2cb5f0bfcf845d310a3e50858b3ae99d9a146ebf/net/proxy_resolution/proxy_service.cc
[modify] https://crrev.com/2cb5f0bfcf845d310a3e50858b3ae99d9a146ebf/net/proxy_resolution/proxy_service_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe89daa07d632182129e7ce8193d0434264fc4a

commit ffe89daa07d632182129e7ce8193d0434264fc4a
Author: Lily Houghton <lilyhoughton@chromium.org>
Date: Fri Mar 09 18:30:03 2018

Rename net/proxy_resolution/proxy_service* files

This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/857421

NOPRESUBMIT=true
TBR=boliu@chromium.org,mmenke@chromium.org,gene@chromium.org,halliwell@chromium.org,stevenjb@chromium.org,dougarnett@chromium.org,peter@chromium.org,sky@chromium.org,skyostil@chromium.org,eugenebut@chromium.org

Bug:  613637 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6deaf5c511a2e5d9867c5d65715550881af8d010
Reviewed-on: https://chromium-review.googlesource.com/941901
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Gene Gutnik <gene@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542170}
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/android_webview/browser/net/aw_url_request_context_getter_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/chrome/browser/io_thread.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/chrome/browser/net/predictor.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/chrome/browser/net/predictor_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/chrome/service/net/service_url_request_context_getter.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/chromeos/dbus/services/proxy_resolution_service_provider.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/cronet/android/cronet_library_loader.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/cronet/cronet_global_state_stubs.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/cronet/cronet_url_request_context.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/cronet/ios/cronet_global_state_ios.mm
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/components/proxy_config/ios/proxy_service_factory.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/content/browser/renderer_host/pepper/pepper_network_proxy_host.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/content/browser/resolve_proxy_msg_helper.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/content/browser/resolve_proxy_msg_helper_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/content/test/proxy_service_mojo_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/device/test/usb_test_gadget_impl.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/google_apis/gcm/engine/connection_factory_impl.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/headless/public/headless_browser_context.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/ios/web/shell/shell_url_request_context_getter.mm
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/ios/web_view/internal/web_view_url_request_context_getter.mm
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/BUILD.gn
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_network_layer_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_network_session.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_network_session_peer.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_network_transaction.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_network_transaction_ssl_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_response_body_drainer_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_stream_factory_impl_job.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_stream_factory_impl_request_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/log/net_log_util.cc
[rename] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/proxy_resolution/proxy_resolution_service.cc
[rename] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/proxy_resolution/proxy_resolution_service.h
[rename] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/proxy_resolution/proxy_resolution_service_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/quic/chromium/quic_end_to_end_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/spdy/chromium/spdy_test_util_common.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/tools/net_watcher/net_watcher.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/url_request/url_request_context_builder.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/url_request/url_request_context_storage.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/url_request/url_request_ftp_job.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/url_request/url_request_test_util.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/websockets/websocket_stream_test.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/net/websockets/websocket_test_util.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/services/network/network_context_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/services/network/proxy_resolving_client_socket.h
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/services/network/proxy_resolving_client_socket_unittest.cc
[modify] https://crrev.com/ffe89daa07d632182129e7ce8193d0434264fc4a/services/network/proxy_service_mojo.cc
►

Sign in to add a comment