New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613631 link

Starred by 1 user
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Change of console.__proto__ is observable on each Object

Project Member Reported by kozyatinskiy@chromium.org, May 20 2016 
Following code will dump 42 instead of nothing.

console.__proto__.p = 42;
for (var p in {}) console.log(p);
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13837c1b636160af20007454d677abda33833da9

commit 13837c1b636160af20007454d677abda33833da9
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri May 20 20:12:50 2016

[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

This is a temporary fix, while discussion about proper solution continue in https://github.com/whatwg/console/issues/3 .

BUG= 613631 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/1995423002
Cr-Commit-Position: refs/heads/master@{#395149}

[add] https://crrev.com/13837c1b636160af20007454d677abda33833da9/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto-expected.txt
[add] https://crrev.com/13837c1b636160af20007454d677abda33833da9/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto.html
[modify] https://crrev.com/13837c1b636160af20007454d677abda33833da9/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Comment 2 by kozyatinskiy@chromium.org, May 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment