Clank ToT bot failing with "Dead store to local variable" |
||
Issue descriptionExample failure: https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/clang-clankium-tot-builder/builds/27330/steps/compile/logs/stdio [12835/13390] ACTION //chrome/android:chrome_sync_shell_test_apk_java__findbugs(//build/toolchain/android:clang_arm) FAILED: gen/chrome/android/chrome_sync_shell_test_apk_java__findbugs.d gen/chrome/android/chrome_sync_shell_test_apk_java__findbugs/result.xml python ../../build/android/findbugs_diff.py --depfile gen/chrome/android/chrome_sync_shell_test_apk_java__findbugs.d --exclude ../../build/android/findbugs_filter/findbugs_exclude.xml --auxclasspath-gyp @FileArg\(gen/chrome/android/chrome_sync_shell_test_apk_java.build_config:javac:classpath\) --output-file gen/chrome/android/chrome_sync_shell_test_apk_java__findbugs/result.xml lib.java/chrome/android/chrome_sync_shell_test_apk_java.jar ******************************************************************************** FindBugs run via: java -classpath /b/build/slave/clang-clankium-tot-builder/build/src/third_party/findbugs/lib/findbugs.jar: -Xmx768m -Dfindbugs.home="/b/build/slave/clang-clankium-tot-builder/build/src/third_party/findbugs" -jar /b/build/slave/clang-clankium-tot-builder/build/src/third_party/findbugs/lib/findbugs.jar -textui -sortByClass -pluginList /b/build/slave/clang-clankium-tot-builder/build/src/tools/android/findbugs_plugin/lib/chromiumPlugin.jar -xml:withMessages -auxclasspath /b/build/slave/clang-clankium-tot-builder/build/src/third_party/android_tools/sdk/platforms/android-23/android.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/base/base_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/base/base_java_test_support.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/chrome/android/chrome_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/chrome/test/android/chrome_java_test_support.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/components/bookmarks/common/android/bookmarks_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/components/policy/android/policy_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/content/public/android/content_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/content/public/test/android/content_java_test_support.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/sync/sync_java_test_support.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/sync/test_support_sync_proto_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/sync/android/sync_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/third_party/android_protobuf/protobuf_nano_javalib.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/third_party/android_tools/android_support_v13_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_appcompat_java.jar:/b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/ui/android/ui_java.jar -exclude /b/build/slave/clang-clankium-tot-builder/build/src/build/android/findbugs_filter/findbugs_exclude.xml -output gen/chrome/android/chrome_sync_shell_test_apk_java__findbugs/result.xml /b/build/slave/clang-clankium-tot-builder/build/src/out/Debug/lib.java/chrome/android/chrome_sync_shell_test_apk_java.jar FindBugs reported the following issues: DLS_DEAD_LOCAL_STORE: Dead store to local variable In class org.chromium.chrome.browser.sync.SyncTest In method org.chromium.chrome.browser.sync.SyncTest.testStopAndClear() At SyncTest.java:[line 70] ********************************************************************************
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae1c373ff95da3c1386ddf89422036e29a396c95 commit ae1c373ff95da3c1386ddf89422036e29a396c95 Author: aelias <aelias@chromium.org> Date: Fri May 20 18:04:28 2016 Revert of [sync] Sign user out of Chrome on dashboard stop and reset (patchset #4 id:160001 of https://codereview.chromium.org/1976423002/ ) Reason for revert: New test testStopAndClear causes findbugs error on Clank ToT bot. BUG= 613629 Original issue's description: > [sync] Sign user out of Chrome on dashboard stop and reset > > Currently every platform except Android and ChromeOS log out of chrome upon a > dashboard stop and clear. This CL removes the special case for Android and adds > some machinery to notify Android Java code that sign out occurred. This > notification prompts Android's SigninManager to clear Android specific state. > > BUG=596611 > > R=maxbogue@chromium.org > > Committed: https://crrev.com/359ced3af82ddfc61114a801c62b1da4c79e7565 > Cr-Commit-Position: refs/heads/master@{#395099} TBR=maxbogue@chromium.org,pnoland@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596611 Review-Url: https://codereview.chromium.org/2004523002 Cr-Commit-Position: refs/heads/master@{#395115} [modify] https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java [modify] https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java [modify] https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java [modify] https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95/chrome/browser/android/signin/signin_manager_android.cc [modify] https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95/chrome/browser/android/signin/signin_manager_android.h [modify] https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95/components/browser_sync/browser/profile_sync_service.cc [modify] https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95/components/browser_sync/browser/profile_sync_service_unittest.cc
,
May 20 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by aelias@chromium.org
, May 20 2016Labels: OS-Android