Need input latency metrics for out of process iframes |
||||||||
Issue descriptionI changed signature for ProcessMouseEvent and ProcessMouseWheelEvent functions. They now get latency_info as an input and pass it along with forwarding Mouse/MouseWheel events. In cross_process_frame_connector.cc and render_widget_host_input_event_router.cc files, I just instantiated an object by LatencyInfo() and passed it to the Process functions wherever needed. To collect input latency metrics, these latency info objects must be input arguments of the caller functions rather than being created within them.
,
May 25 2016
I'll take ownership for now. I've added creis@ and kenrb@ as they may know more about how useful it would be for them to have this information sooner as opposed to later.
,
May 25 2016
This is more pressing for --top-document-isolation than --isolate-extensions, so I'll add Nick to comment.
,
May 25 2016
tdresser: I've looked through the patch and it should be pretty simple to add the LatencyInfo to RenderWidgetHostInputEventRouter, it's just adding an argument in the call site from RenderWidgetHostView{Aura,Mac,etc}. We should probably do that in that CL.
The more complicated case is when the scroll event bubbles from the child renderer to the parent, but we should define exactly what we want to measure here, are we looking for the full time the event gets processed in both processes? Or two separate times, one for each process? The first case is much harder, since this information is lost going to blink and back, but the second case should be pretty simple as well.
,
Dec 2 2017
,
Dec 4 2017
mcnee@ - Do you mind taking a look at this? I think for the bubbling case that lfg@'s second case is probably a reasonable approach.
,
Dec 4 2017
,
Dec 4 2017
We appear to already be doing this. RenderWidgetHostInputEventRouter takes a LatencyInfo as a parameter for its Route*Event and passes it on to the view's Process*Event. We only create new LatencyInfos in - a RWHVGuest code path in RWHIER::RouteMouseEvent - RWHIER::SendMouseEnterOrLeaveEvents - RWHIER::BubbleScrollEvent The use of a new LatencyInfo for the resent scroll event matches the second case. If we want the first approach with the same LatencyInfo, it looks like we could have RenderWidgetHostImpl::OnGestureEventAck pass it along to the view's GestureEventAck.
,
Dec 4 2017
creis@ - It looks like this is already implemented, though if we want the full time it takes the event to get processed including bubbling then we may need to do some more work ... do we want that?
,
Aug 1
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tdres...@chromium.org
, May 20 2016