Report version of GMS Core in crash reports |
||
Issue descriptionWe're seeing some issues that cut across chrome versions (e.g. b/28813192) but depend on version of gms core. I think we should report back the version of gms along with crash reports. This means, caching the value in buildinfo (which may be wrong if it updates while chrome is being used - I think this is tolerable error) and adding it to the tombstone when reporting a crash. We should then add this as a dimension/reporting in crash. hzl: do you think you can pick this up after currently work on feedback ingestion?
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e36a130a8f123cec0b941f71284436c86bbfe659 commit e36a130a8f123cec0b941f71284436c86bbfe659 Author: hzl <hzl@google.com> Date: Fri Jun 10 17:50:17 2016 Includes GMS version in crash report. We saw crashes happen that vary between GMS, but GMS info is not recorded by chrome crash yet. In this cl, we will add GMS version code to crash report. BUG= 613618 Review-Url: https://codereview.chromium.org/2014693003 Cr-Commit-Position: refs/heads/master@{#399224} [modify] https://crrev.com/e36a130a8f123cec0b941f71284436c86bbfe659/base/android/build_info.cc [modify] https://crrev.com/e36a130a8f123cec0b941f71284436c86bbfe659/base/android/build_info.h [modify] https://crrev.com/e36a130a8f123cec0b941f71284436c86bbfe659/base/android/java/src/org/chromium/base/BuildInfo.java [modify] https://crrev.com/e36a130a8f123cec0b941f71284436c86bbfe659/components/crash/content/app/breakpad_linux.cc
,
Jun 14 2016
,
Jun 14 2016
Do we need to work with the chromecrash/ team to display this in the frontend? Or will that occur as part of existing functionality?
,
Jun 14 2016
b/29356229 was created to track this. By default, it will show just up in the key-value pair (report's "Fields" tab, "Product data" section at the bottom). If any special handling is needed, could you, please, comment on the server side bug? Thanks!
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e36a130a8f123cec0b941f71284436c86bbfe659 commit e36a130a8f123cec0b941f71284436c86bbfe659 Author: hzl <hzl@google.com> Date: Fri Jun 10 17:50:17 2016 Includes GMS version in crash report. We saw crashes happen that vary between GMS, but GMS info is not recorded by chrome crash yet. In this cl, we will add GMS version code to crash report. BUG= 613618 Review-Url: https://codereview.chromium.org/2014693003 Cr-Commit-Position: refs/heads/master@{#399224} [modify] https://crrev.com/e36a130a8f123cec0b941f71284436c86bbfe659/base/android/build_info.cc [modify] https://crrev.com/e36a130a8f123cec0b941f71284436c86bbfe659/base/android/build_info.h [modify] https://crrev.com/e36a130a8f123cec0b941f71284436c86bbfe659/base/android/java/src/org/chromium/base/BuildInfo.java [modify] https://crrev.com/e36a130a8f123cec0b941f71284436c86bbfe659/components/crash/content/app/breakpad_linux.cc
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6de7c9a7644fbcde203abda75c7a243dc4038da commit b6de7c9a7644fbcde203abda75c7a243dc4038da Author: hzl <hzl@google.com> Date: Wed Jun 22 23:06:22 2016 Added gms version as key value pair. Added gms version as key value pair in the crash report. This will make it easier for the server to retrieve the information. BUG= 613618 Review-Url: https://codereview.chromium.org/2089343002 Cr-Commit-Position: refs/heads/master@{#401447} [modify] https://crrev.com/b6de7c9a7644fbcde203abda75c7a243dc4038da/components/crash/content/app/breakpad_linux.cc |
||
►
Sign in to add a comment |
||
Comment 1 by hzl@chromium.org
, May 25 2016