New issue
Advanced search Search tips

Issue 613617 link

Starred by 0 users
Status: Verified
Owner:
apronin@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Build for trunks with tpm2 and ftdi support is broken

Project Member Reported by apronin@chromium.org, May 20 2016 
Running:
USE="tpm2 ftdi_tpm" emerge-$board trunks

Leads to errors like:
In file included from ../../../../../../../tmp/portage/chromeos-base/trunks-0.0.1-r1200/work/trunks-0.0.1/aosp/system/tpm/trunks/ftdi/mpsse.c:30:
/build/kevin/tmp/portage/chromeos-base/trunks-0.0.1-r1200/work/trunks-0.0.1/aosp/system/tpm/trunks/ftdi/support.h:2:1: error: '/*' within block comment [-Werror,-Wcomment]
/*
^
Project Member

Comment 1 by bugdroid1@chromium.org, May 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/tpm/+/2b8ca4be7415307544fd34d275ceb9666ce7bdc6

commit 2b8ca4be7415307544fd34d275ceb9666ce7bdc6
Author: Andrey Pronin <apronin@google.com>
Date: Thu May 19 20:13:59 2016

Fixed copyright headers

Copyrights headers fixed: nested comments were left previously
after merging two copyrights.

BUG= chromium:613617 
TEST=Build trunks with USE='tpm2 ftdi_tpm'

Change-Id: I290c65ecfcb4f2637df298ee14ba4dd799c421f8
Reviewed-on: https://chromium-review.googlesource.com/346226
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@google.com>

[modify] https://crrev.com/2b8ca4be7415307544fd34d275ceb9666ce7bdc6/trunks/ftdi/support.h
[modify] https://crrev.com/2b8ca4be7415307544fd34d275ceb9666ce7bdc6/trunks/ftdi/support.c

Comment 2 by apronin@chromium.org, May 24 2016

Status: Verified (was: Untriaged)

Comment 3 by apronin@chromium.org, May 24 2016

Owner: apronin@chromium.org
►

Sign in to add a comment