Issue metadata
Sign in to add a comment
|
Global-buffer-overflow in XFA_GetMethodByName |
||||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=5998214892748800 Fuzzer: ifratric_acrojs Job Type: linux_asan_pdfium Platform Id: linux Crash Type: Global-buffer-overflow READ 4 Crash Address: 0x0000042d0920 Crash State: XFA_GetMethodByName CXFA_ScriptContext::NormalPropTypeGetter FXJSE_V8_GenericNamedPropertySetterCallback Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_pdfium&range=393856:393893 Minimized Testcase (2582.82 Kb): https://cluster-fuzz.appspot.com/download/AMIfv974sF8VpioeVxJCUAES0UNJHSZ_-vFKkBNjjj_D2SXCLLyIaWnRmBrw9l1y4bekGs0YduBzV8opd6PyyFlupY3qr0pk95LpAhxMxp2oRw94ZWIknXDO27U1yT4ykg2NNbd2NvmnvNEGYxjbKmR3e3CVDj93Zkz1aqRUbywsHYhDKov_gQ8 Filer: ochang See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
May 20 2016
The CF testcase is marked as "Unreproducible", but running that testcase locally gives me a null deref with a similar stack.
,
May 21 2016
,
May 23 2016
,
May 25 2016
pennymac, friendly ping - was any progress made here? bug 612922 (which is owned by tsepez@) might be related.
,
May 25 2016
I'll take this, similar to the related bug. Repro's with a segv in pdfium_test on linux.
,
May 25 2016
At https://code.google.com/p/chromium/codesearch#chromium/src/third_party/pdfium/xfa/fxjse/util_inline.h&rcl=1464117624&l=22, we use the presence of an internal field to tell if this is a FXJSE object, but that isn't sufficient. I'm guessing this is being applied to the wrong object type. Jochen, I recall you took a look at this at one point? Thoughts
,
May 26 2016
Note that the lpClass argument to FXJSE_RetrieveObjectBinding() is always null, which means that the secondary check at line 40 never happens.
,
May 27 2016
Issue 615381 has been merged into this issue.
,
May 30 2016
would be rad if clusterfuzz included the JS in plain text for pdf fuzzers...
,
May 30 2016
This might because the interceptor uses the "This()" value, while the actual object that has the intereptor on it is the Holder() value. The XFA code is ridiculously bad :-/
,
May 31 2016
https://pdfium.googlesource.com/pdfium/+/3a005f22703b9303a306bf34cbd17c3729f763aa may take care of this.
,
May 31 2016
,
May 31 2016
,
May 31 2016
Adding Merge-Triage label for tracking purposes. Once your fix had sufficient bake time (on canary, dev as appropriate), please nominate your fix for merge by adding the Merge-Request-XX label, where XX is the Chrome milestone. When your merge is approved by the release manager, please start merging with higher milestone label first. Make sure to re-request merge for every milestone in the label list. You can get branch information on omahaproxy.appspot.com. - Your friendly ClusterFuzz
,
Jun 1 2016
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0191740cd56ba9de20ca1add6964d6b9023fd555 commit 0191740cd56ba9de20ca1add6964d6b9023fd555 Author: ochang <ochang@chromium.org> Date: Thu Jun 02 05:46:03 2016 Roll PDFium d23df55..c324646 https://pdfium.googlesource.com/pdfium.git/+log/d23df55..c324646 BUG= 616248 , 427616 , 613623 , 616246 , 613607 TBR=thestig@chromium.org Review-Url: https://codereview.chromium.org/2034443002 Cr-Commit-Position: refs/heads/master@{#397297} [modify] https://crrev.com/0191740cd56ba9de20ca1add6964d6b9023fd555/DEPS
,
Jun 20 2016
,
Jun 20 2016
,
Jun 20 2016
,
Jun 20 2016
ochang: Didn't we turn off XFA for M-52?
,
Jun 20 2016
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
,
Jun 20 2016
Yep. It should be turned off -- removing request labels.
,
Jun 20 2016
,
Sep 7 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 1 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by och...@chromium.org
, May 20 2016