[Remoting Android] Move Credits back into Help & Feedback's overflow menu |
||||
Issue descriptionThe internal CL https://chromereviews.googleplex.com/372457013/ makes use of Google's help API but couldn't show the Credits option in the overflow menu due to some security reasons. The CL https://codereview.chromium.org/1997793002/ made it show the Credits option in the navigation menu. We should move it back to the overflow menu as other apps do. https://docs.google.com/document/d/1r-fQ8AHWVaWXV5TL9oexqanyIP1mv4hMyvgbDIAUh3I/preview# see: 7) Additional overflow menu support We should use Intent.ACTION_VIEW and pass in the URL of the credits page and whitelist that URL on the help API.
,
Sep 30 2016
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ce42140740209a646cffb2178455533906dc811 commit 3ce42140740209a646cffb2178455533906dc811 Author: yuweih <yuweih@chromium.org> Date: Mon Oct 03 20:46:23 2016 [Remoting Android] Export CreditsActivity Currently CreditsActivity is not marked as exported, which means the internal Help&Feedback library doesn't have permission to launch CreditsActivity and therefore we can't move the Credits menu item back to Help&Feedback's overflow menu. This CL marks CreditsActivity as exported to solve the problem above. BUG= 613604 Review-Url: https://codereview.chromium.org/2384803002 Cr-Commit-Position: refs/heads/master@{#422519} [modify] https://crrev.com/3ce42140740209a646cffb2178455533906dc811/remoting/android/java/AndroidManifest.xml.jinja2
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84f1fd3a7766e37932e6e86b3f17e9260dee1344 commit 84f1fd3a7766e37932e6e86b3f17e9260dee1344 Author: yuweih <yuweih@chromium.org> Date: Mon Oct 03 23:19:14 2016 [Remoting Android] Navigation Menu Cleanups This CL: * Removes the Credits item from the menu since it will be merged into Help's overflow menu. * Refactors the item layout so that we only needs one XML and specifying icon and text in the code. BUG= 613604 Review-Url: https://codereview.chromium.org/2383283002 Cr-Commit-Position: refs/heads/master@{#422590} [modify] https://crrev.com/84f1fd3a7766e37932e6e86b3f17e9260dee1344/remoting/android/java/res/layout/navigation_list_item.xml [delete] https://crrev.com/fd7bb627894ab5fc1415c90f579dba779fddc70f/remoting/android/java/res/menu/credits_list_item.xml [delete] https://crrev.com/fd7bb627894ab5fc1415c90f579dba779fddc70f/remoting/android/java/res/menu/feedback_list_item.xml [delete] https://crrev.com/fd7bb627894ab5fc1415c90f579dba779fddc70f/remoting/android/java/res/menu/help_list_item.xml [modify] https://crrev.com/84f1fd3a7766e37932e6e86b3f17e9260dee1344/remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java
,
Oct 4 2016
,
Oct 7 2016
Credits are found in the help overflow menu. Verified in 55.0.2882.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by lambroslambrou@chromium.org
, May 20 2016