New issue
Advanced search Search tips

Issue 613596 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Modify DevicePermissionsDialogView to disable Connect button when no device found or no device selected

Project Member Reported by juncai@chromium.org, May 20 2016

Issue description

When no device found or no device selected, the "Connect" button needs to be disabled.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/934705e07d1a26be6c3e67c413c99cf888b93a02

commit 934705e07d1a26be6c3e67c413c99cf888b93a02
Author: juncai <juncai@chromium.org>
Date: Wed Jun 08 16:58:55 2016

In DevicePermissionsDialogView disable Connect button if no device selected

When no device selected in the dialog, the "Connect" button needs to be
disabled.

BUG= 613596 

Review-Url: https://codereview.chromium.org/2045093002
Cr-Commit-Position: refs/heads/master@{#398602}

[modify] https://crrev.com/934705e07d1a26be6c3e67c413c99cf888b93a02/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
[modify] https://crrev.com/934705e07d1a26be6c3e67c413c99cf888b93a02/chrome/browser/ui/views/extensions/device_permissions_dialog_view.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd72b6044eb4d50ddae075d15f36f286a89232f

commit 6bd72b6044eb4d50ddae075d15f36f286a89232f
Author: juncai <juncai@chromium.org>
Date: Thu Jun 09 18:40:45 2016

In DevicePermissionsViewController disable Connect button if no device selected on Mac

When no device selected in the dialog, the "Connect" button needs to be
disabled.

BUG= 613596 

Review-Url: https://codereview.chromium.org/2058433002
Cr-Commit-Position: refs/heads/master@{#398958}

[modify] https://crrev.com/6bd72b6044eb4d50ddae075d15f36f286a89232f/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

Comment 3 by juncai@chromium.org, Jun 14 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd72b6044eb4d50ddae075d15f36f286a89232f

commit 6bd72b6044eb4d50ddae075d15f36f286a89232f
Author: juncai <juncai@chromium.org>
Date: Thu Jun 09 18:40:45 2016

In DevicePermissionsViewController disable Connect button if no device selected on Mac

When no device selected in the dialog, the "Connect" button needs to be
disabled.

BUG= 613596 

Review-Url: https://codereview.chromium.org/2058433002
Cr-Commit-Position: refs/heads/master@{#398958}

[modify] https://crrev.com/6bd72b6044eb4d50ddae075d15f36f286a89232f/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

Sign in to add a comment