New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613595 link

Starred by 1 user
Status: Fixed
Owner:
█ haibinlu@chromium.org
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Blimp browser test failed due to client token retrieval.

Project Member Reported by haibinlu@chromium.org, May 20 2016
Project Member

Comment 1 by bugdroid1@chromium.org, May 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd769b0598af6e84b81b0bd1114aa2d362560040

commit cd769b0598af6e84b81b0bd1114aa2d362560040
Author: haibinlu <haibinlu@chromium.org>
Date: Sat May 21 02:13:15 2016

Fixes Blimp engine browser test due to reading client token file.

Uses const char[] for client assignment instead of reading it from the file.

IO is not allowed on the thread. Because ScopedAllowIO is banned, posting task would make test setup flow harder to read.

BUG= 613595 

Review-Url: https://codereview.chromium.org/2000883003
Cr-Commit-Position: refs/heads/master@{#395234}

[modify] https://crrev.com/cd769b0598af6e84b81b0bd1114aa2d362560040/blimp/test/browser_tests/blimp_browser_test.cc

Comment 2 by haibinlu@chromium.org, May 23 2016

Status: Fixed (was: Assigned)

Comment 3 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment