New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613593 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[mac] vectorize bookmark bar folder icons

Project Member Reported by est...@chromium.org, May 20 2016

Issue description

These are the last icons holding up complete removal of the chrome_material_*_percent.pak build step. We need to either vectorize mac's bookmark bar folder icons or launch MD and remove pre-md resources.
 

Comment 1 by meh...@chromium.org, May 20 2016

Cc: shrike@chromium.org
+shrike@ for Mac MD bugs.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1b58bc469a867bc45c396ffb97a91274f692578

commit d1b58bc469a867bc45c396ffb97a91274f692578
Author: estade <estade@chromium.org>
Date: Fri Aug 05 22:22:42 2016

Remove material design resource pak infrastructure

This was only still being used by OSX for three PNGs, but OSX has
already switched to MD by default in the stable channel, so there's no
need to keep the old assets or the heaps of code to support switching.
Yay.

(This CL doesn't vectorize the mac icons, it just removes the pre-md
raster asset in favor of md raster assets.)

BUG=505953, 613593 

Review-Url: https://codereview.chromium.org/2209363002
Cr-Commit-Position: refs/heads/master@{#410188}

[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/BUILD.gn
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/app/theme/BUILD.gn
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/app/theme/default_100_percent/mac/bookmark_bar_folder.png
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_managed.png
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_supervised.png
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/app/theme/default_200_percent/mac/bookmark_bar_folder.png
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_managed.png
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_supervised.png
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/app/theme/material_100_percent/mac/bookmark_bar_folder.png
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/app/theme/material_100_percent/mac/bookmark_bar_folder_managed.png
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/app/theme/material_100_percent/mac/bookmark_bar_folder_supervised.png
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/app/theme/material_200_percent/mac/bookmark_bar_folder.png
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/app/theme/material_200_percent/mac/bookmark_bar_folder_managed.png
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/app/theme/material_200_percent/mac/bookmark_bar_folder_supervised.png
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/browser/chrome_browser_main.cc
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/browser/chrome_browser_main_mac_browsertest.mm
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/chrome_dll_bundle.gypi
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/chrome_repack_chrome_material_100_percent.gypi
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/chrome_repack_chrome_material_200_percent.gypi
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/chrome_resources.gyp
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/chrome_tests.gypi
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/chrome/test/BUILD.gn
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/BUILD.gn
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/data_pack.cc
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/data_pack.h
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/resource_bundle.h
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/resource_bundle_mac.mm
[delete] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/ui/base/resource/resource_bundle_mac_unittest.mm
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/resource_bundle_unittest.cc
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/resource_data_dll_win.cc
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/resource_data_dll_win.h
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/resource/resource_handle.h
[modify] https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578/ui/base/ui_base_tests.gyp

Components: UI>Browser>Bookmarks
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 22 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by lgrey@chromium.org, Aug 22 2017

Cc: est...@chromium.org
[Mac triage] estade@ is this OK to mark fixed?

Comment 6 by est...@chromium.org, Aug 23 2017

Cc: -shrike@chromium.org
Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)
no, so far as I know it's not fixed.

Comment 7 by shrike@chromium.org, Aug 23 2017

Cc: shrike@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 23

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)

Sign in to add a comment