New issue
Advanced search Search tips

Issue 613583 link

Starred by 1 user
Status: Fixed
Owner:
glevin@chromium.org
Closed: May 2016
Cc:
js...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 475351



Sign in to add a comment

Native digits are not used in Copyright year

Project Member Reported by glevin@chromium.org, May 20 2016 
Version: 52.0.2724.0

What steps will reproduce the problem?
(1) Set language to one with non-Arabic numerals (e.g., Bengali, Marathi, Persian)
(2) Open either Settings > About or chrome://version, and read the Copyright line

What is the expected output?  What do you see instead?
The year in the Copyright line (e.g. "Copyright 2016 Google Inc. All rights reserved.") should use localized numerals.  Instead, numbers are always in Arabic (see screenshot from chrome://version page).

We do want to fix this, right?  "Google Inc" is left untranslated, but other surrounding text is localized, so I don't see why the year shouldn't be.
i18n_copyright.png
9.5 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d231d3546984ff7d4b22a8a97bd162b599f7e9f

commit 8d231d3546984ff7d4b22a8a97bd162b599f7e9f
Author: glevin <glevin@chromium.org>
Date: Fri May 27 19:02:42 2016

i18n of Copyright line to use locally correct numeric glyphs

BUG= 613583 
TEST=Switch to language with non-Arabic numerals (e.g., Persian), open
Settings > About or chrome://settings to view Copyright line. Check that
year is rendered with non-Arabic numerals.

Review-Url: https://codereview.chromium.org/1996993002
Cr-Commit-Position: refs/heads/master@{#396527}

[modify] https://crrev.com/8d231d3546984ff7d4b22a8a97bd162b599f7e9f/chrome/app/chromium_strings.grd
[modify] https://crrev.com/8d231d3546984ff7d4b22a8a97bd162b599f7e9f/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/8d231d3546984ff7d4b22a8a97bd162b599f7e9f/chrome/browser/ui/webui/help/help_handler.cc
[modify] https://crrev.com/8d231d3546984ff7d4b22a8a97bd162b599f7e9f/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/8d231d3546984ff7d4b22a8a97bd162b599f7e9f/chrome/browser/ui/webui/version_ui.cc
[modify] https://crrev.com/8d231d3546984ff7d4b22a8a97bd162b599f7e9f/chrome/chrome.gyp
[modify] https://crrev.com/8d231d3546984ff7d4b22a8a97bd162b599f7e9f/chrome/tools/mac_helpers/BUILD.gn
[modify] https://crrev.com/8d231d3546984ff7d4b22a8a97bd162b599f7e9f/chrome/tools/mac_helpers/infoplist_strings_util.mm

Comment 2 by glevin@chromium.org, May 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment